Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Workspace] Redirect "Sample data" link to the page in the same workspace #8330

Merged
merged 8 commits into from
Sep 30, 2024
Merged

[Workspace] Redirect "Sample data" link to the page in the same workspace #8330

Show file tree
Hide file tree
Changes from 7 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
e9d1385
Redirect Sample data link to the page in the same workspace
Kapian1234 Sep 25, 2024
47c4df8
Changeset file for PR #8330 created/updated
opensearch-changeset-bot[bot] Sep 25, 2024
3d67253
Optimize the code
Kapian1234 Sep 26, 2024
f023df4
Merge branch 'sample_data_link_redirect' of github.com:Kapian1234/Ope…
Kapian1234 Sep 26, 2024
a7a621c
Update unit test
Kapian1234 Sep 26, 2024
73dbb5b
Update unit test
Kapian1234 Sep 26, 2024
4dfb244
Update unit test
Kapian1234 Sep 26, 2024
131f45d
update snapshot
Kapian1234 Sep 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions changelogs/fragments/8330.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
fix:
- Redirect sample data link to the page in the same workspace ([#8330](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/8330))
1 change: 0 additions & 1 deletion ...ugins/dashboard/public/application/utils/__snapshots__/get_no_items_message.test.tsx.snap
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 2 additions & 1 deletion src/plugins/dashboard/public/application/utils/get_no_items_message.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ describe('dashboard listing table with no item', () => {

expect(component).toMatchSnapshot();
component.find(EuiLink).simulate('click');
expect(application.navigateToApp).toHaveBeenCalledTimes(1);

expect(application.navigateToApp).toHaveBeenCalledWith('import_sample_data');
});
});
8 changes: 1 addition & 7 deletions src/plugins/dashboard/public/application/utils/get_no_items_message.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,13 +59,7 @@
defaultMessage="New to OpenSearch Dashboards? {sampleDataInstallLink} to take a test drive."
values={{
sampleDataInstallLink: (
<EuiLink
onClick={() =>
application.navigateToApp('home', {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about call application.navigationToApp('import_sample_data') directly? Then we won't need so much modifications.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh I didn't know that. It's a much better way to do that, thanks!

path: '#/tutorial_directory/sampleData',
})
}
>
<EuiLink onClick={() => application.navigateToApp('import_sample_data')}>

Check warning on line 62 in src/plugins/dashboard/public/application/utils/get_no_items_message.tsx

View check run for this annotation

Codecov / codecov/patch

src/plugins/dashboard/public/application/utils/get_no_items_message.tsx#L62 

Added line #L62 was not covered by tests
<FormattedMessage
id="dashboard.listing.createNewDashboard.sampleDataInstallLinkText"
defaultMessage="Install some sample data"
Expand Down
Loading