[Workspace] Redirect "Sample data" link to the page in the same workspace #8330

Kapian1234 · 2024-09-25T09:13:12Z

Description

Redirect "Sample data" link to the page in the same workspace

Issues Resolved

Screenshot

workspace enabled

Screen.Recording.2024-09-29.at.17.17.55.mov

workspace disabled

Screen.Recording.2024-09-29.at.17.18.27.mov

Testing the changes

yarn test:jest src/plugins/dashboard/public/application/utils/get_no_items_message.test.tsx

Changelog

fix: Redirect sample data link to the page in the same workspace

Check List

All tests pass
- yarn test:jest
- yarn test:jest_integration
New functionality includes testing.
New functionality has been documented.
Update CHANGELOG.md
Commits are signed per the DCO using --signoff

Signed-off-by: Kapian1234 <[email protected]>

wanglam · 2024-09-26T03:36:37Z

src/plugins/dashboard/public/application/utils/get_no_items_message.tsx

@@ -60,11 +62,9 @@ export const getNoItemsMessage = (
                values={{
                  sampleDataInstallLink: (
                    <EuiLink
-                      onClick={() =>
-                        application.navigateToApp('home', {


What about call application.navigationToApp('import_sample_data') directly? Then we won't need so much modifications.

Oh I didn't know that. It's a much better way to do that, thanks!

Signed-off-by: Kapian1234 <[email protected]>

…nSearch-Dashboards into sample_data_link_redirect

Signed-off-by: Kapian1234 <[email protected]>

wanglam · 2024-09-26T05:36:41Z

src/plugins/dashboard/public/application/utils/get_no_items_message.test.tsx

 import { Observable } from 'rxjs';
+import { RecursiveReadonly } from '@osd/utility-types';
+import { EuiLink } from '@elastic/eui';


Nit: Seems these import changes are not necessary, prefer to keep the original code.

Signed-off-by: Kapian1234 <[email protected]>

SuZhou-Joe · 2024-09-29T06:49:52Z

@Kapian1234 Can we post a record on 2 scenarios:

Workspace enabled and click the sample data link inside workspace
Workspace disabled and click the sample data link outside workspace.

codecov · 2024-09-29T06:52:43Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.92%. Comparing base (9fd0f0b) to head (131f45d).
Report is 179 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #8330      +/-   ##
==========================================
- Coverage   64.14%   60.92%   -3.22%     
==========================================
  Files        3743     3750       +7     
  Lines       88836    89055     +219     
  Branches    13852    13910      +58     
==========================================
- Hits        56981    54260    -2721     
- Misses      31240    31432     +192     
- Partials      615     3363    +2748

Flag	Coverage Δ
Linux_1	`28.86% <0.00%> (-1.21%)`	⬇️
Linux_2	`56.35% <ø> (-2.51%)`	⬇️
Linux_3	`37.75% <100.00%> (-2.61%)`	⬇️
Linux_4	`29.96% <0.00%> (-1.63%)`	⬇️
Windows_1	`28.87% <0.00%> (-1.21%)`	⬇️
Windows_2	`56.30% <ø> (-2.51%)`	⬇️
Windows_3	`37.76% <100.00%> (-2.61%)`	⬇️
Windows_4	`29.96% <0.00%> (-1.63%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Kapian1234 · 2024-09-29T09:22:59Z

@Kapian1234 Can we post a record on 2 scenarios:

Workspace enabled and click the sample data link inside workspace

Workspace disabled and click the sample data link outside workspace.

ok

ruanyl · 2024-09-29T09:40:26Z

@Kapian1234 snapshot test failed, please take a look.

Kapian1234 · 2024-09-29T09:42:38Z

@Kapian1234 snapshot test failed, please take a look.

ok

Kapian1234 · 2024-09-29T09:54:42Z

@Kapian1234 snapshot test failed, please take a look.

But it runs successfully on my local

ruanyl · 2024-09-29T10:14:58Z

@Kapian1234 snapshot test failed, please take a look.

But it runs successfully on my local

Running this failed on my local

yarn test:jest src/plugins/dashboard/public/application/utils/get_no_items_message.test.tsx

Signed-off-by: Kapian1234 <[email protected]>

…pace (#8330) * Redirect Sample data link to the page in the same workspace Signed-off-by: Kapian1234 <[email protected]> * Changeset file for PR #8330 created/updated * Optimize the code Signed-off-by: Kapian1234 <[email protected]> * Update unit test Signed-off-by: Kapian1234 <[email protected]> * Update unit test Signed-off-by: Kapian1234 <[email protected]> * Update unit test Signed-off-by: Kapian1234 <[email protected]> * update snapshot Signed-off-by: Kapian1234 <[email protected]> --------- Signed-off-by: Kapian1234 <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> (cherry picked from commit 81cab73) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

…pace (#8330) (#8385) * Redirect Sample data link to the page in the same workspace * Changeset file for PR #8330 created/updated * Optimize the code * Update unit test * Update unit test * Update unit test * update snapshot --------- (cherry picked from commit 81cab73) Signed-off-by: Kapian1234 <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>

…pace (opensearch-project#8330) (opensearch-project#8385) * Redirect Sample data link to the page in the same workspace * Changeset file for PR opensearch-project#8330 created/updated * Optimize the code * Update unit test * Update unit test * Update unit test * update snapshot --------- (cherry picked from commit 81cab73) Signed-off-by: Kapian1234 <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>

Redirect Sample data link to the page in the same workspace

e9d1385

Signed-off-by: Kapian1234 <[email protected]>

github-actions bot added the valued-contributor label Sep 25, 2024

Changeset file for PR opensearch-project#8330 created/updated

47c4df8

Kapian1234 marked this pull request as ready for review September 25, 2024 09:18

wanglam reviewed Sep 26, 2024

View reviewed changes

Optimize the code

3d67253

Signed-off-by: Kapian1234 <[email protected]>

Kapian1234 added 3 commits September 26, 2024 13:31

Merge branch 'sample_data_link_redirect' of github.com:Kapian1234/Ope…

f023df4

…nSearch-Dashboards into sample_data_link_redirect

Update unit test

a7a621c

Signed-off-by: Kapian1234 <[email protected]>

Update unit test

73dbb5b

Signed-off-by: Kapian1234 <[email protected]>

wanglam reviewed Sep 26, 2024

View reviewed changes

Update unit test

4dfb244

Signed-off-by: Kapian1234 <[email protected]>

ruanyl added backport 2.x workspace labels Sep 29, 2024

ruanyl previously approved these changes Sep 29, 2024

View reviewed changes

update snapshot

131f45d

Signed-off-by: Kapian1234 <[email protected]>

Kapian1234 dismissed ruanyl’s stale review via 131f45d September 30, 2024 02:29

ruanyl approved these changes Sep 30, 2024

View reviewed changes

SuZhou-Joe approved these changes Sep 30, 2024

View reviewed changes

SuZhou-Joe merged commit 81cab73 into opensearch-project:main Sep 30, 2024
66 of 68 checks passed

opensearch-trigger-bot bot mentioned this pull request Sep 30, 2024

[Backport 2.x] [Workspace] Redirect "Sample data" link to the page in the same workspace #8385

Merged

ananzh added the v2.18.0 label Oct 30, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Workspace] Redirect "Sample data" link to the page in the same workspace #8330

[Workspace] Redirect "Sample data" link to the page in the same workspace #8330

Kapian1234 commented Sep 25, 2024 •

edited by SuZhou-Joe

Loading

wanglam Sep 26, 2024

Kapian1234 Sep 26, 2024

wanglam Sep 26, 2024

SuZhou-Joe commented Sep 29, 2024

codecov bot commented Sep 29, 2024 •

edited

Loading

Kapian1234 commented Sep 29, 2024 •

edited

Loading

ruanyl commented Sep 29, 2024

Kapian1234 commented Sep 29, 2024

Kapian1234 commented Sep 29, 2024

ruanyl commented Sep 29, 2024

[Workspace] Redirect "Sample data" link to the page in the same workspace #8330

[Workspace] Redirect "Sample data" link to the page in the same workspace #8330

Conversation

Kapian1234 commented Sep 25, 2024 • edited by SuZhou-Joe Loading

Description

Issues Resolved

Screenshot

Testing the changes

Changelog

Check List

wanglam Sep 26, 2024

Choose a reason for hiding this comment

Kapian1234 Sep 26, 2024

Choose a reason for hiding this comment

wanglam Sep 26, 2024

Choose a reason for hiding this comment

SuZhou-Joe commented Sep 29, 2024

codecov bot commented Sep 29, 2024 • edited Loading

Codecov Report

Kapian1234 commented Sep 29, 2024 • edited Loading

ruanyl commented Sep 29, 2024

Kapian1234 commented Sep 29, 2024

Kapian1234 commented Sep 29, 2024

ruanyl commented Sep 29, 2024

Kapian1234 commented Sep 25, 2024 •

edited by SuZhou-Joe

Loading

codecov bot commented Sep 29, 2024 •

edited

Loading

Kapian1234 commented Sep 29, 2024 •

edited

Loading