Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] [workspace] Fix config related issues and dedup the category in landing page #8162

Merged
merged 1 commit into from
Sep 12, 2024

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 07c7fa1 from #8160.

…ng page (#8160)

* fix: do not automatically append workspaces params when creating config

Signed-off-by: SuZhou-Joe <[email protected]>

* fix: find global configs when upgrade config

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: dedup category in landing page

Signed-off-by: SuZhou-Joe <[email protected]>

* Changeset file for PR #8160 created/updated

---------

Signed-off-by: SuZhou-Joe <[email protected]>
Co-authored-by: SuZhou-Joe <[email protected]>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
(cherry picked from commit 07c7fa1)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Copy link
Contributor

❌ Invalid Changelog Heading

The '## Changelog' heading in your PR description is either missing or malformed. Please make sure that your PR description includes a '## Changelog' heading with proper spelling, capitalization, spacing, and Markdown syntax.

Copy link

codecov bot commented Sep 12, 2024

Codecov Report

Attention: Patch coverage is 81.81818% with 2 lines in your changes missing coverage. Please review.

Project coverage is 63.92%. Comparing base (a8fca1c) to head (e9275bc).
Report is 2 commits behind head on 2.x.

Files with missing lines Patch % Lines
...ver/saved_objects/workspace_id_consumer_wrapper.ts 50.00% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##              2.x    #8162   +/-   ##
=======================================
  Coverage   63.92%   63.92%           
=======================================
  Files        3737     3737           
  Lines       88717    88726    +9     
  Branches    13792    13795    +3     
=======================================
+ Hits        56713    56721    +8     
+ Misses      31408    31407    -1     
- Partials      596      598    +2     
Flag Coverage Δ
Linux_1 29.96% <80.00%> (+<0.01%) ⬆️
Linux_2 58.91% <ø> (ø)
Linux_3 40.29% <ø> (+<0.01%) ⬆️
Linux_4 31.33% <100.00%> (ø)
Windows_1 29.98% <80.00%> (+<0.01%) ⬆️
Windows_2 58.86% <ø> (ø)
Windows_3 40.29% <ø> (ø)
Windows_4 31.33% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ruanyl ruanyl merged commit 5d395a8 into 2.x Sep 12, 2024
68 of 70 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
all-star-contributor autocut Skip the changelog verification check on backports failed changeset v2.17.0 workspace
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants