-
Notifications
You must be signed in to change notification settings - Fork 916
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[workspace] Fix config related issues and dedup the category in landing page #8160
[workspace] Fix config related issues and dedup the category in landing page #8160
Conversation
Signed-off-by: SuZhou-Joe <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8160 +/- ##
=======================================
Coverage 63.89% 63.90%
=======================================
Files 3739 3739
Lines 88752 88762 +10
Branches 13810 13814 +4
=======================================
+ Hits 56712 56720 +8
Misses 31444 31444
- Partials 596 598 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: SuZhou-Joe <[email protected]>
Signed-off-by: SuZhou-Joe <[email protected]>
❌ Entry Too LongEntry is 113 characters long, which is 13 characters longer than the maximum allowed length of 100 characters. Please revise your entry to be within the maximum length. |
❌ Entry Too LongEntry is 113 characters long, which is 13 characters longer than the maximum allowed length of 100 characters. Please revise your entry to be within the maximum length. |
2 similar comments
❌ Entry Too LongEntry is 113 characters long, which is 13 characters longer than the maximum allowed length of 100 characters. Please revise your entry to be within the maximum length. |
❌ Entry Too LongEntry is 113 characters long, which is 13 characters longer than the maximum allowed length of 100 characters. Please revise your entry to be within the maximum length. |
❌ Entry Too LongEntry is 113 characters long, which is 13 characters longer than the maximum allowed length of 100 characters. Please revise your entry to be within the maximum length. |
…ng page (#8160) * fix: do not automatically append workspaces params when creating config Signed-off-by: SuZhou-Joe <[email protected]> * fix: find global configs when upgrade config Signed-off-by: SuZhou-Joe <[email protected]> * feat: dedup category in landing page Signed-off-by: SuZhou-Joe <[email protected]> * Changeset file for PR #8160 created/updated --------- Signed-off-by: SuZhou-Joe <[email protected]> Co-authored-by: SuZhou-Joe <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> (cherry picked from commit 07c7fa1) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…ng page (#8160) * fix: do not automatically append workspaces params when creating config Signed-off-by: SuZhou-Joe <[email protected]> * fix: find global configs when upgrade config Signed-off-by: SuZhou-Joe <[email protected]> * feat: dedup category in landing page Signed-off-by: SuZhou-Joe <[email protected]> * Changeset file for PR #8160 created/updated --------- Signed-off-by: SuZhou-Joe <[email protected]> Co-authored-by: SuZhou-Joe <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> (cherry picked from commit 07c7fa1) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…ng page (#8160) (#8162) * fix: do not automatically append workspaces params when creating config * fix: find global configs when upgrade config * feat: dedup category in landing page * Changeset file for PR #8160 created/updated --------- (cherry picked from commit 07c7fa1) Signed-off-by: SuZhou-Joe <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: SuZhou-Joe <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
…ng page (#8160) (#8163) * fix: do not automatically append workspaces params when creating config * fix: find global configs when upgrade config * feat: dedup category in landing page * Changeset file for PR #8160 created/updated --------- (cherry picked from commit 07c7fa1) Signed-off-by: SuZhou-Joe <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: SuZhou-Joe <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Description
This PR is to fix:
Issues Resolved
Screenshot
Do not automatically append workspaces when creating config saved objects. - Before fix
20240912172011048.mp4
Do not automatically append workspaces when creating config saved objects. - After fix
20240912172203710.mp4
Find global configs when upgrading advanced settings config.
20240912171413721.mp4
Dedup category in landing page
Testing the changes
Changelog
Check List
yarn test:jest
yarn test:jest_integration