[Workspace][Navigation] fix: hide workspace detail title in old nav #8151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: tygao <[email protected]>
raintygao
requested review from
ananzh,
kavilla,
AMoo-Miki,
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub,
curq,
bandinib-amzn,
SuZhou-Joe,
ruanyl,
BionIT,
xinruiba,
zhyuanqi,
mengweieric,
LDrago27,
virajsanghvi,
sejli,
joshuali925 and
huyaboo
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8151 +/- ##
==========================================
- Coverage 63.89% 63.89% -0.01%
==========================================
Files 3739 3739
Lines 88752 88753 +1
Branches 13810 13811 +1
==========================================
- Hits 56712 56710 -2
- Misses 31444 31447 +3
Partials 596 596
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
raintygao
changed the title
SuZhou-Joe
previously approved these changes
Sep 12, 2024
SuZhou-Joe
changed the title
opensearch-changeset-bot
bot
dismissed
SuZhou-Joe’s stale review
via
0d3ec38
SuZhou-Joe
approved these changes
Sep 12, 2024
ruanyl
approved these changes
Sep 12, 2024
ruanyl
changed the title
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Sep 12, 2024
…8151) * hide workspace detail in new nav Signed-off-by: tygao <[email protected]> * Changeset file for PR #8151 created/updated * Changeset file for PR #8151 created/updated --------- Signed-off-by: tygao <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> (cherry picked from commit 8f8ecfd) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
AMoo-Miki
pushed a commit
that referenced
this pull request
Sep 27, 2024
…8151) (#8155) * hide workspace detail in new nav * Changeset file for PR #8151 created/updated * Changeset file for PR #8151 created/updated --------- (cherry picked from commit 8f8ecfd) Signed-off-by: tygao <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
SuZhou-Joe
pushed a commit
to SuZhou-Joe/OpenSearch-Dashboards
that referenced
this pull request
Oct 3, 2024
…pensearch-project#8151) (opensearch-project#8155) * hide workspace detail in new nav * Changeset file for PR opensearch-project#8151 created/updated * Changeset file for PR opensearch-project#8151 created/updated --------- (cherry picked from commit 8f8ecfd) Signed-off-by: tygao <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove workspace detail title in navigation when new nav is disabled
Screenshot
Before
After
Testing the changes
Enable/disable new navigation and workspace to see the change.
Changelog
Check List
yarn test:jestyarn test:jest_integration