Skip to content

Commit

Permalink
[Workspace][Navigation] fix: hide workspace detail title in old nav (o…
Browse files Browse the repository at this point in the history
…pensearch-project#8151) (opensearch-project#8155)

* hide workspace detail in new nav



* Changeset file for PR opensearch-project#8151 created/updated

* Changeset file for PR opensearch-project#8151 created/updated

---------



(cherry picked from commit 8f8ecfd)

Signed-off-by: tygao <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
  • Loading branch information
3 people authored and SuZhou-Joe committed Oct 3, 2024
1 parent fe7c390 commit f5e042f
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 0 deletions.
2 changes: 2 additions & 0 deletions changelogs/fragments/8151.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
fix:
- Remove workspace detail title in navigation when new nav is disabled ([#8151](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/8151))
3 changes: 3 additions & 0 deletions src/plugins/workspace/public/plugin.ts
Original file line number Diff line number Diff line change
Expand Up @@ -373,6 +373,9 @@ export class WorkspacePlugin
title: i18n.translate('workspace.settings.workspaceDetail', {
defaultMessage: 'Workspace Detail',
}),
navLinkStatus: core.chrome.navGroup.getNavGroupEnabled()
? AppNavLinkStatus.visible
: AppNavLinkStatus.hidden,
async mount(params: AppMountParameters) {
const { renderDetailApp } = await import('./application');
return mountWorkspaceApp(params, renderDetailApp);
Expand Down

0 comments on commit f5e042f

Please sign in to comment.