[Look&Feel] Apply small popover padding and add Oui tooltip #7523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
❌ Invalid PrefixInvalid description prefix. Found "[Look&Feel] Use small popover padding across the board". Expected "breaking", "deprecate", "feat", "fix", "infra", "doc", "chore", "refactor", "security", "skip", or "test". |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7523 +/- ##
=======================================
Coverage 63.63% 63.63%
=======================================
Files 3630 3630
Lines 79549 79549
Branches 12613 12613
=======================================
Hits 50621 50621
Misses 25857 25857
Partials 3071 3071
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
danieldong51
force-pushed
the
popover-remaining
branch
from
b705180 to
9ce11a3
Compare
danieldong51
changed the title
❌ Invalid PrefixInvalid description prefix. Found "[Look&Feel] Use small popover padding across the board". Expected "breaking", "deprecate", "feat", "fix", "infra", "doc", "chore", "refactor", "security", "skip", or "test". |
opensearch-changeset-bot bot
added a commit
to danieldong51/OpenSearch-Dashboards
that referenced
this pull request
Jul 29, 2024
danieldong51
changed the title
opensearch-changeset-bot bot
added a commit
to danieldong51/OpenSearch-Dashboards
that referenced
this pull request
Jul 29, 2024
opensearch-changeset-bot bot
added a commit
to danieldong51/OpenSearch-Dashboards
that referenced
this pull request
Jul 29, 2024
danieldong51
force-pushed
the
popover-remaining
branch
from
ee87b93 to
b328609
Compare
danieldong51
pushed a commit
to danieldong51/OpenSearch-Dashboards
that referenced
this pull request
Jul 29, 2024
danieldong51
pushed a commit
to danieldong51/OpenSearch-Dashboards
that referenced
this pull request
Jul 29, 2024
danieldong51
pushed a commit
to danieldong51/OpenSearch-Dashboards
that referenced
this pull request
Jul 29, 2024
danieldong51
requested review from
ananzh,
kavilla,
AMoo-Miki,
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub and
curq
as code owners
danieldong51
requested review from
BionIT,
xinruiba,
zhyuanqi,
mengweieric,
LDrago27,
virajsanghvi,
sejli and
joshuali925
as code owners
Signed-off-by: Dan Dong <[email protected]>
Signed-off-by: Dan Dong <[email protected]>
Signed-off-by: Dan Dong <[email protected]>
Signed-off-by: Dan Dong <[email protected]>
Signed-off-by: Dan Dong <[email protected]>
Signed-off-by: Dan Dong <[email protected]>
danieldong51
force-pushed
the
popover-remaining
branch
from
ca1de88 to
4ec5f8b
Compare
zhongnansu
approved these changes
Jul 30, 2024
virajsanghvi
approved these changes
Jul 30, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jul 30, 2024
* Updated Table padding size * Added tooltips to index patterns -> source filters * Updated recent items popover padding * Updated vis augmenter popover padding --------- Signed-off-by: Dan Dong <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> (cherry picked from commit 33ef32d) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
LDrago27
pushed a commit
that referenced
this pull request
Jul 30, 2024
…7580) * Updated Table padding size * Added tooltips to index patterns -> source filters * Updated recent items popover padding * Updated vis augmenter popover padding --------- (cherry picked from commit 33ef32d) Signed-off-by: Dan Dong <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Qxisylolo
pushed a commit
to Qxisylolo/OpenSearch-Dashboards
that referenced
this pull request
Aug 1, 2024
…ch-project#7523) * Updated Table padding size * Added tooltips to index patterns -> source filters * Updated recent items popover padding * Updated vis augmenter popover padding --------- Signed-off-by: Dan Dong <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Applies small padding on popovers for index management page. Also adds OUI tooltip to icons to Index Pattern Source Filters table to match other tables under index management.
Screenshot
Small padding on popovers
Added the
smallPopoverPadding = sattribute to the following popovers:Tooltip Additions
Added EuiTooltips to edit and delete icons in the index patterns source filters listing to match other tables:
Other tables for reference, which have tooltips for edit and delete icons:
Changelog
Check List
yarn test:jestyarn test:jest_integration