Skip to content

Commit

Permalink
[Look&Feel] Apply small popover padding and add Oui tooltip (#7523)
Browse files Browse the repository at this point in the history
* Updated Table padding size
* Added tooltips to index patterns -> source filters
* Updated recent items popover padding
* Updated vis augmenter popover padding

---------

Signed-off-by: Dan Dong <[email protected]>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
(cherry picked from commit 33ef32d)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
  • Loading branch information
1 parent 2411e2f commit dfc3e8c
Show file tree
Hide file tree
Showing 7 changed files with 51 additions and 29 deletions.
2 changes: 2 additions & 0 deletions changelogs/fragments/7523.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
refactor:
- [Look&Feel] Apply small popover padding and add Oui tooltips ([#7523](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/7523))
1 change: 1 addition & 0 deletions src/core/public/chrome/ui/header/recent_items.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,7 @@ export const RecentItems = ({
anchorPosition="downCenter"
repositionOnScroll
initialFocus={false}
panelPaddingSize="s"
>
<EuiTitle size="xxs">
<h4>Recents</h4>
Expand Down

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@ import {
EuiCompressedFieldText,
EuiButtonIcon,
RIGHT_ALIGNMENT,
EuiToolTip,
} from '@elastic/eui';

import { i18n } from '@osd/i18n';
Expand Down Expand Up @@ -224,19 +225,23 @@ export class Table extends Component<TableProps, TableState> {

return (
<>
<EuiButtonIcon
size="s"
onClick={() => this.startEditingFilter(filter.clientId, filter.value)}
iconType="pencil"
aria-label={editAria}
/>
<EuiButtonIcon
size="s"
color="danger"
onClick={() => deleteFilter(filter)}
iconType="trash"
aria-label={deleteAria}
/>
<EuiToolTip content={editAria} delay="long" position="top">
<EuiButtonIcon
size="s"
onClick={() => this.startEditingFilter(filter.clientId, filter.value)}
iconType="pencil"
aria-label={editAria}
/>
</EuiToolTip>
<EuiToolTip content={deleteAria} delay="long" position="top">
<EuiButtonIcon
size="s"
color="danger"
onClick={() => deleteFilter(filter)}
iconType="trash"
aria-label={deleteAria}
/>
</EuiToolTip>
</>
);
},
Expand Down

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Original file line number Diff line number Diff line change
Expand Up @@ -443,6 +443,7 @@ export class Table extends PureComponent<TableProps, TableState> {
button={button}
isOpen={this.state.isExportPopoverOpen}
closePopover={this.closeExportPopover}
panelPaddingSize="s"
>
<EuiCompressedFormRow
label={
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,7 @@ export function EventVisItemIcon(props: Props) {
button={dangerButton}
isOpen={isErrorPopoverOpen}
closePopover={closeErrorPopover}
panelPaddingSize="s"
>
<div>{errorMsg}</div>
</EuiPopover>
Expand Down

0 comments on commit dfc3e8c

Please sign in to comment.