[Bug][Data Source] Move data source manageable feature flag to DSM plugin #7440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: yubonluo <[email protected]>
…oards into 2.16-bug-create-flint-datasource
yubonluo
requested review from
ananzh,
kavilla,
AMoo-Miki,
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub,
curq,
bandinib-amzn,
SuZhou-Joe,
ruanyl,
BionIT,
xinruiba,
zhyuanqi,
mengweieric,
LDrago27 and
virajsanghvi
as code owners
SuZhou-Joe
approved these changes
Jul 24, 2024
ruanyl
approved these changes
Jul 24, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7440 +/- ##
=======================================
Coverage 64.13% 64.13%
=======================================
Files 3614 3614
Lines 78690 78690
Branches 12436 12436
=======================================
Hits 50467 50467
Misses 25172 25172
Partials 3051 3051
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jul 24, 2024
…ugin (#7440) * Move data source manageable feature flag to DSM plugin Signed-off-by: yubonluo <[email protected]> * Changeset file for PR #7440 created/updated --------- Signed-off-by: yubonluo <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> (cherry picked from commit dfcd2e1) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jul 24, 2024
…ugin (#7440) * Move data source manageable feature flag to DSM plugin Signed-off-by: yubonluo <[email protected]> * Changeset file for PR #7440 created/updated --------- Signed-off-by: yubonluo <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> (cherry picked from commit dfcd2e1) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
LDrago27
pushed a commit
to LDrago27/OpenSearch-Dashboards
that referenced
this pull request
Jul 25, 2024
…ugin (opensearch-project#7440) * Move data source manageable feature flag to DSM plugin Signed-off-by: yubonluo <[email protected]> * Changeset file for PR opensearch-project#7440 created/updated --------- Signed-off-by: yubonluo <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> (cherry picked from commit dfcd2e1)
ruanyl
pushed a commit
that referenced
this pull request
Jul 25, 2024
…ugin (#7440) (#7445) * Move data source manageable feature flag to DSM plugin * Changeset file for PR #7440 created/updated --------- (cherry picked from commit dfcd2e1) Signed-off-by: yubonluo <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
LDrago27
added a commit
that referenced
this pull request
Jul 25, 2024
* Bump OUI to 1.8.0 (#7363) Signed-off-by: Miki <[email protected]> (cherry picked from commit c1bae75) * [Auto Suggest] OpenSearch SQL autosuggest with ANTLR (#7336) * cherry pick Signed-off-by: Eric <[email protected]> * SQL keyword suggestion Signed-off-by: Eric <[email protected]> * column and values suggestions Signed-off-by: Eric <[email protected]> * adjust values suggestions and ignored token Signed-off-by: Eric <[email protected]> * suggestion type casting Signed-off-by: Eric <[email protected]> * ignore functions Signed-off-by: Eric <[email protected]> * case insensitive Signed-off-by: Eric <[email protected]> * change to use grammar for insensitive case Signed-off-by: Eric <[email protected]> * fix multi-line issue Signed-off-by: Eric <[email protected]> * code cleanup Signed-off-by: Eric <[email protected]> * move ppl out of scope Signed-off-by: Eric <[email protected]> * rename folder and add ignoring rules Signed-off-by: Eric <[email protected]> * resolve type issue Signed-off-by: Eric <[email protected]> * fix ppl suggestion provider issue Signed-off-by: Eric <[email protected]> * remove function suggestion Signed-off-by: Eric <[email protected]> * some code clean up and adding tests Signed-off-by: Eric <[email protected]> * cursor tests Signed-off-by: Eric <[email protected]> * remove testing setup Signed-off-by: Eric <[email protected]> * add changelog Signed-off-by: Eric <[email protected]> * update yarn file Signed-off-by: Eric <[email protected]> * add missing testing library Signed-off-by: Eric <[email protected]> * MDS integration Signed-off-by: Eric <[email protected]> * minor interface change and disable word based suggestion Signed-off-by: Eric <[email protected]> * update ID_LITERAL and recompile grammar Signed-off-by: Eric <[email protected]> * column suggest for agg function Signed-off-by: Eric <[email protected]> * revert version Signed-off-by: Eric <[email protected]> * opensearch sql syntax highlighting Signed-off-by: Eric <[email protected]> * add utility tests Signed-off-by: Eric <[email protected]> * symbol table test Signed-off-by: Eric <[email protected]> * error listener test Signed-off-by: Eric <[email protected]> * parse test Signed-off-by: Eric <[email protected]> * add suggestion provider to single line query editor Signed-off-by: Eric <[email protected]> * remove one test Signed-off-by: Eric <[email protected]> * add connection service type Signed-off-by: Eric <[email protected]> --------- Signed-off-by: Eric <[email protected]> (cherry picked from commit 9348bd4) * Move TopNavLinks to new Nav Bar Discover (#7326) This PR aims to introduce a new Nav bar in Discover that would contain the Date Picker as well as the Navigation links that are currently part of headers. The Navigation Links have been replaced with the corresponding Icons to provide a modern UX. These setting are currently controlled by query:enhancements:enabled Advanced Setting Flag and would be visible when the above flag is turned on. Signed-off-by: Suchit Sahoo <[email protected]> (cherry picked from commit e46e54a) * [navigation-next]fix: breadcrumb issue found in data source management and other similar cases. (#7401) * feat: add scoped breadcrumbs Signed-off-by: SuZhou-Joe <[email protected]> * Changeset file for PR #7401 created/updated * feat: move data source management register logic up a little bit Signed-off-by: SuZhou-Joe <[email protected]> * feat: add unit test Signed-off-by: SuZhou-Joe <[email protected]> * feat: revert the home related change Signed-off-by: SuZhou-Joe <[email protected]> * fix: overview error in all use case when workspace is enabled Signed-off-by: SuZhou-Joe <[email protected]> * fix: update snapshot Signed-off-by: SuZhou-Joe <[email protected]> * Changeset file for PR #7401 created/updated * fix: hide nav groups that should be displayed Signed-off-by: SuZhou-Joe <[email protected]> * feat: hide expand icon in left navigation Signed-off-by: SuZhou-Joe <[email protected]> * feat: update Signed-off-by: SuZhou-Joe <[email protected]> --------- Signed-off-by: SuZhou-Joe <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Co-authored-by: ZilongX <[email protected]> (cherry picked from commit 3f78c94) * [Bug][Data Source] Move data source manageable feature flag to DSM plugin (#7440) * Move data source manageable feature flag to DSM plugin Signed-off-by: yubonluo <[email protected]> * Changeset file for PR #7440 created/updated --------- Signed-off-by: yubonluo <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> (cherry picked from commit dfcd2e1) * [Discover-next] data set picker (#7426) * update using query manager Signed-off-by: Kawika Avilla <[email protected]> * aggs not working Signed-off-by: Kawika Avilla <[email protected]> * almost there Signed-off-by: Kawika Avilla <[email protected]> * stablish Signed-off-by: Kawika Avilla <[email protected]> * thanks ashwin Signed-off-by: Kawika Avilla <[email protected]> * update ref name Signed-off-by: Kawika Avilla <[email protected]> * fix timefields Signed-off-by: Kawika Avilla <[email protected]> * clean up some console logs Signed-off-by: Kawika Avilla <[email protected]> * go safer route of setting language Signed-off-by: Kawika Avilla <[email protected]> * its working again Signed-off-by: Kawika Avilla <[email protected]> * fix names Signed-off-by: Kawika Avilla <[email protected]> * restore code editor and indices Signed-off-by: Kawika Avilla <[email protected]> * sql df Signed-off-by: Kawika Avilla <[email protected]> * fix external datasources again Signed-off-by: Kawika Avilla <[email protected]> --------- Signed-off-by: Kawika Avilla <[email protected]> (cherry picked from commit 6a079d3) * Fix add filter for numeric scripted field (#7022) * Fix add filter for scripted field Signed-off-by: abbyhu2000 <[email protected]> * add unit test Signed-off-by: abbyhu2000 <[email protected]> * change from nested ternary to if else Signed-off-by: abbyhu2000 <[email protected]> * add more unit tests Signed-off-by: abbyhu2000 <[email protected]> * change unit tests Signed-off-by: abbyhu2000 <[email protected]> * fix typo Signed-off-by: abbyhu2000 <[email protected]> --------- Signed-off-by: abbyhu2000 <[email protected]> (cherry picked from commit 7c1f8fc) * [Bug][Workspace] Add permission validation at workspace detail page (#7435) * [Bug][Workspace] Add permission validate at workspace detail page Signed-off-by: yubonluo <[email protected]> * Changeset file for PR #7435 created/updated --------- Signed-off-by: yubonluo <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> (cherry picked from commit 45d34b5) * Revert "[Discover-next] data set picker (#7426)" (#7479) This reverts commit 6a079d3. --------- Co-authored-by: Miki <[email protected]> Co-authored-by: Eric Wei <[email protected]> Co-authored-by: SuZhou-Joe <[email protected]> Co-authored-by: yuboluo <[email protected]> Co-authored-by: Kawika Avilla <[email protected]> Co-authored-by: Qingyang(Abby) Hu <[email protected]> Co-authored-by: Sean Li <[email protected]>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jul 25, 2024
* Bump OUI to 1.8.0 (#7363) Signed-off-by: Miki <[email protected]> (cherry picked from commit c1bae75) * [Auto Suggest] OpenSearch SQL autosuggest with ANTLR (#7336) * cherry pick Signed-off-by: Eric <[email protected]> * SQL keyword suggestion Signed-off-by: Eric <[email protected]> * column and values suggestions Signed-off-by: Eric <[email protected]> * adjust values suggestions and ignored token Signed-off-by: Eric <[email protected]> * suggestion type casting Signed-off-by: Eric <[email protected]> * ignore functions Signed-off-by: Eric <[email protected]> * case insensitive Signed-off-by: Eric <[email protected]> * change to use grammar for insensitive case Signed-off-by: Eric <[email protected]> * fix multi-line issue Signed-off-by: Eric <[email protected]> * code cleanup Signed-off-by: Eric <[email protected]> * move ppl out of scope Signed-off-by: Eric <[email protected]> * rename folder and add ignoring rules Signed-off-by: Eric <[email protected]> * resolve type issue Signed-off-by: Eric <[email protected]> * fix ppl suggestion provider issue Signed-off-by: Eric <[email protected]> * remove function suggestion Signed-off-by: Eric <[email protected]> * some code clean up and adding tests Signed-off-by: Eric <[email protected]> * cursor tests Signed-off-by: Eric <[email protected]> * remove testing setup Signed-off-by: Eric <[email protected]> * add changelog Signed-off-by: Eric <[email protected]> * update yarn file Signed-off-by: Eric <[email protected]> * add missing testing library Signed-off-by: Eric <[email protected]> * MDS integration Signed-off-by: Eric <[email protected]> * minor interface change and disable word based suggestion Signed-off-by: Eric <[email protected]> * update ID_LITERAL and recompile grammar Signed-off-by: Eric <[email protected]> * column suggest for agg function Signed-off-by: Eric <[email protected]> * revert version Signed-off-by: Eric <[email protected]> * opensearch sql syntax highlighting Signed-off-by: Eric <[email protected]> * add utility tests Signed-off-by: Eric <[email protected]> * symbol table test Signed-off-by: Eric <[email protected]> * error listener test Signed-off-by: Eric <[email protected]> * parse test Signed-off-by: Eric <[email protected]> * add suggestion provider to single line query editor Signed-off-by: Eric <[email protected]> * remove one test Signed-off-by: Eric <[email protected]> * add connection service type Signed-off-by: Eric <[email protected]> --------- Signed-off-by: Eric <[email protected]> (cherry picked from commit 9348bd4) * Move TopNavLinks to new Nav Bar Discover (#7326) This PR aims to introduce a new Nav bar in Discover that would contain the Date Picker as well as the Navigation links that are currently part of headers. The Navigation Links have been replaced with the corresponding Icons to provide a modern UX. These setting are currently controlled by query:enhancements:enabled Advanced Setting Flag and would be visible when the above flag is turned on. Signed-off-by: Suchit Sahoo <[email protected]> (cherry picked from commit e46e54a) * [navigation-next]fix: breadcrumb issue found in data source management and other similar cases. (#7401) * feat: add scoped breadcrumbs Signed-off-by: SuZhou-Joe <[email protected]> * Changeset file for PR #7401 created/updated * feat: move data source management register logic up a little bit Signed-off-by: SuZhou-Joe <[email protected]> * feat: add unit test Signed-off-by: SuZhou-Joe <[email protected]> * feat: revert the home related change Signed-off-by: SuZhou-Joe <[email protected]> * fix: overview error in all use case when workspace is enabled Signed-off-by: SuZhou-Joe <[email protected]> * fix: update snapshot Signed-off-by: SuZhou-Joe <[email protected]> * Changeset file for PR #7401 created/updated * fix: hide nav groups that should be displayed Signed-off-by: SuZhou-Joe <[email protected]> * feat: hide expand icon in left navigation Signed-off-by: SuZhou-Joe <[email protected]> * feat: update Signed-off-by: SuZhou-Joe <[email protected]> --------- Signed-off-by: SuZhou-Joe <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Co-authored-by: ZilongX <[email protected]> (cherry picked from commit 3f78c94) * [Bug][Data Source] Move data source manageable feature flag to DSM plugin (#7440) * Move data source manageable feature flag to DSM plugin Signed-off-by: yubonluo <[email protected]> * Changeset file for PR #7440 created/updated --------- Signed-off-by: yubonluo <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> (cherry picked from commit dfcd2e1) * [Discover-next] data set picker (#7426) * update using query manager Signed-off-by: Kawika Avilla <[email protected]> * aggs not working Signed-off-by: Kawika Avilla <[email protected]> * almost there Signed-off-by: Kawika Avilla <[email protected]> * stablish Signed-off-by: Kawika Avilla <[email protected]> * thanks ashwin Signed-off-by: Kawika Avilla <[email protected]> * update ref name Signed-off-by: Kawika Avilla <[email protected]> * fix timefields Signed-off-by: Kawika Avilla <[email protected]> * clean up some console logs Signed-off-by: Kawika Avilla <[email protected]> * go safer route of setting language Signed-off-by: Kawika Avilla <[email protected]> * its working again Signed-off-by: Kawika Avilla <[email protected]> * fix names Signed-off-by: Kawika Avilla <[email protected]> * restore code editor and indices Signed-off-by: Kawika Avilla <[email protected]> * sql df Signed-off-by: Kawika Avilla <[email protected]> * fix external datasources again Signed-off-by: Kawika Avilla <[email protected]> --------- Signed-off-by: Kawika Avilla <[email protected]> (cherry picked from commit 6a079d3) * Fix add filter for numeric scripted field (#7022) * Fix add filter for scripted field Signed-off-by: abbyhu2000 <[email protected]> * add unit test Signed-off-by: abbyhu2000 <[email protected]> * change from nested ternary to if else Signed-off-by: abbyhu2000 <[email protected]> * add more unit tests Signed-off-by: abbyhu2000 <[email protected]> * change unit tests Signed-off-by: abbyhu2000 <[email protected]> * fix typo Signed-off-by: abbyhu2000 <[email protected]> --------- Signed-off-by: abbyhu2000 <[email protected]> (cherry picked from commit 7c1f8fc) * [Bug][Workspace] Add permission validation at workspace detail page (#7435) * [Bug][Workspace] Add permission validate at workspace detail page Signed-off-by: yubonluo <[email protected]> * Changeset file for PR #7435 created/updated --------- Signed-off-by: yubonluo <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> (cherry picked from commit 45d34b5) * Revert "[Discover-next] data set picker (#7426)" (#7479) This reverts commit 6a079d3. --------- Co-authored-by: Miki <[email protected]> Co-authored-by: Eric Wei <[email protected]> Co-authored-by: SuZhou-Joe <[email protected]> Co-authored-by: yuboluo <[email protected]> Co-authored-by: Kawika Avilla <[email protected]> Co-authored-by: Qingyang(Abby) Hu <[email protected]> Co-authored-by: Sean Li <[email protected]> (cherry picked from commit 0515fb2) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
LDrago27
pushed a commit
that referenced
this pull request
Jul 25, 2024
* Bump OUI to 1.8.0 (#7363) (cherry picked from commit c1bae75) * [Auto Suggest] OpenSearch SQL autosuggest with ANTLR (#7336) * cherry pick * SQL keyword suggestion * column and values suggestions * adjust values suggestions and ignored token * suggestion type casting * ignore functions * case insensitive * change to use grammar for insensitive case * fix multi-line issue * code cleanup * move ppl out of scope * rename folder and add ignoring rules * resolve type issue * fix ppl suggestion provider issue * remove function suggestion * some code clean up and adding tests * cursor tests * remove testing setup * add changelog * update yarn file * add missing testing library * MDS integration * minor interface change and disable word based suggestion * update ID_LITERAL and recompile grammar * column suggest for agg function * revert version * opensearch sql syntax highlighting * add utility tests * symbol table test * error listener test * parse test * add suggestion provider to single line query editor * remove one test * add connection service type --------- (cherry picked from commit 9348bd4) * Move TopNavLinks to new Nav Bar Discover (#7326) This PR aims to introduce a new Nav bar in Discover that would contain the Date Picker as well as the Navigation links that are currently part of headers. The Navigation Links have been replaced with the corresponding Icons to provide a modern UX. These setting are currently controlled by query:enhancements:enabled Advanced Setting Flag and would be visible when the above flag is turned on. (cherry picked from commit e46e54a) * [navigation-next]fix: breadcrumb issue found in data source management and other similar cases. (#7401) * feat: add scoped breadcrumbs * Changeset file for PR #7401 created/updated * feat: move data source management register logic up a little bit * feat: add unit test * feat: revert the home related change * fix: overview error in all use case when workspace is enabled * fix: update snapshot * Changeset file for PR #7401 created/updated * fix: hide nav groups that should be displayed * feat: hide expand icon in left navigation * feat: update --------- (cherry picked from commit 3f78c94) * [Bug][Data Source] Move data source manageable feature flag to DSM plugin (#7440) * Move data source manageable feature flag to DSM plugin * Changeset file for PR #7440 created/updated --------- (cherry picked from commit dfcd2e1) * [Discover-next] data set picker (#7426) * update using query manager * aggs not working * almost there * stablish * thanks ashwin * update ref name * fix timefields * clean up some console logs * go safer route of setting language * its working again * fix names * restore code editor and indices * sql df * fix external datasources again --------- (cherry picked from commit 6a079d3) * Fix add filter for numeric scripted field (#7022) * Fix add filter for scripted field * add unit test * change from nested ternary to if else * add more unit tests * change unit tests * fix typo --------- (cherry picked from commit 7c1f8fc) * [Bug][Workspace] Add permission validation at workspace detail page (#7435) * [Bug][Workspace] Add permission validate at workspace detail page * Changeset file for PR #7435 created/updated --------- (cherry picked from commit 45d34b5) * Revert "[Discover-next] data set picker (#7426)" (#7479) This reverts commit 6a079d3. --------- (cherry picked from commit 0515fb2) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Miki <[email protected]> Co-authored-by: Eric Wei <[email protected]> Co-authored-by: SuZhou-Joe <[email protected]> Co-authored-by: yuboluo <[email protected]> Co-authored-by: Kawika Avilla <[email protected]> Co-authored-by: Qingyang(Abby) Hu <[email protected]> Co-authored-by: Sean Li <[email protected]>
Qxisylolo
pushed a commit
to Qxisylolo/OpenSearch-Dashboards
that referenced
this pull request
Aug 1, 2024
…ugin (opensearch-project#7440) * Move data source manageable feature flag to DSM plugin Signed-off-by: yubonluo <[email protected]> * Changeset file for PR opensearch-project#7440 created/updated --------- Signed-off-by: yubonluo <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Move data source manageable feature flag to DSM plugin
Issues Resolved
Screenshot
Testing the changes
Changelog
Check List
yarn test:jestyarn test:jest_integration