Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move TopNavLinks to new Nav Bar Discover #7326

Merged
merged 2 commits into from
Jul 23, 2024

Conversation

LDrago27
Copy link
Collaborator

@LDrago27 LDrago27 commented Jul 19, 2024

Description

This PR aims to introduce a new Nav bar in Discover that would contain the Date Picker as well as the Navigation links that are currently part of headers. The Navigation Links have been replaced with the corresponding Icons to provide a modern UX. These setting are currently controlled by query:enhancements:enabled Advanced Setting Flag and would be visible when the above flag is turned on.

Issues Resolved

Screenshot

image

image

Testing the changes

  • Turn on the query:enhancements:enabled Setting in the Advanced Settings Section of Dashboards
  • Navigate to Discover Page
  • Check the updated UI

Changelog

  • feat: Add a New Nav Bar to Discover

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

opensearch-changeset-bot bot added a commit to LDrago27/OpenSearch-Dashboards that referenced this pull request Jul 19, 2024
@LDrago27 LDrago27 force-pushed the discoverNewNavBar branch from 3929995 to 33fc72f Compare July 19, 2024 22:34
Copy link

codecov bot commented Jul 19, 2024

Codecov Report

Attention: Patch coverage is 63.63636% with 4 lines in your changes missing coverage. Please review.

Project coverage is 63.97%. Comparing base (3587291) to head (70b830f).
Report is 4 commits behind head on main.

Files Patch % Lines
.../data_explorer/public/components/app_container.tsx 62.50% 1 Missing and 2 partials ⚠️
...public/ui/query_string_input/query_bar_top_row.tsx 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7326      +/-   ##
==========================================
- Coverage   67.62%   63.97%   -3.65%     
==========================================
  Files        3584     3598      +14     
  Lines       72198    78323    +6125     
  Branches    11815    12353     +538     
==========================================
+ Hits        48826    50110    +1284     
- Misses      20387    25190    +4803     
- Partials     2985     3023      +38     
Flag Coverage Δ
Linux_1 31.08% <100.00%> (-2.08%) ⬇️
Linux_2 55.58% <ø> (+0.05%) ⬆️
Linux_3 41.29% <63.63%> (-3.20%) ⬇️
Linux_4 31.52% <ø> (-2.54%) ⬇️
Windows_1 31.10% <100.00%> (-2.08%) ⬇️
Windows_2 55.53% <ø> (+0.05%) ⬆️
Windows_3 41.29% <63.63%> (-3.21%) ⬇️
Windows_4 31.52% <ø> (-2.54%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ashwin-pc
Copy link
Member

When the toggle is off, i can see this bar at the top of discover:
image

@ashwin-pc
Copy link
Member

Screen.Recording.2024-07-22.at.3.36.51.PM.mov

The icons also dont have a tooltip indicating what they are right now

@LDrago27
Copy link
Collaborator Author

@ashwin-pc Thanks for feedback. I have fixed the issues highlighted above and migrated the date Picker to the Nav bar too.

@LDrago27 LDrago27 marked this pull request as draft July 23, 2024 01:37
@LDrago27 LDrago27 force-pushed the discoverNewNavBar branch from de29db9 to 8485cb2 Compare July 23, 2024 01:58
@LDrago27 LDrago27 marked this pull request as ready for review July 23, 2024 01:58
kavilla
kavilla previously approved these changes Jul 23, 2024
@LDrago27 LDrago27 force-pushed the discoverNewNavBar branch from 6d7d2b9 to 70b830f Compare July 23, 2024 06:05
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: Can we avoid registering them?

@kavilla kavilla merged commit e46e54a into opensearch-project:main Jul 23, 2024
64 of 67 checks passed
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch-Dashboards/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch-Dashboards/backport-2.x
# Create a new branch
git switch --create backport/backport-7326-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 e46e54a85fac05684c4a052325331e4f7331b6ce
# Push it to GitHub
git push --set-upstream origin backport/backport-7326-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch-Dashboards/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-7326-to-2.x.

LDrago27 added a commit to LDrago27/OpenSearch-Dashboards that referenced this pull request Jul 24, 2024
Signed-off-by: Suchit Sahoo <[email protected]>
(cherry picked from commit e46e54a)
LDrago27 added a commit to LDrago27/OpenSearch-Dashboards that referenced this pull request Jul 24, 2024
Signed-off-by: Suchit Sahoo <[email protected]>
(cherry picked from commit e46e54a)
LDrago27 added a commit to LDrago27/OpenSearch-Dashboards that referenced this pull request Jul 24, 2024
Signed-off-by: Suchit Sahoo <[email protected]>
(cherry picked from commit e46e54a)
LDrago27 added a commit to LDrago27/OpenSearch-Dashboards that referenced this pull request Jul 25, 2024
This PR aims to introduce a new Nav bar in Discover that would contain the Date Picker as well as the Navigation links that are currently part of headers. The Navigation Links have been replaced with the corresponding Icons to provide a modern UX. These setting are currently controlled by query:enhancements:enabled Advanced Setting Flag and would be visible when the above flag is turned on.

Signed-off-by: Suchit Sahoo <[email protected]>
(cherry picked from commit e46e54a)
LDrago27 added a commit that referenced this pull request Jul 25, 2024
* Bump OUI to 1.8.0 (#7363)

Signed-off-by: Miki <[email protected]>
(cherry picked from commit c1bae75)

* [Auto Suggest] OpenSearch SQL autosuggest with ANTLR (#7336)

* cherry pick

Signed-off-by: Eric <[email protected]>

* SQL keyword suggestion

Signed-off-by: Eric <[email protected]>

* column and values suggestions

Signed-off-by: Eric <[email protected]>

* adjust values suggestions and ignored token

Signed-off-by: Eric <[email protected]>

* suggestion type casting

Signed-off-by: Eric <[email protected]>

* ignore functions

Signed-off-by: Eric <[email protected]>

* case insensitive

Signed-off-by: Eric <[email protected]>

* change to use grammar for insensitive case

Signed-off-by: Eric <[email protected]>

* fix multi-line issue

Signed-off-by: Eric <[email protected]>

* code cleanup

Signed-off-by: Eric <[email protected]>

* move ppl out of scope

Signed-off-by: Eric <[email protected]>

* rename folder and add ignoring rules

Signed-off-by: Eric <[email protected]>

* resolve type issue

Signed-off-by: Eric <[email protected]>

* fix ppl suggestion provider issue

Signed-off-by: Eric <[email protected]>

* remove function suggestion

Signed-off-by: Eric <[email protected]>

* some code clean up and adding tests

Signed-off-by: Eric <[email protected]>

* cursor tests

Signed-off-by: Eric <[email protected]>

* remove testing setup

Signed-off-by: Eric <[email protected]>

* add changelog

Signed-off-by: Eric <[email protected]>

* update yarn file

Signed-off-by: Eric <[email protected]>

* add missing testing library

Signed-off-by: Eric <[email protected]>

* MDS integration

Signed-off-by: Eric <[email protected]>

* minor interface change and disable word based suggestion

Signed-off-by: Eric <[email protected]>

* update ID_LITERAL and recompile grammar

Signed-off-by: Eric <[email protected]>

* column suggest for agg function

Signed-off-by: Eric <[email protected]>

* revert version

Signed-off-by: Eric <[email protected]>

* opensearch sql syntax highlighting

Signed-off-by: Eric <[email protected]>

* add utility tests

Signed-off-by: Eric <[email protected]>

* symbol table test

Signed-off-by: Eric <[email protected]>

* error listener test

Signed-off-by: Eric <[email protected]>

* parse test

Signed-off-by: Eric <[email protected]>

* add suggestion provider to single line query editor

Signed-off-by: Eric <[email protected]>

* remove one test

Signed-off-by: Eric <[email protected]>

* add connection service type

Signed-off-by: Eric <[email protected]>

---------

Signed-off-by: Eric <[email protected]>
(cherry picked from commit 9348bd4)

* Move TopNavLinks to new Nav Bar Discover (#7326)

This PR aims to introduce a new Nav bar in Discover that would contain the Date Picker as well as the Navigation links that are currently part of headers. The Navigation Links have been replaced with the corresponding Icons to provide a modern UX. These setting are currently controlled by query:enhancements:enabled Advanced Setting Flag and would be visible when the above flag is turned on.

Signed-off-by: Suchit Sahoo <[email protected]>
(cherry picked from commit e46e54a)

* [navigation-next]fix: breadcrumb issue found in data source management and other similar cases. (#7401)

* feat: add scoped breadcrumbs

Signed-off-by: SuZhou-Joe <[email protected]>

* Changeset file for PR #7401 created/updated

* feat: move data source management register logic up a little bit

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: add unit test

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: revert the home related change

Signed-off-by: SuZhou-Joe <[email protected]>

* fix: overview error in all use case when workspace is enabled

Signed-off-by: SuZhou-Joe <[email protected]>

* fix: update snapshot

Signed-off-by: SuZhou-Joe <[email protected]>

* Changeset file for PR #7401 created/updated

* fix: hide nav groups that should be displayed

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: hide expand icon in left navigation

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: update

Signed-off-by: SuZhou-Joe <[email protected]>

---------

Signed-off-by: SuZhou-Joe <[email protected]>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Co-authored-by: ZilongX <[email protected]>
(cherry picked from commit 3f78c94)

* [Bug][Data Source] Move data source manageable feature flag to DSM plugin (#7440)

* Move data source manageable feature flag to DSM plugin

Signed-off-by: yubonluo <[email protected]>

* Changeset file for PR #7440 created/updated

---------

Signed-off-by: yubonluo <[email protected]>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
(cherry picked from commit dfcd2e1)

* [Discover-next] data set picker (#7426)

* update using query manager

Signed-off-by: Kawika Avilla <[email protected]>

* aggs not working

Signed-off-by: Kawika Avilla <[email protected]>

* almost there

Signed-off-by: Kawika Avilla <[email protected]>

* stablish

Signed-off-by: Kawika Avilla <[email protected]>

* thanks ashwin

Signed-off-by: Kawika Avilla <[email protected]>

* update ref name

Signed-off-by: Kawika Avilla <[email protected]>

* fix timefields

Signed-off-by: Kawika Avilla <[email protected]>

* clean up some console logs

Signed-off-by: Kawika Avilla <[email protected]>

* go safer route of setting language

Signed-off-by: Kawika Avilla <[email protected]>

* its working again

Signed-off-by: Kawika Avilla <[email protected]>

* fix names

Signed-off-by: Kawika Avilla <[email protected]>

* restore code editor and indices

Signed-off-by: Kawika Avilla <[email protected]>

* sql df

Signed-off-by: Kawika Avilla <[email protected]>

* fix external datasources again

Signed-off-by: Kawika Avilla <[email protected]>

---------

Signed-off-by: Kawika Avilla <[email protected]>
(cherry picked from commit 6a079d3)

* Fix add filter for numeric scripted field (#7022)

* Fix add filter for scripted field

Signed-off-by: abbyhu2000 <[email protected]>

* add unit test

Signed-off-by: abbyhu2000 <[email protected]>

* change from nested ternary to if else

Signed-off-by: abbyhu2000 <[email protected]>

* add more unit tests

Signed-off-by: abbyhu2000 <[email protected]>

* change unit tests

Signed-off-by: abbyhu2000 <[email protected]>

* fix typo

Signed-off-by: abbyhu2000 <[email protected]>

---------

Signed-off-by: abbyhu2000 <[email protected]>
(cherry picked from commit 7c1f8fc)

* [Bug][Workspace] Add permission validation at workspace detail page (#7435)

* [Bug][Workspace] Add permission validate at workspace detail page

Signed-off-by: yubonluo <[email protected]>

* Changeset file for PR #7435 created/updated

---------

Signed-off-by: yubonluo <[email protected]>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
(cherry picked from commit 45d34b5)

* Revert "[Discover-next] data set picker (#7426)" (#7479)

This reverts commit 6a079d3.

---------

Co-authored-by: Miki <[email protected]>
Co-authored-by: Eric Wei <[email protected]>
Co-authored-by: SuZhou-Joe <[email protected]>
Co-authored-by: yuboluo <[email protected]>
Co-authored-by: Kawika Avilla <[email protected]>
Co-authored-by: Qingyang(Abby) Hu <[email protected]>
Co-authored-by: Sean Li <[email protected]>
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jul 25, 2024
* Bump OUI to 1.8.0 (#7363)

Signed-off-by: Miki <[email protected]>
(cherry picked from commit c1bae75)

* [Auto Suggest] OpenSearch SQL autosuggest with ANTLR (#7336)

* cherry pick

Signed-off-by: Eric <[email protected]>

* SQL keyword suggestion

Signed-off-by: Eric <[email protected]>

* column and values suggestions

Signed-off-by: Eric <[email protected]>

* adjust values suggestions and ignored token

Signed-off-by: Eric <[email protected]>

* suggestion type casting

Signed-off-by: Eric <[email protected]>

* ignore functions

Signed-off-by: Eric <[email protected]>

* case insensitive

Signed-off-by: Eric <[email protected]>

* change to use grammar for insensitive case

Signed-off-by: Eric <[email protected]>

* fix multi-line issue

Signed-off-by: Eric <[email protected]>

* code cleanup

Signed-off-by: Eric <[email protected]>

* move ppl out of scope

Signed-off-by: Eric <[email protected]>

* rename folder and add ignoring rules

Signed-off-by: Eric <[email protected]>

* resolve type issue

Signed-off-by: Eric <[email protected]>

* fix ppl suggestion provider issue

Signed-off-by: Eric <[email protected]>

* remove function suggestion

Signed-off-by: Eric <[email protected]>

* some code clean up and adding tests

Signed-off-by: Eric <[email protected]>

* cursor tests

Signed-off-by: Eric <[email protected]>

* remove testing setup

Signed-off-by: Eric <[email protected]>

* add changelog

Signed-off-by: Eric <[email protected]>

* update yarn file

Signed-off-by: Eric <[email protected]>

* add missing testing library

Signed-off-by: Eric <[email protected]>

* MDS integration

Signed-off-by: Eric <[email protected]>

* minor interface change and disable word based suggestion

Signed-off-by: Eric <[email protected]>

* update ID_LITERAL and recompile grammar

Signed-off-by: Eric <[email protected]>

* column suggest for agg function

Signed-off-by: Eric <[email protected]>

* revert version

Signed-off-by: Eric <[email protected]>

* opensearch sql syntax highlighting

Signed-off-by: Eric <[email protected]>

* add utility tests

Signed-off-by: Eric <[email protected]>

* symbol table test

Signed-off-by: Eric <[email protected]>

* error listener test

Signed-off-by: Eric <[email protected]>

* parse test

Signed-off-by: Eric <[email protected]>

* add suggestion provider to single line query editor

Signed-off-by: Eric <[email protected]>

* remove one test

Signed-off-by: Eric <[email protected]>

* add connection service type

Signed-off-by: Eric <[email protected]>

---------

Signed-off-by: Eric <[email protected]>
(cherry picked from commit 9348bd4)

* Move TopNavLinks to new Nav Bar Discover (#7326)

This PR aims to introduce a new Nav bar in Discover that would contain the Date Picker as well as the Navigation links that are currently part of headers. The Navigation Links have been replaced with the corresponding Icons to provide a modern UX. These setting are currently controlled by query:enhancements:enabled Advanced Setting Flag and would be visible when the above flag is turned on.

Signed-off-by: Suchit Sahoo <[email protected]>
(cherry picked from commit e46e54a)

* [navigation-next]fix: breadcrumb issue found in data source management and other similar cases. (#7401)

* feat: add scoped breadcrumbs

Signed-off-by: SuZhou-Joe <[email protected]>

* Changeset file for PR #7401 created/updated

* feat: move data source management register logic up a little bit

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: add unit test

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: revert the home related change

Signed-off-by: SuZhou-Joe <[email protected]>

* fix: overview error in all use case when workspace is enabled

Signed-off-by: SuZhou-Joe <[email protected]>

* fix: update snapshot

Signed-off-by: SuZhou-Joe <[email protected]>

* Changeset file for PR #7401 created/updated

* fix: hide nav groups that should be displayed

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: hide expand icon in left navigation

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: update

Signed-off-by: SuZhou-Joe <[email protected]>

---------

Signed-off-by: SuZhou-Joe <[email protected]>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Co-authored-by: ZilongX <[email protected]>
(cherry picked from commit 3f78c94)

* [Bug][Data Source] Move data source manageable feature flag to DSM plugin (#7440)

* Move data source manageable feature flag to DSM plugin

Signed-off-by: yubonluo <[email protected]>

* Changeset file for PR #7440 created/updated

---------

Signed-off-by: yubonluo <[email protected]>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
(cherry picked from commit dfcd2e1)

* [Discover-next] data set picker (#7426)

* update using query manager

Signed-off-by: Kawika Avilla <[email protected]>

* aggs not working

Signed-off-by: Kawika Avilla <[email protected]>

* almost there

Signed-off-by: Kawika Avilla <[email protected]>

* stablish

Signed-off-by: Kawika Avilla <[email protected]>

* thanks ashwin

Signed-off-by: Kawika Avilla <[email protected]>

* update ref name

Signed-off-by: Kawika Avilla <[email protected]>

* fix timefields

Signed-off-by: Kawika Avilla <[email protected]>

* clean up some console logs

Signed-off-by: Kawika Avilla <[email protected]>

* go safer route of setting language

Signed-off-by: Kawika Avilla <[email protected]>

* its working again

Signed-off-by: Kawika Avilla <[email protected]>

* fix names

Signed-off-by: Kawika Avilla <[email protected]>

* restore code editor and indices

Signed-off-by: Kawika Avilla <[email protected]>

* sql df

Signed-off-by: Kawika Avilla <[email protected]>

* fix external datasources again

Signed-off-by: Kawika Avilla <[email protected]>

---------

Signed-off-by: Kawika Avilla <[email protected]>
(cherry picked from commit 6a079d3)

* Fix add filter for numeric scripted field (#7022)

* Fix add filter for scripted field

Signed-off-by: abbyhu2000 <[email protected]>

* add unit test

Signed-off-by: abbyhu2000 <[email protected]>

* change from nested ternary to if else

Signed-off-by: abbyhu2000 <[email protected]>

* add more unit tests

Signed-off-by: abbyhu2000 <[email protected]>

* change unit tests

Signed-off-by: abbyhu2000 <[email protected]>

* fix typo

Signed-off-by: abbyhu2000 <[email protected]>

---------

Signed-off-by: abbyhu2000 <[email protected]>
(cherry picked from commit 7c1f8fc)

* [Bug][Workspace] Add permission validation at workspace detail page (#7435)

* [Bug][Workspace] Add permission validate at workspace detail page

Signed-off-by: yubonluo <[email protected]>

* Changeset file for PR #7435 created/updated

---------

Signed-off-by: yubonluo <[email protected]>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
(cherry picked from commit 45d34b5)

* Revert "[Discover-next] data set picker (#7426)" (#7479)

This reverts commit 6a079d3.

---------

Co-authored-by: Miki <[email protected]>
Co-authored-by: Eric Wei <[email protected]>
Co-authored-by: SuZhou-Joe <[email protected]>
Co-authored-by: yuboluo <[email protected]>
Co-authored-by: Kawika Avilla <[email protected]>
Co-authored-by: Qingyang(Abby) Hu <[email protected]>
Co-authored-by: Sean Li <[email protected]>
(cherry picked from commit 0515fb2)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
LDrago27 pushed a commit that referenced this pull request Jul 25, 2024
* Bump OUI to 1.8.0 (#7363)


(cherry picked from commit c1bae75)

* [Auto Suggest] OpenSearch SQL autosuggest with ANTLR (#7336)

* cherry pick



* SQL keyword suggestion



* column and values suggestions



* adjust values suggestions and ignored token



* suggestion type casting



* ignore functions



* case insensitive



* change to use grammar for insensitive case



* fix multi-line issue



* code cleanup



* move ppl out of scope



* rename folder and add ignoring rules



* resolve type issue



* fix ppl suggestion provider issue



* remove function suggestion



* some code clean up and adding tests



* cursor tests



* remove testing setup



* add changelog



* update yarn file



* add missing testing library



* MDS integration



* minor interface change and disable word based suggestion



* update ID_LITERAL and recompile grammar



* column suggest for agg function



* revert version



* opensearch sql syntax highlighting



* add utility tests



* symbol table test



* error listener test



* parse test



* add suggestion provider to single line query editor



* remove one test



* add connection service type



---------


(cherry picked from commit 9348bd4)

* Move TopNavLinks to new Nav Bar Discover (#7326)

This PR aims to introduce a new Nav bar in Discover that would contain the Date Picker as well as the Navigation links that are currently part of headers. The Navigation Links have been replaced with the corresponding Icons to provide a modern UX. These setting are currently controlled by query:enhancements:enabled Advanced Setting Flag and would be visible when the above flag is turned on.


(cherry picked from commit e46e54a)

* [navigation-next]fix: breadcrumb issue found in data source management and other similar cases. (#7401)

* feat: add scoped breadcrumbs



* Changeset file for PR #7401 created/updated

* feat: move data source management register logic up a little bit



* feat: add unit test



* feat: revert the home related change



* fix: overview error in all use case when workspace is enabled



* fix: update snapshot



* Changeset file for PR #7401 created/updated

* fix: hide nav groups that should be displayed



* feat: hide expand icon in left navigation



* feat: update



---------




(cherry picked from commit 3f78c94)

* [Bug][Data Source] Move data source manageable feature flag to DSM plugin (#7440)

* Move data source manageable feature flag to DSM plugin



* Changeset file for PR #7440 created/updated

---------



(cherry picked from commit dfcd2e1)

* [Discover-next] data set picker (#7426)

* update using query manager



* aggs not working



* almost there



* stablish



* thanks ashwin



* update ref name



* fix timefields



* clean up some console logs



* go safer route of setting language



* its working again



* fix names



* restore code editor and indices



* sql df



* fix external datasources again



---------


(cherry picked from commit 6a079d3)

* Fix add filter for numeric scripted field (#7022)

* Fix add filter for scripted field



* add unit test



* change from nested ternary to if else



* add more unit tests



* change unit tests



* fix typo



---------


(cherry picked from commit 7c1f8fc)

* [Bug][Workspace] Add permission validation at workspace detail page (#7435)

* [Bug][Workspace] Add permission validate at workspace detail page



* Changeset file for PR #7435 created/updated

---------



(cherry picked from commit 45d34b5)

* Revert "[Discover-next] data set picker (#7426)" (#7479)

This reverts commit 6a079d3.

---------








(cherry picked from commit 0515fb2)

Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Miki <[email protected]>
Co-authored-by: Eric Wei <[email protected]>
Co-authored-by: SuZhou-Joe <[email protected]>
Co-authored-by: yuboluo <[email protected]>
Co-authored-by: Kawika Avilla <[email protected]>
Co-authored-by: Qingyang(Abby) Hu <[email protected]>
Co-authored-by: Sean Li <[email protected]>
@LDrago27
Copy link
Collaborator Author

Manual backport was done in #7477

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants