[Manual] [Backport 2.x] [Look&Feel] Apply missing guidance for visBuilder #7373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dan Dong <[email protected]>
❌ Empty Changelog SectionThe Changelog section in your PR description is empty. Please add a valid changelog entry or entries. If you did add a changelog entry, check to make sure that it was not accidentally included inside the comment block in the Changelog section. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 2.x #7373 +/- ##
==========================================
- Coverage 68.14% 68.04% -0.11%
==========================================
Files 3472 3478 +6
Lines 68836 68955 +119
Branches 11220 11250 +30
==========================================
+ Hits 46906 46918 +12
- Misses 19182 19289 +107
Partials 2748 2748
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
danieldong51
requested review from
ananzh,
kavilla,
AMoo-Miki,
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub,
curq,
bandinib-amzn,
SuZhou-Joe,
ruanyl,
BionIT,
xinruiba,
zhyuanqi,
mengweieric,
LDrago27 and
virajsanghvi
as code owners
zhongnansu
approved these changes
Jul 22, 2024
virajsanghvi
approved these changes
Jul 22, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jul 24, 2024
Signed-off-by: Dan Dong <[email protected]> (cherry picked from commit 69d913d) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
AMoo-Miki
pushed a commit
that referenced
this pull request
Jul 24, 2024
Signed-off-by: Dan Dong <[email protected]> (cherry picked from commit 69d913d) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
LDrago27
pushed a commit
that referenced
this pull request
Jul 24, 2024
(cherry picked from commit 69d913d) Signed-off-by: Dan Dong <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Backport #7341
Changelog
Check List
yarn test:jestyarn test:jest_integration