[Look&Feel] Apply missing guidance for visBuilder #7341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
opensearch-changeset-bot bot
added a commit
to danieldong51/OpenSearch-Dashboards
that referenced
this pull request
Jul 21, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7341 +/- ##
==========================================
+ Coverage 67.70% 67.75% +0.05%
==========================================
Files 3521 3521
Lines 69777 69783 +6
Branches 11390 11390
==========================================
+ Hits 47244 47283 +39
+ Misses 19732 19691 -41
- Partials 2801 2809 +8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
danieldong51
changed the title
zhongnansu
added
enhancement
src/plugins/vis_builder/public/application/components/data_tab/field_details.tsx
Show resolved
Hide resolved
Signed-off-by: Dan Dong <[email protected]>
danieldong51
force-pushed
the
vis_builder
branch
2 times, most recently
from
99313c6
to
b27424f
Compare
Signed-off-by: Dan Dong <[email protected]>
danieldong51
force-pushed
the
vis_builder
branch
from
dbf2110
to
e8b28de
Compare
danieldong51
requested review from
ananzh,
kavilla,
AMoo-Miki,
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub,
curq,
bandinib-amzn and
SuZhou-Joe
as code owners
danieldong51
requested review from
ruanyl,
BionIT,
xinruiba,
zhyuanqi,
mengweieric and
LDrago27
as code owners
virajsanghvi
approved these changes
Jul 22, 2024
Comment on lines
+7
to
+11
| // @ts-ignore | ||
| import { mountWithIntl } from 'test_utils/enzyme_helpers'; | ||
| import { IndexPatternField } from '../../../../../data/common'; | ||
| // @ts-ignore | ||
| import { findTestSubject } from '@elastic/eui/lib/test'; |
There was a problem hiding this comment.
Curious are these ignored elsewhere?
There was a problem hiding this comment.
at least in that folder they are - field_details.test.tsx and /utils/get_field_details.test.ts
There was a problem hiding this comment.
since the field details component includes my field bucket component, I mostly used the setup found in field_details.test.tsx
zhongnansu
approved these changes
Jul 22, 2024
|
The backport to To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch-Dashboards/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch-Dashboards/backport-2.x
# Create a new branch
git switch --create backport/backport-7341-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 55e23a44488089940c6974d38c0d4591b38595d5
# Push it to GitHub
git push --set-upstream origin backport/backport-7341-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch-Dashboards/backport-2.xThen, create a pull request where the |
This was referenced Jul 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Applies look and feel pattern guidance to components in visBuilder.
Screenshot
Changelog
Check List
yarn test:jestyarn test:jest_integration