Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Move decideClient and decideLegacyClient to data source plugin util #7138

Merged
merged 1 commit into from
Jul 1, 2024

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport ddf1a41 from #7079.

Copy link
Contributor

github-actions bot commented Jul 1, 2024

❌ Invalid Changelog Heading

The '## Changelog' heading in your PR description is either missing or malformed. Please make sure that your PR description includes a '## Changelog' heading with proper spelling, capitalization, spacing, and Markdown syntax.

…n util (#7079)

Signed-off-by: Zhongnan Su <[email protected]>
(cherry picked from commit ddf1a41)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@zhongnansu zhongnansu force-pushed the backport/backport-7079-to-2.x branch from 110725f to 9a7299a Compare July 1, 2024 18:11
@zhongnansu zhongnansu added the Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry label Jul 1, 2024
Copy link

codecov bot commented Jul 1, 2024

Codecov Report

Attention: Patch coverage is 77.77778% with 2 lines in your changes missing coverage. Please review.

Project coverage is 67.59%. Comparing base (353f509) to head (9a7299a).

Files Patch % Lines
src/plugins/data/server/index_patterns/routes.ts 0.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##              2.x    #7138   +/-   ##
=======================================
  Coverage   67.59%   67.59%           
=======================================
  Files        3446     3446           
  Lines       67908    67908           
  Branches    11027    11027           
=======================================
  Hits        45904    45904           
+ Misses      19341    19340    -1     
- Partials     2663     2664    +1     
Flag Coverage Δ
Linux_1 33.13% <22.22%> (ø)
Linux_2 55.23% <22.22%> (ø)
Linux_3 45.28% <77.77%> (-0.02%) ⬇️
Linux_4 35.02% <22.22%> (ø)
Windows_1 33.15% <22.22%> (ø)
Windows_2 55.18% <22.22%> (ø)
Windows_3 45.30% <77.77%> (+<0.01%) ⬆️
Windows_4 35.02% <22.22%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BionIT BionIT merged commit 91e2ce0 into 2.x Jul 1, 2024
65 of 66 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autocut Skip the changelog verification check on backports distinguished-contributor multiple datasource multiple datasource project refactor Tech debt related tasks that need refactoring Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry v2.16.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants