Move decideClient and decideLegacyClient to data source plugin util

[zhongnansu]

Description

• Move decideClient and decideLegacyClient from data plugin to data source plugin util, and update the usage
• added unit tests

Issues Resolved

#6417

Screenshot

Testing the changes

Changelog

• refactor: Move decideClient and decideLegacy client to data source plugin util

Check List

• All tests pass
  • yarn test:jest
  • yarn test:jest_integration
• New functionality includes testing.
• New functionality has been documented.
• Update CHANGELOG.md
• Commits are signed per the DCO using --signoff

[github-actions]

❌ Empty Changelog Section

The Changelog section in your PR description is empty. Please add a valid changelog entry or entries. If you did add a changelog entry, check to make sure that it was not accidentally included inside the comment block in the Changelog section.

[github-actions]

❌ Empty Changelog Section

The Changelog section in your PR description is empty. Please add a valid changelog entry or entries. If you did add a changelog entry, check to make sure that it was not accidentally included inside the comment block in the Changelog section.

[github-actions]

❌ Empty Changelog Section

The Changelog section in your PR description is empty. Please add a valid changelog entry or entries. If you did add a changelog entry, check to make sure that it was not accidentally included inside the comment block in the Changelog section.

[codecov]

Codecov Report

Attention: Patch coverage is 77.77778% with 2 lines in your changes missing coverage. Please review.

Project coverage is 67.45%. Comparing base (b85e177) to head (24eb251).

Files	Patch %	Lines
src/plugins/data/server/index_patterns/routes.ts	0.00%	2 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #7079   +/-   ##
=======================================
  Coverage   67.45%   67.45%           
=======================================
  Files        3448     3448           
  Lines       67964    67964           
  Branches    11057    11057           
=======================================
+ Hits        45845    45847    +2     
+ Misses      19446    19444    -2     
  Partials     2673     2673           

Flag	Coverage Δ
Linux_1	33.10% <22.22%> (ø)
Linux_2	55.06% <22.22%> (ø)
Linux_3	45.24% <77.77%> (+<0.01%)	⬆️
Linux_4	34.83% <22.22%> (ø)
Windows_1	33.12% <22.22%> (ø)
Windows_2	55.01% <22.22%> (ø)
Windows_3	45.26% <77.77%> (+<0.01%)	⬆️
Windows_4	34.83% <22.22%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[BionIT]

@zhongnansu Thanks for refactoring the util! Could you take a look at the failed workflow when having time?

[zhongnansu]

@zhongnansu Thanks for refactoring the util! Could you take a look at the failed workflow when having time?

Unit test in core -> ui_settings -> create_or_upgrade_saved_config.test.ts are failing, which is very weird, because I didn't touch any code there. Need to dive deep on this. Noticed that once I remove my change, this test can pass. And the error message is indicating module mock (doMock) is not working as expected.

Summary of all failing tests
 FAIL  src/core/server/ui_settings/create_or_upgrade_saved_config/create_or_upgrade_saved_config.test.ts
  ● uiSettings/createOrUpgradeSavedConfig › nothing is upgradeable › should create config with current version and buildNum

    TypeError: Cannot destructure property 'saved_objects' of '((cov_20o48geyyw(...).s[0]++) , (intermediate value))' as it is undefined.

      47 | }) {
      48 |   // attempt to find a config we can upgrade
    > 49 |   const { saved_objects: savedConfigs } = await savedObjectsClient.find({
         |                          ^
      50 |     type: 'config',
      51 |     page: 1,
      52 |     perPage: 1000,

      at getUpgradeableConfig (src/core/server/ui_settings/create_or_upgrade_saved_config/get_upgradeable_config.ts:49:26)
      at createOrUpgradeSavedConfig (src/core/server/ui_settings/create_or_upgrade_saved_config/create_or_upgrade_saved_config.ts:53:29)
      at run (src/core/server/ui_settings/create_or_upgrade_saved_config/create_or_upgrade_saved_config.test.ts:62:20)
      at Object.<anonymous> (src/core/server/ui_settings/create_or_upgrade_saved_config/create_or_upgrade_saved_config.test.ts:91:7)

Attach the failed CI: https://github.com/opensearch-project/OpenSearch-Dashboards/actions/runs/9639731291/job/26622985697?pr=7079