Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Manual Backport 2.x] [Multiple DataSource] Do not support import data source object to Local cluster when not enable data source #6913

Merged

Conversation

yujin-emma
Copy link
Contributor

Do not support import data source object to Local cluster when not enable data source

Description

Do not support import data source object to Local cluster when not enable data source
#6395

Issues Resolved

#6115

Screenshot

Testing the changes

Changelog

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

Copy link

codecov bot commented Jun 5, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 67.46%. Comparing base (d260f9e) to head (382d187).
Report is 1 commits behind head on 2.x.

Files Patch % Lines
...saved_objects_management/public/lib/import_file.ts 0.00% 2 Missing ⚠️
...erver/saved_objects/import/import_saved_objects.ts 88.88% 0 Missing and 1 partial ⚠️
src/core/server/saved_objects/routes/import.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              2.x    #6913      +/-   ##
==========================================
- Coverage   67.49%   67.46%   -0.04%     
==========================================
  Files        3442     3443       +1     
  Lines       67908    67926      +18     
  Branches    11035    11040       +5     
==========================================
- Hits        45836    45824      -12     
- Misses      19407    19434      +27     
- Partials     2665     2668       +3     
Flag Coverage Δ
Linux_1 33.08% <11.11%> (-0.01%) ⬇️
Linux_2 55.20% <87.50%> (+0.02%) ⬆️
Linux_3 ?
Linux_4 34.97% <20.00%> (-0.02%) ⬇️
Windows_1 ?
Windows_2 ?
Windows_3 45.25% <12.50%> (-0.02%) ⬇️
Windows_4 34.97% <20.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BionIT BionIT changed the title [Backport #6395] [Manual Backport 2.x] [Multiple DataSource] Do not support import data source object to Local cluster when not enable data source Jun 5, 2024
@BionIT BionIT added the v2.15.0 label Jun 5, 2024
zhongnansu
zhongnansu previously approved these changes Jun 5, 2024
zhyuanqi
zhyuanqi previously approved these changes Jun 5, 2024
@zhyuanqi zhyuanqi dismissed their stale review June 5, 2024 18:26

One test has failed

@zhyuanqi
Copy link
Collaborator

zhyuanqi commented Jun 5, 2024

One test has failed. Rerun the test to see the result

@BionIT
Copy link
Collaborator

BionIT commented Jun 6, 2024

@yujin-emma can you fix DCO error? looks like there are commits not signed?

yujin-emma and others added 3 commits June 6, 2024 05:21
…object to Local cluster when not enable data source

Signed-off-by: yujin-emma <[email protected]>
Signed-off-by: yujin-emma <[email protected]>
Signed-off-by: SuZhou-Joe <[email protected]>
Signed-off-by: yujin-emma <[email protected]>
@yujin-emma yujin-emma force-pushed the backport/backport-6395-to-2.x branch from 53c24e5 to b0f8310 Compare June 6, 2024 05:28
@yujin-emma
Copy link
Contributor Author

@yujin-emma can you fix DCO error? looks like there are commits not signed?

Updated branch

@BionIT BionIT merged commit ad47909 into opensearch-project:2.x Jun 6, 2024
64 of 65 checks passed
@zhongnansu zhongnansu added the multiple datasource multiple datasource project label Jun 6, 2024
@zhyuanqi zhyuanqi added the enhancement New feature or request label Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request multiple datasource multiple datasource project v2.15.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants