-
Notifications
You must be signed in to change notification settings - Fork 918
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG]MDS - Transfer data from MDS enabled data source to MDS disabled data source, hit auth failure #6115
Comments
Data source object maintain credentials, it should not be exportable as saved object. Therefore, asking user to update the password to reset the auth method is the expected behavior. There is no need to fix the import api |
Right now, we can import/export data source saved objects. From user friendly perspective, we need to give warning to user that data source object cannot work after export/import. @kgcreative Could we add warning on the UX |
I think data source objects should not be exportable. Instead, when exporting, we should remove the reference to the data source from all the saved objects. This will also make MDS enabled exports backward compatible with MDS disabled clusters. We might need an additional option on import to associate saved index patterns with existing data sources. |
+1 We might need to clarify this in official doc. 🙏 |
+1 on excluding the data source object when exporting saved object |
To resolve this issue, we might need to do the following:
|
When we show a list of objects, we should also omit the data source object type, and also exclude from "all related objects" export view. |
Hi, @kgcreative , just wonder how can we display the warning when we do not import/export data source object from UI. I am thinking where and when we display the warning, or can we fix it by the api side, and update the doc |
Found this quick config: https://github.com/opensearch-project/OpenSearch-Dashboards/blob/main/src/plugins/data_source/server/saved_objects/data_source.ts#L21
where help filter out all data source objects both on UI and api side, not sure if this can quick help resolve this issue and make the behavior consistent both on UI and api side |
Offline synced with @zengyan-amazon , data source objects should be same as other saved objects, it is importable and exportable, we should update doc to let customer know they need to update creds when they hit the auth failure, current export behavior is expected. |
issue to track the import change for throwing out error when user try to import data source object to non-MDS cluster: #6394
|
@yujin-emma , please work on backport the code change for 2.14 |
Describe the bug
I have some saved objects exported with data source, when imported to the default cluster, hit the auth failure
To Reproduce
Steps to reproduce the behavior:
Expected behavior
Import from MDS to non MDS should work as normal
OpenSearch Version
2.12
Dashboards Version
2.12
Plugins
N/A
Screenshots
Host/Environment (please complete the following information):
Additional context
Add any other context about the problem here.
The text was updated successfully, but these errors were encountered: