Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix on data source selectable and readonly component are not consistent #6545

Merged
merged 1 commit into from
Apr 19, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -134,6 +134,7 @@ Inspired from [Keep a Changelog](https://keepachangelog.com/en/1.0.0/)
- [Dynamic Configurations] Fix dynamic config API calls to pass correct input ([#6474](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/6474))
- [BUG][Multiple Datasource] Modify the button of selectable component to fix the title overflow issue ([#6465](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/6465))
- [BUG][Multiple Datasource] Validation succeed as long as status code in response is 200 ([#6399](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/6399))
- [BUG][Multiple Datasource] Fix on data source selectable and readonly component are not consistent ([#6545]https://github.com/opensearch-project/OpenSearch-Dashboards/pull/6545)
- [BUG][Multiple Datasource] Add validation for title length to be no longer than 32 characters [#6452](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/6452))

### 🚞 Infrastructure
Expand Down

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,7 @@ import {
EuiPanel,
EuiButtonEmpty,
EuiSelectable,
EuiSpacer,
EuiHorizontalRule,
EuiPopoverTitle,
} from '@elastic/eui';
import {
ApplicationStart,
Expand Down Expand Up @@ -270,14 +269,16 @@ export class DataSourceSelectable extends React.Component<
anchorPosition="downLeft"
data-test-subj={'dataSourceSelectableContextMenuPopover'}
>
<DataSourceDropDownHeader
totalDataSourceCount={this.state.dataSourceOptions.length}
application={this.props.application}
/>
<EuiContextMenuPanel>
<EuiPanel className={'dataSourceSelectableOuiPanel'} color="transparent" paddingSize="s">
<DataSourceDropDownHeader
totalDataSourceCount={this.state.dataSourceOptions.length}
application={this.props.application}
/>
<EuiHorizontalRule margin="none" />
<EuiSpacer size="s" />
<EuiPanel
className={'dataSourceSelectableOuiPanel'}
color="transparent"
paddingSize="none"
>
<EuiSelectable
aria-label="Search"
searchable
Expand All @@ -299,7 +300,7 @@ export class DataSourceSelectable extends React.Component<
>
{(list, search) => (
<>
{search}
<EuiPopoverTitle paddingSize="s">{search}</EuiPopoverTitle>
{list}
</>
)}
Expand Down
Loading
Loading