Fix on data source selectable and readonly component are not consistent #6545

zhyuanqi · 2024-04-18T21:38:50Z

Description

fix on data source selectable and readonly component are not consistent
Related Issue: #6535

Describe the bug

The height of the popover header should be consistent between the read-only and selectable
The stroke around the header looks better in the read-only popover, the floating line between the search field and the header looks a bit weird. This might be a part of next item.
It looks like additional padding is added to the selectable popover content

screenshot

Testing the changes

Changelog

fix: fix on data source selectable and readonly component are not consistent

Check List

All tests pass
- yarn test:jest
- yarn test:jest_integration
New functionality includes testing.
New functionality has been documented.
Update CHANGELOG.md
Commits are signed per the DCO using --signoff

github-actions · 2024-04-18T21:39:30Z

❌ Invalid Prefix

Invalid description prefix. Found "bug". Expected "breaking", "deprecate", "feat", "fix", "infra", "doc", "chore", "refactor", "security", "skip", or "test".

github-actions · 2024-04-18T21:40:16Z

❌ Invalid Prefix

Invalid description prefix. Found "bug". Expected "breaking", "deprecate", "feat", "fix", "infra", "doc", "chore", "refactor", "security", "skip", or "test".

github-actions · 2024-04-18T21:40:18Z

❌ Invalid Prefix

Invalid description prefix. Found "bug". Expected "breaking", "deprecate", "feat", "fix", "infra", "doc", "chore", "refactor", "security", "skip", or "test".

codecov · 2024-04-18T22:12:04Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.75%. Comparing base (d2d410b) to head (2232590).
Report is 11 commits behind head on main.

❗ Current head 2232590 differs from pull request most recent head c4f828e. Consider uploading reports for the commit c4f828e to get more accurate results

Additional details and impacted files

@@             Coverage Diff             @@
##             main    #6545       +/-   ##
===========================================
+ Coverage   32.93%   49.75%   +16.81%     
===========================================
  Files        2260     2685      +425     
  Lines       45769    54702     +8933     
  Branches     7200     8980     +1780     
===========================================
+ Hits        15075    27215    +12140     
+ Misses      29984    25788     -4196     
- Partials      710     1699      +989

Flag	Coverage Δ
Linux_1	`?`
Windows_1	`33.00% <ø> (?)`
Windows_3	`45.20% <ø> (?)`

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

zhongnansu · 2024-04-19T00:06:27Z

src/plugins/data_source_management/public/components/data_source_view/data_source_view.tsx

-            }
-          </EuiPanel>
-          <EuiPanel color="subdued" paddingSize="xs" borderRadius="none">
+        <DataSourceDropDownHeader totalDataSourceCount={1} application={this.props.application} />


I saw in the DataSourceSelectable, DataSourceDropDownHeader is wrapped by EuiContextMenuPanel , do we need the same for data source view?

Thank you for bringing this up. I did a close look at it and i think the Drop down header should be outside of Panel as it is using the EuiPopoverTitle in the back

Signed-off-by: Yuanqi(Ella) Zhu <[email protected]>

…nt (#6545) Signed-off-by: Yuanqi(Ella) Zhu <[email protected]> (cherry picked from commit 35fe82d) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md

…nt (#6545) (#6558) Signed-off-by: Yuanqi(Ella) Zhu <[email protected]> (cherry picked from commit 35fe82d) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

…nt (opensearch-project#6545) Signed-off-by: Yuanqi(Ella) Zhu <[email protected]>

zhyuanqi requested review from ananzh, kavilla, AMoo-Miki, ashwin-pc, joshuarrrr, abbyhu2000, zengyan-amazon, zhongnansu, manasvinibs, ZilongX, Flyingliuhub, curq, bandinib-amzn, SuZhou-Joe, ruanyl, BionIT and xinruiba as code owners April 18, 2024 21:38

github-actions bot added the valued-contributor label Apr 18, 2024

github-actions bot added the failed changeset label Apr 18, 2024

zhyuanqi changed the title ~~fix on data source selectable and readonly component are not consistent~~ Fix on data source selectable and readonly component are not consistent Apr 18, 2024

github-actions bot removed the failed changeset label Apr 18, 2024

opensearch-changeset-bot bot added a commit to zhyuanqi/OpenSearch-Dashboards that referenced this pull request Apr 18, 2024

Changeset file for PR opensearch-project#6545 created/updated

d14ca0d

zhyuanqi force-pushed the ui-fix branch from d14ca0d to 2232590 Compare April 18, 2024 21:42

opensearch-changeset-bot bot added a commit to zhyuanqi/OpenSearch-Dashboards that referenced this pull request Apr 18, 2024

Changeset file for PR opensearch-project#6545 created/updated

5725ac7

zhyuanqi force-pushed the ui-fix branch from 5725ac7 to a47fed9 Compare April 18, 2024 22:19

zhongnansu reviewed Apr 19, 2024

View reviewed changes

BionIT previously approved these changes Apr 19, 2024

View reviewed changes

zhyuanqi dismissed BionIT’s stale review via db89f9b April 19, 2024 05:33

zhyuanqi force-pushed the ui-fix branch 2 times, most recently from db89f9b to ca8dcbc Compare April 19, 2024 05:34

fix on data source selectable and readonly component are not consistent

c4f828e

Signed-off-by: Yuanqi(Ella) Zhu <[email protected]>

zhyuanqi force-pushed the ui-fix branch from ca8dcbc to c4f828e Compare April 19, 2024 17:18

zhongnansu approved these changes Apr 19, 2024

View reviewed changes

zhongnansu requested a review from BionIT April 19, 2024 17:30

zhyuanqi added backport 2.x v2.14.0 multiple datasource multiple datasource project labels Apr 19, 2024

BionIT approved these changes Apr 19, 2024

View reviewed changes

BionIT merged commit 35fe82d into opensearch-project:main Apr 19, 2024
71 checks passed

opensearch-trigger-bot bot mentioned this pull request Apr 19, 2024

[Backport 2.x] Fix on data source selectable and readonly component are not consistent #6558

Merged

BionIT mentioned this pull request Apr 22, 2024

[Meta][UX][Multiple Datasource] Improvement to data source components in the navigation bar #6216

Closed

36 tasks

LDrago27 pushed a commit to LDrago27/OpenSearch-Dashboards that referenced this pull request Jun 3, 2024

fix on data source selectable and readonly component are not consiste…

0e12ff2

…nt (opensearch-project#6545) Signed-off-by: Yuanqi(Ella) Zhu <[email protected]>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix on data source selectable and readonly component are not consistent #6545

Fix on data source selectable and readonly component are not consistent #6545

zhyuanqi commented Apr 18, 2024 •

edited

Loading

github-actions bot commented Apr 18, 2024

github-actions bot commented Apr 18, 2024

github-actions bot commented Apr 18, 2024

codecov bot commented Apr 18, 2024 •

edited

Loading

zhongnansu Apr 19, 2024

zhyuanqi Apr 19, 2024

Fix on data source selectable and readonly component are not consistent #6545

Fix on data source selectable and readonly component are not consistent #6545

Conversation

zhyuanqi commented Apr 18, 2024 • edited Loading

Description

screenshot

Testing the changes

Changelog

Check List

github-actions bot commented Apr 18, 2024

❌ Invalid Prefix

github-actions bot commented Apr 18, 2024

❌ Invalid Prefix

github-actions bot commented Apr 18, 2024

❌ Invalid Prefix

codecov bot commented Apr 18, 2024 • edited Loading

Codecov Report

zhongnansu Apr 19, 2024

Choose a reason for hiding this comment

zhyuanqi Apr 19, 2024

Choose a reason for hiding this comment

zhyuanqi commented Apr 18, 2024 •

edited

Loading

codecov bot commented Apr 18, 2024 •

edited

Loading