Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] [Data Explorer] Fixes save search glitch + misc #4880

Merged
merged 1 commit into from
Sep 1, 2023

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 51c5360 from #4870.

* Hide view toggle

Signed-off-by: Ashwin P Chandran <[email protected]>

* misc fixes

Signed-off-by: Ashwin P Chandran <[email protected]>

* fixes save behavior

Signed-off-by: Ashwin P Chandran <[email protected]>

---------

Signed-off-by: Ashwin P Chandran <[email protected]>
(cherry picked from commit 51c5360)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot added discover for discover reinvent autocut Skip the changelog verification check on backports labels Aug 31, 2023
@opensearch-trigger-bot opensearch-trigger-bot bot added the Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry label Aug 31, 2023
@opensearch-trigger-bot opensearch-trigger-bot bot added data explorer Issues related to the Data Explorer project v2.10.0 labels Aug 31, 2023
@codecov
Copy link

codecov bot commented Aug 31, 2023

Codecov Report

Merging #4880 (fb945e3) into 2.x (96af535) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##              2.x    #4880      +/-   ##
==========================================
- Coverage   66.44%   66.44%   -0.01%     
==========================================
  Files        3396     3395       -1     
  Lines       64847    64843       -4     
  Branches    10356    10356              
==========================================
- Hits        43088    43083       -5     
- Misses      19202    19208       +6     
+ Partials     2557     2552       -5     
Flag Coverage Δ
Linux_1 34.91% <ø> (ø)
Linux_2 55.18% <ø> (ø)
Linux_3 44.19% <ø> (-0.01%) ⬇️
Linux_4 35.08% <ø> (ø)
Windows_1 34.93% <ø> (ø)
Windows_2 55.15% <ø> (ø)
Windows_3 44.19% <ø> (-0.01%) ⬇️
Windows_4 35.08% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
.../data_explorer/public/components/sidebar/index.tsx 3.12% <ø> (+0.09%) ⬆️

... and 6 files with indirect coverage changes

@kavilla kavilla merged commit fae4e3c into 2.x Sep 1, 2023
@github-actions github-actions bot deleted the backport/backport-4870-to-2.x branch September 1, 2023 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autocut Skip the changelog verification check on backports data explorer Issues related to the Data Explorer project discover for discover reinvent Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry v2.10.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants