-
Notifications
You must be signed in to change notification settings - Fork 916
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Data Explorer] Fixes save search glitch + misc #4870
Conversation
Signed-off-by: Ashwin P Chandran <[email protected]>
Signed-off-by: Ashwin P Chandran <[email protected]>
Signed-off-by: Ashwin P Chandran <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #4870 +/- ##
==========================================
- Coverage 66.43% 66.43% -0.01%
==========================================
Files 3396 3395 -1
Lines 64869 64865 -4
Branches 10358 10358
==========================================
- Hits 43096 43091 -5
- Misses 19214 19294 +80
+ Partials 2559 2480 -79
Flags with carried forward coverage won't be shown. Click here to find out more.
|
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch-Dashboards/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch-Dashboards/backport-2.x
# Create a new branch
git switch --create backport/backport-4870-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 51c536095da39dbb7e5147f6640fa381579d25e6
# Push it to GitHub
git push --set-upstream origin backport/backport-4870-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch-Dashboards/backport-2.x Then, create a pull request where the |
* Hide view toggle Signed-off-by: Ashwin P Chandran <[email protected]> * misc fixes Signed-off-by: Ashwin P Chandran <[email protected]> * fixes save behavior Signed-off-by: Ashwin P Chandran <[email protected]> --------- Signed-off-by: Ashwin P Chandran <[email protected]> (cherry picked from commit 51c5360) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* Hide view toggle * misc fixes * fixes save behavior --------- (cherry picked from commit 51c5360) Signed-off-by: Ashwin P Chandran <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Description
This PR fixes a few small issues:
Skip to bottom
Issues Resolved
fixes #4844
Screenshot
Testing the changes
Check List
yarn test:jest
yarn test:jest_integration
yarn test:ftr