Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Data Explorer] Fixes save search glitch + misc #4870

Merged
merged 3 commits into from
Aug 31, 2023

Conversation

ashwin-pc
Copy link
Member

@ashwin-pc ashwin-pc commented Aug 31, 2023

Description

This PR fixes a few small issues:

  1. Save search bugginess [BUG] [Data Explorer] Saved search functionality buggy on data explorer #4844
  2. Removes unnecessary component Skip to bottom
  3. Breadcrumbs in discover view
  4. Hides View switcher for 2.10

Issues Resolved

fixes #4844

Screenshot

Testing the changes

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
    • yarn test:ftr
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

Signed-off-by: Ashwin P Chandran <[email protected]>
Signed-off-by: Ashwin P Chandran <[email protected]>
Signed-off-by: Ashwin P Chandran <[email protected]>
@ashwin-pc ashwin-pc added backport 2.x discover for discover reinvent data explorer Issues related to the Data Explorer project v2.10.0 Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry and removed distinguished-contributor labels Aug 31, 2023
@codecov
Copy link

codecov bot commented Aug 31, 2023

Codecov Report

Merging #4870 (b62700b) into main (e9ad10f) will decrease coverage by 0.01%.
Report is 1 commits behind head on main.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #4870      +/-   ##
==========================================
- Coverage   66.43%   66.43%   -0.01%     
==========================================
  Files        3396     3395       -1     
  Lines       64869    64865       -4     
  Branches    10358    10358              
==========================================
- Hits        43096    43091       -5     
- Misses      19214    19294      +80     
+ Partials     2559     2480      -79     
Flag Coverage Δ
Linux_1 34.85% <ø> (ø)
Linux_2 55.15% <ø> (ø)
Linux_3 44.23% <ø> (-0.01%) ⬇️
Linux_4 35.04% <ø> (ø)
Windows_1 34.87% <ø> (ø)
Windows_2 55.12% <ø> (ø)
Windows_3 44.23% <ø> (-0.01%) ⬇️
Windows_4 35.04% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
.../data_explorer/public/components/sidebar/index.tsx 3.12% <ø> (+0.09%) ⬆️

... and 20 files with indirect coverage changes

@ashwin-pc ashwin-pc merged commit 51c5360 into opensearch-project:main Aug 31, 2023
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch-Dashboards/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch-Dashboards/backport-2.x
# Create a new branch
git switch --create backport/backport-4870-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 51c536095da39dbb7e5147f6640fa381579d25e6
# Push it to GitHub
git push --set-upstream origin backport/backport-4870-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch-Dashboards/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-4870-to-2.x.

opensearch-trigger-bot bot pushed a commit that referenced this pull request Aug 31, 2023
* Hide view toggle

Signed-off-by: Ashwin P Chandran <[email protected]>

* misc fixes

Signed-off-by: Ashwin P Chandran <[email protected]>

* fixes save behavior

Signed-off-by: Ashwin P Chandran <[email protected]>

---------

Signed-off-by: Ashwin P Chandran <[email protected]>
(cherry picked from commit 51c5360)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
kavilla pushed a commit that referenced this pull request Sep 1, 2023
* Hide view toggle



* misc fixes



* fixes save behavior



---------


(cherry picked from commit 51c5360)

Signed-off-by: Ashwin P Chandran <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x data explorer Issues related to the Data Explorer project discover for discover reinvent Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry v2.10.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] [Data Explorer] Saved search functionality buggy on data explorer
3 participants