Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 1.x] Temporarily hardcode chromedriver to 112.0.0 to enable all ftr tests #4038

Merged
merged 1 commit into from
May 16, 2023

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 5ea0cbe from #3976.

…3976)

The latest version of chromedriver is 112.0.1 which does not support
node 14. This PR hardcodes chromedriver to 112.0.0 temporarily. Pls
revert it once we bump to node 18.

Issue Resolved
#3975

Signed-off-by: ananzh <[email protected]>
(cherry picked from commit 5ea0cbe)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

# Conflicts:
#	CHANGELOG.md
@kavilla kavilla added the Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry label May 15, 2023
@codecov
Copy link

codecov bot commented May 16, 2023

Codecov Report

Merging #4038 (b0fd66f) into 1.x (364832d) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              1.x    #4038   +/-   ##
=======================================
  Coverage   67.49%   67.50%           
=======================================
  Files        3044     3044           
  Lines       58692    58692           
  Branches     8902     8902           
=======================================
+ Hits        39617    39619    +2     
+ Misses      16926    16925    -1     
+ Partials     2149     2148    -1     
Flag Coverage Δ
Linux 67.46% <ø> (+<0.01%) ⬆️
Windows 67.45% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

@kavilla
Copy link
Member

kavilla commented May 16, 2023

#4037 (comment)

@abbyhu2000 abbyhu2000 merged commit 3638e7a into 1.x May 16, 2023
@github-actions github-actions bot deleted the backport/backport-3976-to-1.x branch May 16, 2023 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry v1.3.11
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants