[Backport 2.x] Temporarily hardcode chromedriver to 112.0.0 to enable all ftr tests #4037
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![opensearch-trigger-bot[bot]](https://avatars.githubusercontent.com/u/80134844?s=60&v=4){kind=small}
…3976) The latest version of chromedriver is 112.0.1 which does not support node 14. This PR hardcodes chromedriver to 112.0.0 temporarily. Pls revert it once we bump to node 18. Issue Resolved #3975 Signed-off-by: ananzh <[email protected]> (cherry picked from commit 5ea0cbe) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md
opensearch-trigger-bot
bot
requested review from
ananzh,
kavilla,
seanneumann,
AMoo-Miki,
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
kristenTian,
zhongnansu and
manasvinibs
as code owners
kavilla
added
the
Skip-Changelog
|
Test will fail because this will also need to be merged in: https://github.com/opensearch-project/OpenSearch-Dashboards/pull/4013/files. But that PR is blocked by this PR not getting merged in. |
Codecov Report
@@ Coverage Diff @@
## 2.x #4037 +/- ##
==========================================
- Coverage 66.45% 66.45% -0.01%
==========================================
Files 3229 3229
Lines 62045 62045
Branches 9597 9597
==========================================
- Hits 41232 41230 -2
- Misses 18513 18514 +1
- Partials 2300 2301 +1
Flags with carried forward coverage won't be shown. Click here to find out more. |
kavilla
approved these changes
May 16, 2023
This was referenced May 16, 2023
abbyhu2000
approved these changes
May 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 5ea0cbe from #3976.