Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use mirrors to download Node.js binaries to escape sporadic 404 errors #3619

Merged
merged 1 commit into from
Mar 20, 2023
Merged

Use mirrors to download Node.js binaries to escape sporadic 404 errors #3619

merged 1 commit into from
Mar 20, 2023

Conversation

ananzh
Copy link
Member

@ananzh ananzh commented Mar 16, 2023 •
edited
Loading

Issue Resolved:
#3618

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
    • yarn test:ftr
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@ananzh ananzh requested a review from a team as a code owner March 16, 2023 16:56
@ananzh ananzh changed the title [BUG]Fix nodejs download 404 error by switching to mirrors Fix nodejs download 404 error by switching to mirrors Mar 16, 2023
AMoo-Miki
AMoo-Miki reviewed Mar 16, 2023
View reviewed changes
CHANGELOG.md Outdated
@@ -67,6 +67,7 @@ Inspired from [Keep a Changelog](https://keepachangelog.com/en/1.0.0/)
- [Multiple DataSource] Refactor test connection to support SigV4 auth type ([#3456](https://github.com/opensearch-project/OpenSearch-Dashboards/issues/3456))
- [Darwin] Add support for Darwin for running OpenSearch snapshots with `yarn opensearch snapshot` ([#3537](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/3537))
- [Vis Builder] Add metric to metric, bucket to bucket aggregation persistence ([#3495](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/3495))
- Fix nodejs download 404 error by switching to mirrors ([#3619](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/3619))
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Fix nodejs download 404 error by switching to mirrors ([#3619](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/3619))
- Use mirrors to download Node.js binaries to escape sporadic 404 errors ([#3619](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/3619))

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@ananzh ananzh changed the title Fix nodejs download 404 error by switching to mirrors Use mirrors to download Node.js binaries to escape sporadic 404 errors Mar 16, 2023
@kavilla kavilla linked an issue Mar 16, 2023 that may be closed by this pull request
node.js 14.21.3 download is not stable and raise 404 error #3618
Closed
@kavilla
Copy link
Member

kavilla commented Mar 16, 2023

@peterzhuamazon for builds there is nothing here that would prevent us changing the URLs here right? Like some allowlist of links that the build process can pull from?

@peterzhuamazon
Copy link
Member

@peterzhuamazon for builds there is nothing here that would prevent us changing the URLs here right? Like some allowlist of links that the build process can pull from?

It is not related to build so you can change per your need.
It is not pulling from ci.opensearch.org or artifacts.opensearch.org anyway.

Thanks.

@abbyhu2000 abbyhu2000 merged commit 99a88e3 into opensearch-project:main Mar 20, 2023
kappassov pushed a commit to kappassov/OpenSearch-Dashboards that referenced this pull request Mar 21, 2023
@ananzh @kappassov
Use mirrors to download Node.js binaries to escape sporadic 404 errors (
59be6b4 
opensearch-project#3619)

Issue Resolved:
opensearch-project#3618

Signed-off-by: Anan Zhuang <[email protected]>
pjfitzgibbons pushed a commit to pjfitzgibbons/OpenSearch-Dashboards that referenced this pull request Mar 22, 2023
@ananzh
Use mirrors to download Node.js binaries to escape sporadic 404 errors (
3bba74f 
opensearch-project#3619)

Issue Resolved:
opensearch-project#3618

Signed-off-by: Anan Zhuang <[email protected]>
abbyhu2000 pushed a commit that referenced this pull request Mar 22, 2023
@kappassov @ananzh
@AMoo-Miki @zhongnansu
[CCI] Adding second command to Install yarn step in Developer Guide (#…
b0146e7 
…3633)

* added prepare command

Signed-off-by: kappassov <[email protected]>

* Use mirrors to download Node.js binaries to escape sporadic 404 errors (#3619)

Issue Resolved:
#3618

Signed-off-by: Anan Zhuang <[email protected]>

* Allow selecting the Node.js binary OSD uses (#3508)

New reusable use_node scripts take care of selecting the correct Node.js binary based OSD_NODE_HOME, OSD_HOME, and whatever is in the PATH. It also takes care of finding the binary on FreeBSD.
* The startup scripts check `OSD_NODE_HOME` and `NODE_HOME` before falling back to use the bundled or system-wide Node.js binary.
* Update `package.json` to replace `node` with `use_node`.
* Update file templates and shell scripts to internally use `use_node`.
* Update the build scripts to copy `use_node` into releases
* Make tests that execute node internally, honor the binary being used.

Signed-off-by: Miki <[email protected]>

* Clean up and rebuild @osd/pm (#3570)

* Fix the build failures
* Removed some unused packages
* Update gist url templates in Lychee's exclusion list

Signed-off-by: Miki <[email protected]>

* Refactor dev tool console to use opensearch-js client to send request (#3544)

Refactor dev tool console to use opensearch-js client to interact with OpenSearch

Signed-off-by: Su <[email protected]>

* updates after the 1st review

Signed-off-by: kappassov <[email protected]>

---------

Signed-off-by: kappassov <[email protected]>
Signed-off-by: Anan Zhuang <[email protected]>
Signed-off-by: Miki <[email protected]>
Signed-off-by: Su <[email protected]>
Co-authored-by: Anan Zhuang <[email protected]>
Co-authored-by: Miki <[email protected]>
Co-authored-by: Zhongnan Su <[email protected]>
opensearch-trigger-bot bot pushed a commit that referenced this pull request Mar 22, 2023
@github-actions @ananzh
@AMoo-Miki @zhongnansu
[CCI] Adding second command to Install yarn step in Developer Guide (#…
a91302d 
…3633)

* added prepare command

Signed-off-by: kappassov <[email protected]>

* Use mirrors to download Node.js binaries to escape sporadic 404 errors (#3619)

Issue Resolved:
#3618

Signed-off-by: Anan Zhuang <[email protected]>

* Allow selecting the Node.js binary OSD uses (#3508)

New reusable use_node scripts take care of selecting the correct Node.js binary based OSD_NODE_HOME, OSD_HOME, and whatever is in the PATH. It also takes care of finding the binary on FreeBSD.
* The startup scripts check `OSD_NODE_HOME` and `NODE_HOME` before falling back to use the bundled or system-wide Node.js binary.
* Update `package.json` to replace `node` with `use_node`.
* Update file templates and shell scripts to internally use `use_node`.
* Update the build scripts to copy `use_node` into releases
* Make tests that execute node internally, honor the binary being used.

Signed-off-by: Miki <[email protected]>

* Clean up and rebuild @osd/pm (#3570)

* Fix the build failures
* Removed some unused packages
* Update gist url templates in Lychee's exclusion list

Signed-off-by: Miki <[email protected]>

* Refactor dev tool console to use opensearch-js client to send request (#3544)

Refactor dev tool console to use opensearch-js client to interact with OpenSearch

Signed-off-by: Su <[email protected]>

* updates after the 1st review

Signed-off-by: kappassov <[email protected]>

---------

Signed-off-by: kappassov <[email protected]>
Signed-off-by: Anan Zhuang <[email protected]>
Signed-off-by: Miki <[email protected]>
Signed-off-by: Su <[email protected]>
Co-authored-by: Anan Zhuang <[email protected]>
Co-authored-by: Miki <[email protected]>
Co-authored-by: Zhongnan Su <[email protected]>
(cherry picked from commit b0146e7)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
abbyhu2000 pushed a commit that referenced this pull request Mar 22, 2023
@opensearch-trigger-bot @github-actions
@ananzh @AMoo-Miki @zhongnansu
[CCI] Adding second command to Install yarn step in Developer Guide (#…
3d2082a 
…3633) (#3651)

* added prepare command



* Use mirrors to download Node.js binaries to escape sporadic 404 errors (#3619)

Issue Resolved:
#3618



* Allow selecting the Node.js binary OSD uses (#3508)

New reusable use_node scripts take care of selecting the correct Node.js binary based OSD_NODE_HOME, OSD_HOME, and whatever is in the PATH. It also takes care of finding the binary on FreeBSD.
* The startup scripts check `OSD_NODE_HOME` and `NODE_HOME` before falling back to use the bundled or system-wide Node.js binary.
* Update `package.json` to replace `node` with `use_node`.
* Update file templates and shell scripts to internally use `use_node`.
* Update the build scripts to copy `use_node` into releases
* Make tests that execute node internally, honor the binary being used.



* Clean up and rebuild @osd/pm (#3570)

* Fix the build failures
* Removed some unused packages
* Update gist url templates in Lychee's exclusion list



* Refactor dev tool console to use opensearch-js client to send request (#3544)

Refactor dev tool console to use opensearch-js client to interact with OpenSearch



* updates after the 1st review



---------








(cherry picked from commit b0146e7)

Signed-off-by: kappassov <[email protected]>
Signed-off-by: Anan Zhuang <[email protected]>
Signed-off-by: Miki <[email protected]>
Signed-off-by: Su <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Anan Zhuang <[email protected]>
Co-authored-by: Miki <[email protected]>
Co-authored-by: Zhongnan Su <[email protected]>
@joshuarrrr
Copy link
Member

@ananzh We should backport to 2.x, right?

@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Mar 23, 2023
Merged
opensearch-trigger-bot bot pushed a commit that referenced this pull request Mar 23, 2023
@github-actions
Use mirrors to download Node.js binaries to escape sporadic 404 errors (
da5bccb 
#3619)

Issue Resolved:
#3618

Signed-off-by: Anan Zhuang <[email protected]>
(cherry picked from commit 99a88e3)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

# Conflicts:
#	CHANGELOG.md
abbyhu2000 pushed a commit that referenced this pull request Mar 24, 2023
@opensearch-trigger-bot @github-actions
Use mirrors to download Node.js binaries to escape sporadic 404 errors (
36f64cd 
#3619) (#3664)

Issue Resolved:
#3618

Signed-off-by: Anan Zhuang <[email protected]>
(cherry picked from commit 99a88e3)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

# Conflicts:
#	CHANGELOG.md

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
pjfitzgibbons pushed a commit to pjfitzgibbons/OpenSearch-Dashboards that referenced this pull request Mar 24, 2023
@kappassov @ananzh
@AMoo-Miki @zhongnansu
[CCI] Adding second command to Install yarn step in Developer Guide (o…
9821c56 
…pensearch-project#3633)

* added prepare command

Signed-off-by: kappassov <[email protected]>

* Use mirrors to download Node.js binaries to escape sporadic 404 errors (opensearch-project#3619)

Issue Resolved:
opensearch-project#3618

Signed-off-by: Anan Zhuang <[email protected]>

* Allow selecting the Node.js binary OSD uses (opensearch-project#3508)

New reusable use_node scripts take care of selecting the correct Node.js binary based OSD_NODE_HOME, OSD_HOME, and whatever is in the PATH. It also takes care of finding the binary on FreeBSD.
* The startup scripts check `OSD_NODE_HOME` and `NODE_HOME` before falling back to use the bundled or system-wide Node.js binary.
* Update `package.json` to replace `node` with `use_node`.
* Update file templates and shell scripts to internally use `use_node`.
* Update the build scripts to copy `use_node` into releases
* Make tests that execute node internally, honor the binary being used.

Signed-off-by: Miki <[email protected]>

* Clean up and rebuild @osd/pm (opensearch-project#3570)

* Fix the build failures
* Removed some unused packages
* Update gist url templates in Lychee's exclusion list

Signed-off-by: Miki <[email protected]>

* Refactor dev tool console to use opensearch-js client to send request (opensearch-project#3544)

Refactor dev tool console to use opensearch-js client to interact with OpenSearch

Signed-off-by: Su <[email protected]>

* updates after the 1st review

Signed-off-by: kappassov <[email protected]>

---------

Signed-off-by: kappassov <[email protected]>
Signed-off-by: Anan Zhuang <[email protected]>
Signed-off-by: Miki <[email protected]>
Signed-off-by: Su <[email protected]>
Co-authored-by: Anan Zhuang <[email protected]>
Co-authored-by: Miki <[email protected]>
Co-authored-by: Zhongnan Su <[email protected]>
sikhote pushed a commit to sikhote/OpenSearch-Dashboards that referenced this pull request Apr 24, 2023
@ananzh @sikhote
Use mirrors to download Node.js binaries to escape sporadic 404 errors (
f7677f5 
opensearch-project#3619)

Issue Resolved:
opensearch-project#3618

Signed-off-by: Anan Zhuang <[email protected]>
Signed-off-by: David Sinclair <[email protected]>
sikhote pushed a commit to sikhote/OpenSearch-Dashboards that referenced this pull request Apr 24, 2023
@kappassov @ananzh
@AMoo-Miki @zhongnansu @sikhote
[CCI] Adding second command to Install yarn step in Developer Guide (o…
5c7953a 
…pensearch-project#3633)

* added prepare command

Signed-off-by: kappassov <[email protected]>

* Use mirrors to download Node.js binaries to escape sporadic 404 errors (opensearch-project#3619)

Issue Resolved:
opensearch-project#3618

Signed-off-by: Anan Zhuang <[email protected]>

* Allow selecting the Node.js binary OSD uses (opensearch-project#3508)

New reusable use_node scripts take care of selecting the correct Node.js binary based OSD_NODE_HOME, OSD_HOME, and whatever is in the PATH. It also takes care of finding the binary on FreeBSD.
* The startup scripts check `OSD_NODE_HOME` and `NODE_HOME` before falling back to use the bundled or system-wide Node.js binary.
* Update `package.json` to replace `node` with `use_node`.
* Update file templates and shell scripts to internally use `use_node`.
* Update the build scripts to copy `use_node` into releases
* Make tests that execute node internally, honor the binary being used.

Signed-off-by: Miki <[email protected]>

* Clean up and rebuild @osd/pm (opensearch-project#3570)

* Fix the build failures
* Removed some unused packages
* Update gist url templates in Lychee's exclusion list

Signed-off-by: Miki <[email protected]>

* Refactor dev tool console to use opensearch-js client to send request (opensearch-project#3544)

Refactor dev tool console to use opensearch-js client to interact with OpenSearch

Signed-off-by: Su <[email protected]>

* updates after the 1st review

Signed-off-by: kappassov <[email protected]>

---------

Signed-off-by: kappassov <[email protected]>
Signed-off-by: Anan Zhuang <[email protected]>
Signed-off-by: Miki <[email protected]>
Signed-off-by: Su <[email protected]>
Co-authored-by: Anan Zhuang <[email protected]>
Co-authored-by: Miki <[email protected]>
Co-authored-by: Zhongnan Su <[email protected]>
Signed-off-by: David Sinclair <[email protected]>
sikhote pushed a commit to sikhote/OpenSearch-Dashboards that referenced this pull request Apr 24, 2023
@ananzh @sikhote
Use mirrors to download Node.js binaries to escape sporadic 404 errors (
c6dd84a 
opensearch-project#3619)

Issue Resolved:
opensearch-project#3618

Signed-off-by: Anan Zhuang <[email protected]>
Signed-off-by: David Sinclair <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AMoo-Miki AMoo-Miki AMoo-Miki approved these changes

@abbyhu2000 abbyhu2000 abbyhu2000 approved these changes

Assignees

@ananzh ananzh

Labels
backport 2.x v2.7.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

node.js 14.21.3 download is not stable and raise 404 error
6 participants
@ananzh @kavilla @peterzhuamazon @joshuarrrr @AMoo-Miki @abbyhu2000