Skip to content

Commit

Permalink
Use mirrors to download Node.js binaries to escape sporadic 404 errors (
Browse files Browse the repository at this point in the history
#3619)

Issue Resolved:
#3618

Signed-off-by: Anan Zhuang <ananzh@amazon.com>
ananzh authored Mar 20, 2023

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
1 parent c9211b9 commit 99a88e3
Showing 2 changed files with 2 additions and 1 deletion.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -67,6 +67,7 @@ Inspired from [Keep a Changelog](https://keepachangelog.com/en/1.0.0/)
- [Multiple DataSource] Refactor test connection to support SigV4 auth type ([#3456](https://github.com/opensearch-project/OpenSearch-Dashboards/issues/3456))
- [Darwin] Add support for Darwin for running OpenSearch snapshots with `yarn opensearch snapshot` ([#3537](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/3537))
- [Vis Builder] Add metric to metric, bucket to bucket aggregation persistence ([#3495](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/3495))
- Use mirrors to download Node.js binaries to escape sporadic 404 errors ([#3619](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/3619))

### 🐛 Bug Fixes

2 changes: 1 addition & 1 deletion src/dev/build/tasks/nodejs/node_download_info.ts
Original file line number Diff line number Diff line change
@@ -44,7 +44,7 @@ export async function getNodeDownloadInfo(config: Config, platform: Platform) {
? `node-v${version}-win-x64.zip`
: `node-v${version}-${arch}.tar.gz`;

const url = `https://nodejs.org/dist/v${version}/${downloadName}`;
const url = `https://mirrors.nodejs.org/dist/v${version}/${downloadName}`;
const downloadPath = config.resolveFromRepo('.node_binaries', version, basename(downloadName));
const extractDir = config.resolveFromRepo('.node_binaries', version, arch);

0 comments on commit 99a88e3

Please sign in to comment.