Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PURIFY][BUILD] Removes most of x-pack references. #257

Merged
merged 2 commits into from
Apr 8, 2021

Conversation

mihirsoni
Copy link
Contributor

Signed-off-by: Mihir Soni [email protected]

This PR removes 98% references of x-pack from the code base and its logic around that.

  • Remove any reference of x-pack
  • Deleted unused files for x-pack which are not relevant anymore.

@odfe-release-bot
Copy link

✅   DCO Check Passed 58e20d7

boktorbb
boktorbb previously approved these changes Apr 7, 2021
Copy link
Contributor

@boktorbb boktorbb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one small question

src/core/CONVENTIONS.md Outdated Show resolved Hide resolved
kavilla
kavilla previously approved these changes Apr 8, 2021
Copy link
Member

@kavilla kavilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm thank you!

@mihirsoni mihirsoni dismissed stale reviews from kavilla and boktorbb via 91b893d April 8, 2021 20:44
Copy link
Contributor

@boktorbb boktorbb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@odfe-release-bot
Copy link

✅   DCO Check Passed 91b893d

@kavilla kavilla self-requested a review April 8, 2021 21:08
@mihirsoni mihirsoni merged commit 85f13d3 into opensearch-project:main Apr 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants