Skip to content

Commit

Permalink
[PURIFY][BUILD] Addressed review comments
Browse files Browse the repository at this point in the history
Signed-off-by: Mihir Soni <[email protected]>
  • Loading branch information
mihirsoni committed Apr 8, 2021
1 parent 58e20d7 commit 91b893d
Showing 1 changed file with 2 additions and 3 deletions.
5 changes: 2 additions & 3 deletions src/core/CONVENTIONS.md
Original file line number Diff line number Diff line change
Expand Up @@ -19,9 +19,8 @@ Definition of done for a feature:
- has been verified manually by at least one reviewer
- can be used by first & third party plugins
- there is no contradiction between client and server API
- works for version
- works with and without a `server.basePath` configured
- cannot crash the OpenSearch Dashboards server when it fails
- works with and without a `server.basePath` configured
- cannot crash the OpenSearch Dashboards server when it fails
- has unit & integration tests for public contracts
- has functional tests for user scenarios
- uses standard tooling:
Expand Down

0 comments on commit 91b893d

Please sign in to comment.