[Rename] missed kibana references in project (#37) #183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bishoy Boktor <[email protected]>
|
✅ DCO Check Passed |
kavilla
approved these changes
Mar 18, 2021
| @@ -234,10 +234,10 @@ const MyApp = ({ basename }) => ( | |||
| // Setup router's basename from the basename provided from MountContext | |||
| <BrowserRouter basename={basename}> | |||
|
|
|||
| {/* mykibana.com/app/my-app/ */} | |||
| {/* myopensearchDashboards.com/app/my-app/ */} | |||
There was a problem hiding this comment.
i don't think this matters since it is force example purposes but should this be consistent with mykibana or even myopensearch-dashboards.com ?
kavilla
referenced
this pull request
in kavilla/OpenSearch-Dashboards
Mar 19, 2021
Signed-off-by: Bishoy Boktor <[email protected]>
kavilla
pushed a commit
that referenced
this pull request
Mar 20, 2021
Signed-off-by: Bishoy Boktor <[email protected]>
mihirsoni
pushed a commit
that referenced
this pull request
Mar 20, 2021
Signed-off-by: Bishoy Boktor <[email protected]>
wanglam
pushed a commit
to wanglam/OpenSearch-Dashboards
that referenced
this pull request
Sep 21, 2023
…nsearch-project#178) (opensearch-project#183) * feat: setup reserved workspaces when calling list workspaces API * feat: fix test flow * feat: fix lint * feat: fix typos * fix: setup personal workspace using correct id * refractor: move function getPrincipalsFromRequest to a util function * feat: change code according to comment * feat: modify reserved workspace permission --------- (cherry picked from commit 4bccdea) Signed-off-by: SuZhou-Joe <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Bishoy Boktor [email protected]