Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Updating Readme #178

Conversation

seanneumann
Copy link
Contributor

Updating the readme to be more Dashboards friendly.

@mihirsoni mihirsoni requested a review from kavilla March 17, 2021 21:10
Copy link
Contributor

@mihirsoni mihirsoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

@odfe-release-bot
Copy link

❌   DCO Check Failed
Run ./dev-tools/signoff-check.sh remotes/origin/dashboards 1dc8544d3fc9ce1dce9c646a9a187bb622a38fd7 to check locally
Use git commit with -s to add 'Signed-of-by: {EMAIL}' on impacted commits

Copy link
Member

@kavilla kavilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kavilla
Copy link
Member

kavilla commented Mar 17, 2021

Just need to sign the commit.

@mihirsoni
Copy link
Contributor

Closing this in favor of #195

@mihirsoni mihirsoni closed this Mar 19, 2021
Hailong-am pushed a commit to Hailong-am/OpenSearch-Dashboards that referenced this pull request Sep 20, 2023
…nsearch-project#178)

* feat: setup reserved workspaces when calling list workspaces API

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: fix test flow

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: fix lint

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: fix typos

Signed-off-by: SuZhou-Joe <[email protected]>

* fix: setup personal workspace using correct id

Signed-off-by: SuZhou-Joe <[email protected]>

* refractor: move function getPrincipalsFromRequest to a util function

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: change code according to comment

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: modify reserved workspace permission

Signed-off-by: SuZhou-Joe <[email protected]>

---------

Signed-off-by: SuZhou-Joe <[email protected]>
wanglam pushed a commit to wanglam/OpenSearch-Dashboards that referenced this pull request Sep 21, 2023
…nsearch-project#178) (opensearch-project#183)

* feat: setup reserved workspaces when calling list workspaces API



* feat: fix test flow



* feat: fix lint



* feat: fix typos



* fix: setup personal workspace using correct id



* refractor: move function getPrincipalsFromRequest to a util function



* feat: change code according to comment



* feat: modify reserved workspace permission



---------


(cherry picked from commit 4bccdea)

Signed-off-by: SuZhou-Joe <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants