-
Notifications
You must be signed in to change notification settings - Fork 916
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add updated_at column to objects' tables #1218
Merged
ashwin-pc
merged 9 commits into
opensearch-project:main
from
RoyiSitbon:AddUpdatedAtColumnToObjectsTables
Sep 20, 2022
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
0dd070a
Add updated_at columnb to objects' tables
RoyiSitbon 1e14eaa
Grammer and iso usage
RoyiSitbon ea81490
Set updated at field from advanced settings
RoyiSitbon 49523a3
Use dateFormat instead of dateFormat:scaled
RoyiSitbon 3c54667
snapshot
RoyiSitbon 0d182a3
Add updated_at to additional comment
RoyiSitbon 0641af3
Add unit-tests for updated_at as null undefined or unknown
RoyiSitbon dce8b05
Simplify test file
RoyiSitbon 87e49ed
Simplified header and import from src
RoyiSitbon File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
138 changes: 132 additions & 6 deletions
138
...plugins/dashboard/public/application/listing/__snapshots__/dashboard_listing.test.js.snap
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
61 changes: 61 additions & 0 deletions
61
src/plugins/saved_objects/public/saved_object/saved_object_loader.test.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,61 @@ | ||
/* | ||
tmarkley marked this conversation as resolved.
Show resolved
Hide resolved
|
||
* Copyright OpenSearch Contributors | ||
* SPDX-License-Identifier: Apache-2.0 | ||
*/ | ||
|
||
import { SavedObjectsClientContract } from 'opensearch-dashboards/public'; | ||
import { SavedObjectLoader } from './saved_object_loader'; | ||
|
||
describe('SimpleSavedObjectLoader', () => { | ||
const createLoader = (updatedAt?: any) => { | ||
const id = 'logstash-*'; | ||
const type = 'index-pattern'; | ||
|
||
const savedObject = { | ||
attributes: {}, | ||
id, | ||
type, | ||
updated_at: updatedAt as any, | ||
}; | ||
|
||
client = { | ||
...client, | ||
find: jest.fn(() => | ||
Promise.resolve({ | ||
total: 1, | ||
savedObjects: [savedObject], | ||
}) | ||
), | ||
} as any; | ||
|
||
return new SavedObjectLoader(savedObject, client); | ||
}; | ||
|
||
let client: SavedObjectsClientContract; | ||
let loader: SavedObjectLoader; | ||
beforeEach(() => { | ||
client = { | ||
update: jest.fn(), | ||
create: jest.fn(), | ||
delete: jest.fn(), | ||
} as any; | ||
}); | ||
|
||
afterEach(async () => { | ||
const savedObjects = await loader.findAll(); | ||
|
||
expect(savedObjects.hits[0].updated_at).toEqual(undefined); | ||
}); | ||
|
||
it('set updated_at as undefined if undefined', async () => { | ||
loader = createLoader(undefined); | ||
}); | ||
|
||
it("set updated_at as undefined if doesn't exist", async () => { | ||
loader = createLoader(); | ||
}); | ||
|
||
it('set updated_at as undefined if null', async () => { | ||
loader = createLoader(null); | ||
}); | ||
}); |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why does it need to be
updated_at
instead ofupdatedAt
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thats the OpenSearch response. Don't think we can change that.