Add updated_at column to objects' tables #1218

RoyiSitbon · 2022-02-07T08:36:31Z

Signed-off-by: sitbubu [email protected]

Is your feature request related to a problem? Please describe.
We want to see more informative data inside the saved objects' tables,
one important column that answers our needs will be the “updated at” option.
After adding this option we will gain an additional advantage, i.e sort our objects by date.

Describe the solution you'd like to
We wish to add an additional “updated at” column to our management, visualizations, and dashboards tables. e.g. for the management table, we will define:

and then we will be able to see an additional column, like so:

The same solution will be implemented under the visualizations and dashboards tables, besides the fact that we will need to set our updated_at property inside the attributes prop since it uses us as the rendered object info for these tables.

Linked issue:
#1217

tmarkley

Thanks for the changes! I believe this field uses the ISO 8601 string format YYYY-MM-DDTHH:mm:ss.sssZ, so we should keep that consistent. And I know we can't change the field name, but when we render it I think it would look better to use a noun instead of including the at proposition (i.e. Updated Time instead of Updated at).

src/plugins/dashboard/public/application/listing/dashboard_listing.js

src/core/public/saved_objects/saved_objects_client.test.ts

...lugins/saved_objects_management/public/management_section/objects_table/components/table.tsx

kgcreative · 2022-02-07T18:54:32Z

There is an advanced setting in stack management that determines the date format of how dates should be pretty printed. We should be using that to format the date/time display.

RoyiSitbon · 2022-02-14T10:07:28Z

Thanks for the changes! I believe this field uses the ISO 8601 string format YYYY-MM-DDTHH:mm:ss.sssZ, so we should keep that consistent. And I know we can't change the field name, but when we render it I think it would look better to use a noun instead of including the at proposition (i.e. Updated Time instead of Updated at).

thanks, changed as requested

RoyiSitbon · 2022-03-01T06:40:14Z

Thanks for the changes! I believe this field uses the ISO 8601 string format YYYY-MM-DDTHH:mm:ss.sssZ, so we should keep that consistent. And I know we can't change the field name, but when we render it I think it would look better to use a noun instead of including the at proposition (i.e. Updated Time instead of Updated at).

Hey, all changes have been made inside this pr.
Thanks

src/plugins/visualize/public/application/utils/get_table_columns.tsx

src/plugins/dashboard/public/application/listing/dashboard_listing.js

kavilla

Blocking to ensure stability for 2.0.0-rc1

No need to block for RC1 any longer.

tmarkley · 2022-05-09T16:12:59Z

Hi @RoyiSitbon, do you need any additional questions answered for this PR?

RoyiSitbon · 2022-05-13T06:31:57Z

Hi @RoyiSitbon, do you need any additional questions answered for this PR?

Hey @tmarkley, thanks for checking. I replied above.

codecov-commenter · 2022-05-13T15:32:36Z

Codecov Report

Merging #1218 (7580cec) into main (b5d529a) will increase coverage by 0.02%.
The diff coverage is 60.00%.

@@            Coverage Diff             @@
##             main    #1218      +/-   ##
==========================================
+ Coverage   66.55%   66.57%   +0.02%     
==========================================
  Files        3170     3170              
  Lines       60321    60326       +5     
  Branches     9181     9182       +1     
==========================================
+ Hits        40144    40162      +18     
+ Misses      17984    17969      -15     
- Partials     2193     2195       +2

Impacted Files	Coverage Δ
...agement_section/objects_table/components/table.tsx	`65.51% <0.00%> (-1.15%)`	⬇️
...ment_section/objects_table/saved_objects_table.tsx	`73.48% <ø> (ø)`
...rd/public/application/listing/dashboard_listing.js	`78.57% <50.00%> (-4.77%)`	⬇️
...c/core/public/saved_objects/simple_saved_object.ts	`56.25% <100.00%> (+2.91%)`	⬆️
...objects/public/saved_object/saved_object_loader.ts	`53.84% <100.00%> (+53.84%)`	⬆️
...ared/static/forms/hook_form_lib/hooks/use_field.ts	`66.66% <0.00%> (+0.96%)`	⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

tmarkley

Thanks for these improvements @RoyiSitbon! The code is clean and maintainable, that's much appreciated.

I think the last thing that would put the cherry on top is adding some additional unit tests as well as functional tests for this feature.

src/plugins/visualize/public/application/utils/get_table_columns.tsx

src/plugins/saved_objects/public/saved_object/saved_object_loader.ts

src/plugins/saved_objects/public/saved_object/saved_object_loader.test.ts

src/plugins/visualize/public/application/utils/get_table_columns.tsx

tmarkley

LGTM! Thank you for the improvements!

kavilla · 2022-08-09T19:28:13Z

Hello @RoyiSitbon,
Will pull this down! Quick question will this require a migration on existing documents?

Hey @kavilla , yes pls. not requires a migration, unless we will want to ascertain the existence of these metaFields. Nothing will go wrong even without migration attach(also validated using tests as expected).

Thanks a lot

Great then I think we can target to get this in to 2.3! Thank you so much @RoyiSitbon

ashwin-pc

I've validated this locally and the change looks good! Glad that you exposed the updated_at a global level so that every saved object type can utilize it. Sorry that this got sidetracked.

RoyiSitbon · 2022-09-18T04:29:37Z

I've validated this locally and the change looks good! Glad that you exposed the updated_at a global level so that every saved object type can utilize it. Sorry that this got sidetracked.

🙏

Signed-off-by: sitbubu <[email protected]>

joshuarrrr

Looks great, I'm excited for this improvement!

joshuarrrr · 2022-09-20T18:29:15Z

src/core/public/saved_objects/simple_saved_object.ts

+      // eslint-disable-next-line @typescript-eslint/naming-convention
+      updated_at,


Why does it need to be updated_at instead of updatedAt?

Thats the OpenSearch response. Don't think we can change that.

src/plugins/saved_objects/public/saved_object/saved_object_loader.ts

* Add updated_at columnb to objects' tables Signed-off-by: sitbubu <[email protected]> * Grammer and iso usage Signed-off-by: sitbubu <[email protected]> * Set updated at field from advanced settings Signed-off-by: sitbubu <[email protected]> * Use dateFormat instead of dateFormat:scaled Signed-off-by: sitbubu <[email protected]> * snapshot Signed-off-by: sitbubu <[email protected]> * Add updated_at to additional comment Signed-off-by: sitbubu <[email protected]> * Add unit-tests for updated_at as null undefined or unknown Signed-off-by: sitbubu <[email protected]> * Simplify test file Signed-off-by: sitbubu <[email protected]> * Simplified header and import from src Signed-off-by: sitbubu <[email protected]> Signed-off-by: sitbubu <[email protected]> (cherry picked from commit 8874afd)

* Add updated_at columnb to objects' tables Signed-off-by: sitbubu <[email protected]> * Grammer and iso usage Signed-off-by: sitbubu <[email protected]> * Set updated at field from advanced settings Signed-off-by: sitbubu <[email protected]> * Use dateFormat instead of dateFormat:scaled Signed-off-by: sitbubu <[email protected]> * snapshot Signed-off-by: sitbubu <[email protected]> * Add updated_at to additional comment Signed-off-by: sitbubu <[email protected]> * Add unit-tests for updated_at as null undefined or unknown Signed-off-by: sitbubu <[email protected]> * Simplify test file Signed-off-by: sitbubu <[email protected]> * Simplified header and import from src Signed-off-by: sitbubu <[email protected]> Signed-off-by: sitbubu <[email protected]> (cherry picked from commit 8874afd) Co-authored-by: Royi Sitbon <[email protected]>

seanneumann · 2022-09-27T19:48:50Z

Nice!

* Add updated_at columnb to objects' tables Signed-off-by: sitbubu <[email protected]> * Grammer and iso usage Signed-off-by: sitbubu <[email protected]> * Set updated at field from advanced settings Signed-off-by: sitbubu <[email protected]> * Use dateFormat instead of dateFormat:scaled Signed-off-by: sitbubu <[email protected]> * snapshot Signed-off-by: sitbubu <[email protected]> * Add updated_at to additional comment Signed-off-by: sitbubu <[email protected]> * Add unit-tests for updated_at as null undefined or unknown Signed-off-by: sitbubu <[email protected]> * Simplify test file Signed-off-by: sitbubu <[email protected]> * Simplified header and import from src Signed-off-by: sitbubu <[email protected]> Signed-off-by: sitbubu <[email protected]> Signed-off-by: Sergey V. Osipov <[email protected]>

RoyiSitbon requested a review from a team as a code owner February 7, 2022 08:36

tmarkley suggested changes Feb 7, 2022

View reviewed changes

kavilla linked an issue Feb 8, 2022 that may be closed by this pull request

Updated at column in saved objects' tables #1217

Closed

RoyiSitbon requested review from kgcreative and tmarkley February 13, 2022 13:14

RoyiSitbon force-pushed the AddUpdatedAtColumnToObjectsTables branch from 7e81f6c to 476d1da Compare March 2, 2022 06:46

tmarkley self-assigned this Mar 15, 2022

tmarkley suggested changes Mar 22, 2022

View reviewed changes

src/plugins/visualize/public/application/utils/get_table_columns.tsx Outdated Show resolved Hide resolved

src/plugins/dashboard/public/application/listing/dashboard_listing.js Outdated Show resolved Hide resolved

RoyiSitbon requested a review from tmarkley April 4, 2022 08:57

kavilla previously requested changes Apr 14, 2022

View reviewed changes

RoyiSitbon force-pushed the AddUpdatedAtColumnToObjectsTables branch from 476d1da to 61116c6 Compare May 13, 2022 11:32

RoyiSitbon requested a review from kavilla May 13, 2022 11:33

RoyiSitbon force-pushed the AddUpdatedAtColumnToObjectsTables branch 2 times, most recently from 88e68c4 to 05da790 Compare May 13, 2022 14:52

tmarkley reviewed May 24, 2022

View reviewed changes

RoyiSitbon requested a review from tmarkley June 9, 2022 13:54

tmarkley reviewed Jun 13, 2022

View reviewed changes

src/plugins/saved_objects/public/saved_object/saved_object_loader.test.ts Show resolved Hide resolved

src/plugins/visualize/public/application/utils/get_table_columns.tsx Outdated Show resolved Hide resolved

RoyiSitbon force-pushed the AddUpdatedAtColumnToObjectsTables branch from 5d60051 to 46f7e13 Compare June 20, 2022 06:33

RoyiSitbon requested a review from tmarkley June 20, 2022 06:34

kavilla assigned tmarkley and unassigned tmarkley Jun 20, 2022

joshuarrrr force-pushed the AddUpdatedAtColumnToObjectsTables branch from 46f7e13 to d5ba653 Compare June 22, 2022 19:06

tmarkley previously approved these changes Jun 27, 2022

View reviewed changes

kavilla added v2.3.0 and removed v2.2.0 labels Aug 9, 2022

kavilla added v2.4.0 'Issues and PRs related to version v2.4.0' and removed v2.3.0 labels Sep 12, 2022

kavilla assigned ashwin-pc Sep 16, 2022

ashwin-pc previously approved these changes Sep 17, 2022

View reviewed changes

RoyiSitbon added 9 commits September 18, 2022 07:43

Add updated_at columnb to objects' tables

0dd070a

Signed-off-by: sitbubu <[email protected]>

Grammer and iso usage

1e14eaa

Signed-off-by: sitbubu <[email protected]>

Set updated at field from advanced settings

ea81490

Signed-off-by: sitbubu <[email protected]>

Use dateFormat instead of dateFormat:scaled

49523a3

Signed-off-by: sitbubu <[email protected]>

snapshot

3c54667

Signed-off-by: sitbubu <[email protected]>

Add updated_at to additional comment

0d182a3

Signed-off-by: sitbubu <[email protected]>

Add unit-tests for updated_at as null undefined or unknown

0641af3

Signed-off-by: sitbubu <[email protected]>

Simplify test file

dce8b05

Signed-off-by: sitbubu <[email protected]>

Simplified header and import from src

87e49ed

Signed-off-by: sitbubu <[email protected]>

RoyiSitbon dismissed stale reviews from ashwin-pc and tmarkley via 87e49ed September 18, 2022 04:43

RoyiSitbon force-pushed the AddUpdatedAtColumnToObjectsTables branch from 7580cec to 87e49ed Compare September 18, 2022 04:43

ashwin-pc approved these changes Sep 19, 2022

View reviewed changes

joshuarrrr approved these changes Sep 20, 2022

View reviewed changes

ashwin-pc merged commit 8874afd into opensearch-project:main Sep 20, 2022

opensearch-trigger-bot bot mentioned this pull request Sep 20, 2022

[Backport 2.x] Add updated_at column to objects' tables #2392

Merged

ashwin-pc mentioned this pull request Oct 25, 2022

[BUG] Object tables with updated_at takes up too much space #2663

Open

AMoo-Miki added the enhancement New feature or request label Nov 5, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add updated_at column to objects' tables #1218

Add updated_at column to objects' tables #1218

RoyiSitbon commented Feb 7, 2022 •

edited

Loading

tmarkley left a comment

kgcreative commented Feb 7, 2022

RoyiSitbon commented Feb 14, 2022

RoyiSitbon commented Mar 1, 2022

kavilla left a comment

tmarkley commented May 9, 2022

RoyiSitbon commented May 13, 2022

codecov-commenter commented May 13, 2022 •

edited

Loading

tmarkley left a comment

tmarkley left a comment

kavilla commented Aug 9, 2022

ashwin-pc left a comment •

edited

Loading

RoyiSitbon commented Sep 18, 2022

joshuarrrr left a comment

joshuarrrr Sep 20, 2022

ashwin-pc Sep 20, 2022

seanneumann commented Sep 27, 2022

		// eslint-disable-next-line @typescript-eslint/naming-convention
		updated_at,

Add updated_at column to objects' tables #1218

Add updated_at column to objects' tables #1218

Conversation

RoyiSitbon commented Feb 7, 2022 • edited Loading

tmarkley left a comment

Choose a reason for hiding this comment

kgcreative commented Feb 7, 2022

RoyiSitbon commented Feb 14, 2022

RoyiSitbon commented Mar 1, 2022

kavilla left a comment

Choose a reason for hiding this comment

tmarkley commented May 9, 2022

RoyiSitbon commented May 13, 2022

codecov-commenter commented May 13, 2022 • edited Loading

Codecov Report

tmarkley left a comment

Choose a reason for hiding this comment

tmarkley left a comment

Choose a reason for hiding this comment

kavilla commented Aug 9, 2022

ashwin-pc left a comment • edited Loading

Choose a reason for hiding this comment

RoyiSitbon commented Sep 18, 2022

joshuarrrr left a comment

Choose a reason for hiding this comment

joshuarrrr Sep 20, 2022

Choose a reason for hiding this comment

ashwin-pc Sep 20, 2022

Choose a reason for hiding this comment

seanneumann commented Sep 27, 2022

RoyiSitbon commented Feb 7, 2022 •

edited

Loading

codecov-commenter commented May 13, 2022 •

edited

Loading

ashwin-pc left a comment •

edited

Loading