[BUG][VisBuilder] Updated filter and query are not savable #5645
Labels
Comments
ananzh
added
bug
This was referenced Apr 11, 2024
ananzh
added a commit
to ananzh/OpenSearch-Dashboards
that referenced
this issue
Apr 17, 2024
In this PR: add filter and query in vb remove saveDisabledReason clean filterManager when start vb add opensearch_dashboards_context to embeddable. This can add filter and query in the expression. Issue Resolve opensearch-project#5643 opensearch-project#5644 opensearch-project#5645 opensearch-project#5646 opensearch-project#6512 Signed-off-by: Anan Zhuang <[email protected]>
ananzh
added a commit
to ananzh/OpenSearch-Dashboards
that referenced
this issue
Apr 17, 2024
In this PR: add filter and query in vb remove saveDisabledReason clean filterManager when start vb add opensearch_dashboards_context to embeddable. This can add filter and query in the expression. Issue Resolve opensearch-project#5643 opensearch-project#5644 opensearch-project#5645 opensearch-project#5646 opensearch-project#6512 Signed-off-by: Anan Zhuang <[email protected]>
ananzh
added a commit
to ananzh/OpenSearch-Dashboards
that referenced
this issue
Apr 17, 2024
In this PR: add filter and query in vb remove saveDisabledReason clean filterManager when start vb add opensearch_dashboards_context to embeddable. This can add filter and query in the expression. Issue Resolve opensearch-project#5643 opensearch-project#5644 opensearch-project#5645 opensearch-project#5646 opensearch-project#6512 Signed-off-by: Anan Zhuang <[email protected]>
ananzh
added a commit
to ananzh/OpenSearch-Dashboards
that referenced
this issue
Apr 17, 2024
In this PR: add filter and query in vb remove saveDisabledReason clean filterManager when start vb add opensearch_dashboards_context to embeddable. This can add filter and query in the expression. Issue Resolve opensearch-project#5643 opensearch-project#5644 opensearch-project#5645 opensearch-project#5646 opensearch-project#6512 Signed-off-by: Anan Zhuang <[email protected]>
ananzh
added a commit
to ananzh/OpenSearch-Dashboards
that referenced
this issue
Apr 18, 2024
In this PR: add filter and query in vb remove saveDisabledReason clean filterManager when start vb add opensearch_dashboards_context to embeddable. This can add filter and query in the expression. Issue Resolve opensearch-project#5643 opensearch-project#5644 opensearch-project#5645 opensearch-project#5646 opensearch-project#6512 Signed-off-by: Anan Zhuang <[email protected]>
ananzh
added a commit
to ananzh/OpenSearch-Dashboards
that referenced
this issue
Apr 18, 2024
In this PR: add filter and query in vb remove saveDisabledReason clean filterManager when start vb add opensearch_dashboards_context to embeddable. This can add filter and query in the expression. Issue Resolve opensearch-project#5643 opensearch-project#5644 opensearch-project#5645 opensearch-project#5646 opensearch-project#6512 Signed-off-by: Anan Zhuang <[email protected]>
ananzh
added a commit
to ananzh/OpenSearch-Dashboards
that referenced
this issue
Apr 25, 2024
Before this PR, can't save when filter or query change. After this PR, if the canvas is not empty, can save filter and query updates. Issue Resolve opensearch-project#5645 Signed-off-by: Anan Zhuang <[email protected]>
This was referenced Apr 25, 2024
ananzh
added a commit
to ananzh/OpenSearch-Dashboards
that referenced
this issue
Apr 25, 2024
Before this PR, can't save when filter or query change. After this PR, if the canvas is not empty, can save filter and query updates. Issue Resolve opensearch-project#5645 Signed-off-by: Anan Zhuang <[email protected]>
ananzh
added a commit
to ananzh/OpenSearch-Dashboards
that referenced
this issue
Apr 25, 2024
Before this PR, can't save when filter or query change. After this PR, if the canvas is not empty, can save filter and query updates. Issue Resolve opensearch-project#5645 Signed-off-by: Anan Zhuang <[email protected]>
opensearch-trigger-bot bot
pushed a commit
that referenced
this issue
Apr 30, 2024
Before this PR, can't save when filter or query change. After this PR, if the canvas is not empty, can save filter and query updates. Issue Resolve #5645 Signed-off-by: Anan Zhuang <[email protected]> (cherry picked from commit 7aa7a74) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
ananzh
pushed a commit
that referenced
this issue
Apr 30, 2024
…6687) Before this PR, can't save when filter or query change. After this PR, if the canvas is not empty, can save filter and query updates. Issue Resolve #5645 (cherry picked from commit 7aa7a74) Signed-off-by: Anan Zhuang <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
LDrago27
pushed a commit
to LDrago27/OpenSearch-Dashboards
that referenced
this issue
Jun 3, 2024
…rch-project#6636) Before this PR, can't save when filter or query change. After this PR, if the canvas is not empty, can save filter and query updates. Issue Resolve opensearch-project#5645 Signed-off-by: Anan Zhuang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
If update a new filter or query, the saved button is not clickable. Therefore they are not savable. This is not the same behavior as other visualization. In other vis,
savebutton is always clickable.To Reproduce
can.t.save.filter.and.query.mov
Expected behavior
savebutton should be always clickable.OpenSearch Version
2.10
Dashboards Version
2.10
The text was updated successfully, but these errors were encountered: