-
Notifications
You must be signed in to change notification settings - Fork 919
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG][VisBuilder] Filter state is not cleaned when change to vis builder #5644
Labels
Comments
This was referenced Apr 11, 2024
ananzh
added a commit
to ananzh/OpenSearch-Dashboards
that referenced
this issue
Apr 17, 2024
In this PR: add filter and query in vb remove saveDisabledReason clean filterManager when start vb add opensearch_dashboards_context to embeddable. This can add filter and query in the expression. Issue Resolve opensearch-project#5643 opensearch-project#5644 opensearch-project#5645 opensearch-project#5646 opensearch-project#6512 Signed-off-by: Anan Zhuang <[email protected]>
ananzh
added a commit
to ananzh/OpenSearch-Dashboards
that referenced
this issue
Apr 17, 2024
In this PR: add filter and query in vb remove saveDisabledReason clean filterManager when start vb add opensearch_dashboards_context to embeddable. This can add filter and query in the expression. Issue Resolve opensearch-project#5643 opensearch-project#5644 opensearch-project#5645 opensearch-project#5646 opensearch-project#6512 Signed-off-by: Anan Zhuang <[email protected]>
ananzh
added a commit
to ananzh/OpenSearch-Dashboards
that referenced
this issue
Apr 17, 2024
In this PR: add filter and query in vb remove saveDisabledReason clean filterManager when start vb add opensearch_dashboards_context to embeddable. This can add filter and query in the expression. Issue Resolve opensearch-project#5643 opensearch-project#5644 opensearch-project#5645 opensearch-project#5646 opensearch-project#6512 Signed-off-by: Anan Zhuang <[email protected]>
ananzh
added a commit
to ananzh/OpenSearch-Dashboards
that referenced
this issue
Apr 17, 2024
In this PR: add filter and query in vb remove saveDisabledReason clean filterManager when start vb add opensearch_dashboards_context to embeddable. This can add filter and query in the expression. Issue Resolve opensearch-project#5643 opensearch-project#5644 opensearch-project#5645 opensearch-project#5646 opensearch-project#6512 Signed-off-by: Anan Zhuang <[email protected]>
ananzh
changed the title
[BUG][VisBuilder] Missing saved query
[BUG][VisBuilder] Filter state is not cleaned when change to vis builder
Apr 17, 2024
ananzh
added a commit
to ananzh/OpenSearch-Dashboards
that referenced
this issue
Apr 18, 2024
In this PR: add filter and query in vb remove saveDisabledReason clean filterManager when start vb add opensearch_dashboards_context to embeddable. This can add filter and query in the expression. Issue Resolve opensearch-project#5643 opensearch-project#5644 opensearch-project#5645 opensearch-project#5646 opensearch-project#6512 Signed-off-by: Anan Zhuang <[email protected]>
ananzh
added a commit
to ananzh/OpenSearch-Dashboards
that referenced
this issue
Apr 18, 2024
In this PR: add filter and query in vb remove saveDisabledReason clean filterManager when start vb add opensearch_dashboards_context to embeddable. This can add filter and query in the expression. Issue Resolve opensearch-project#5643 opensearch-project#5644 opensearch-project#5645 opensearch-project#5646 opensearch-project#6512 Signed-off-by: Anan Zhuang <[email protected]>
ananzh
added a commit
to ananzh/OpenSearch-Dashboards
that referenced
this issue
Apr 25, 2024
In this PR: add filter and query in vb clean filterManager when start vb add opensearch_dashboards_context to embeddable. This can add filter and query in the expression. Issue Resolve opensearch-project#5643 opensearch-project#5644 opensearch-project#5646 opensearch-project#6512 Signed-off-by: Anan Zhuang <[email protected]>
4 tasks
ananzh
added a commit
to ananzh/OpenSearch-Dashboards
that referenced
this issue
Apr 29, 2024
In this PR: add filter and query in vb clean filterManager when start vb add opensearch_dashboards_context to embeddable. This can add filter and query in the expression. Issue Resolve opensearch-project#5643 opensearch-project#5644 opensearch-project#5646 opensearch-project#6512 Signed-off-by: Anan Zhuang <[email protected]>
ananzh
added a commit
to ananzh/OpenSearch-Dashboards
that referenced
this issue
Apr 29, 2024
In this PR: add filter and query in vb clean filterManager when start vb add opensearch_dashboards_context to embeddable. This can add filter and query in the expression. Issue Resolve opensearch-project#5643 opensearch-project#5644 opensearch-project#5646 opensearch-project#6512 Signed-off-by: Anan Zhuang <[email protected]>
ananzh
added a commit
to ananzh/OpenSearch-Dashboards
that referenced
this issue
Apr 29, 2024
In this PR: add filter and query in vb clean filterManager when start vb add opensearch_dashboards_context to embeddable. This can add filter and query in the expression. Issue Resolve opensearch-project#5643 opensearch-project#5644 opensearch-project#5646 opensearch-project#6512 Signed-off-by: Anan Zhuang <[email protected]>
ananzh
added a commit
to ananzh/OpenSearch-Dashboards
that referenced
this issue
Apr 29, 2024
In this PR: add filter and query in vb clean filterManager when start vb add opensearch_dashboards_context to embeddable. This can add filter and query in the expression. Issue Resolve opensearch-project#5643 opensearch-project#5644 opensearch-project#5646 opensearch-project#6512 Signed-off-by: Anan Zhuang <[email protected]>
ananzh
added a commit
to ananzh/OpenSearch-Dashboards
that referenced
this issue
Apr 30, 2024
In this PR: add filter and query in vb clean filterManager when start vb add opensearch_dashboards_context to embeddable. This can add filter and query in the expression. Issue Resolve opensearch-project#5643 opensearch-project#5644 opensearch-project#5646 opensearch-project#6512 Signed-off-by: Anan Zhuang <[email protected]>
ananzh
added a commit
that referenced
this issue
Apr 30, 2024
* [VisBuilder] Fix filter and query bugs In this PR: add filter and query in vb clean filterManager when start vb add opensearch_dashboards_context to embeddable. This can add filter and query in the expression. Issue Resolve #5643 #5644 #5646 #6512 Signed-off-by: Anan Zhuang <[email protected]> --------- Signed-off-by: Anan Zhuang <[email protected]> Co-authored-by: Miki <[email protected]>
opensearch-trigger-bot bot
pushed a commit
that referenced
this issue
Apr 30, 2024
* [VisBuilder] Fix filter and query bugs In this PR: add filter and query in vb clean filterManager when start vb add opensearch_dashboards_context to embeddable. This can add filter and query in the expression. Issue Resolve #5643 #5644 #5646 #6512 Signed-off-by: Anan Zhuang <[email protected]> --------- Signed-off-by: Anan Zhuang <[email protected]> Co-authored-by: Miki <[email protected]> (cherry picked from commit 0ac9db3) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md
ananzh
pushed a commit
that referenced
this issue
Apr 30, 2024
…6686) * [VisBuilder] Fix filter and query bugs In this PR: add filter and query in vb clean filterManager when start vb add opensearch_dashboards_context to embeddable. This can add filter and query in the expression. Issue Resolve #5643 #5644 #5646 #6512 Signed-off-by: Anan Zhuang <[email protected]> --------- Signed-off-by: Anan Zhuang <[email protected]> Co-authored-by: Miki <[email protected]> (cherry picked from commit 0ac9db3) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
LDrago27
pushed a commit
to LDrago27/OpenSearch-Dashboards
that referenced
this issue
Jun 3, 2024
…rch-project#6460) * [VisBuilder] Fix filter and query bugs In this PR: add filter and query in vb clean filterManager when start vb add opensearch_dashboards_context to embeddable. This can add filter and query in the expression. Issue Resolve opensearch-project#5643 opensearch-project#5644 opensearch-project#5646 opensearch-project#6512 Signed-off-by: Anan Zhuang <[email protected]> --------- Signed-off-by: Anan Zhuang <[email protected]> Co-authored-by: Miki <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
When reload a saved vis builder immediately after save, only see saved filter but not saved query. This is different from #5643, because we didn't load other app to flush out
_q
. This is not persistent compared to other visualization types. Also this is not because we could save the filter, it is due to the state is not cleaned.To Reproduce
miss.query.mov
Expected behavior
Proper saved query
OpenSearch Version
2.10
Dashboards Version
2.10
The text was updated successfully, but these errors were encountered: