Point to Airlock for viewing log outputs #4585
Conversation
|
Does RAP plan to link to Airlock from the |
|
We have mentioned in the past that we should remove the option to view L4 outputs from job-server - this is the reference to I think we can and should do that now, as we've now updated the docs to remove reference to viewing L4 files via job server. There should now be no reason for users to log into job-server on L4 (and theoretically we'll remove access to it at some point). Of course, that does mean that linking to the log file in Airlock from job-server is a bit pointless (or will be, if users aren't logging into it). Should we instead link to the docs on viewing outputs instead, with a note to find the file at I also opened this new ticket based on Simon's comment on the previous docs PR, and the extra "viewing output files" section could be a place to describe how to find log files in Airlock. |
|
I think direct link to Airlock from job-server is possibly confusing. It will resolve to the DNS/SSL holding page we use to generate certificates: https://tpp.backends.opensafely.org/ We are about to rip out the level 4 login, at which point, you can't even log in to job-server from level 4 to view this link in a context where it would correctly resolve to airlock. Maybe we should instead link to the "Logging in to airlock" docs? |
There's no point linking directly to the relevant Airlock URL because we don't expect users to be accessing Job Server from within Level 4 going forward, and even you have Airlock open in a VM you can't copy/paste URLs across. Instead we link to the Airlock docs and describe the location of the file. This replaces both the link the output viewer and the reference to the old "Level 4 file sync" directory. Previously we restricted these links to only show for the TPP backend, but on the assumption that we will be running an instance of Airlock for every backend I have removed this restriction.
evansd
force-pushed
the
evansd/replace-filesync-with-airlock
branch
from
b8d4cc8 to
438b49c
Compare
evansd
changed the title
There's no point linking directly to the relevant Airlock URL because we don't expect users to be accessing Job Server from within Level 4 going forward, and even you have Airlock open in a VM you can't copy/paste URLs across.
Instead we link to the Airlock docs and describe the location of the file. This replaces both the link the output viewer and the reference to the old "Level 4 file sync" directory.
Example:
Previously we restricted these links to only show for the TPP backend, but on the assumption that we will be running an instance of Airlock for every backend I have removed this restriction.
There's now a significant chunk of redundant code in Job Server relating to the "Level 4 files viewer". I'll make a separate ticket to track what needs removing here, and will tackle this in future PRs.
Closes #4583