Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused "Level 4 file viewer" code #4588

Closed
4 tasks
evansd opened this issue Sep 4, 2024 · 5 comments · Fixed by #4658
Closed
4 tasks

Remove unused "Level 4 file viewer" code #4588

evansd opened this issue Sep 4, 2024 · 5 comments · Fixed by #4658
Assignees

Comments

@evansd
Copy link
Contributor

evansd commented Sep 4, 2024

Previously, we had a system for viewing unreleased output files which involved users logging in to Job Server from within Level 4 (using a single-use token) and then using a "hybrid" JavaScript app which combined a remote UI with file data from a local API. This allowed viewing unreleased files without that data every leaving the secure environment.

Airlock replaces this wholesale by running the entire application within the secure environment.

This PR updated the UI to replace references to the old system with references to Airlock:

However it left in place of lot of now redundant code which should be cleaned up. A few examples are:

Note that the single-use token API endpoint needs to remain as this is used by Airlock. As therefore does the single-use token generator UI. It's just logging in to Job Server itself using the token which is no longer supported.

Note also the the file viewer SPA needs to remain for now as this is used for viewing released output files. Longer term there's an ambition to replace this with something simpler.

Related Slack thread:
https://bennettoxford.slack.com/archives/C069YDR4NCA/p1725463761914569

@iaindillingham
Copy link
Member

Thanks, @evansd. I think this is an issue for 🦖, so I've added it to the board. If you think differently, then let me know!

@evansd
Copy link
Contributor Author

evansd commented Sep 5, 2024

Ah, thanks @iaindillingham. You're absolutely right that this is natural 🦖 territory. I've just added a link to the associated Slack thread where we discussed this. Because I started pulling on this particular thread, and because it's motivated by Airlock, it's possible I'll take it on. Or some of it at least.

@inglesp
Copy link
Contributor

inglesp commented Sep 5, 2024

Will any documentation changes be required?

@lucyb
Copy link
Contributor

lucyb commented Sep 5, 2024

Will any documentation changes be required?

I expect any user-facing documentation will have been updated as part of the Airlock work. Although, that said, this page in the team manual should be updated, but as part of the Airlock work rather than this ticket.

Otherwise, I've had a look and I can't see any documentation that should be updated as part of this ticket.

@inglesp inglesp removed their assignment Sep 13, 2024
@lucyb
Copy link
Contributor

lucyb commented Sep 17, 2024

This ticket is likely to be tackled as part of this work, either way, it would be good for it to be updated as part of completing this ticket.

@inglesp inglesp self-assigned this Oct 8, 2024
StevenMaude added a commit that referenced this issue Oct 10, 2024
Fixes #4661.

These are no longer necessary following #4588.
StevenMaude added a commit that referenced this issue Oct 10, 2024
Fixes #4661.

These are no longer necessary following #4588.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants