Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update checkout action to v2 #735

Merged
merged 1 commit into from
Feb 7, 2022
Merged

fix: update checkout action to v2 #735

merged 1 commit into from
Feb 7, 2022

Conversation

rebkwok
Copy link
Contributor

@rebkwok rebkwok commented Feb 7, 2022

Fixes #698

Update checkout action to v2.

@@ -28,8 +28,9 @@ jobs:
outputs:
tag: ${{ steps.tag.outputs.new_version }}
steps:
- uses: actions/checkout@master
- uses: actions/checkout@v2
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the default branch on the actions/checkout repo is now main, @master was stuck back in July 2020.
According to this comment, it was because the current version at that time checked the code out without any history
#232 (comment)

Since we can do fetch-depth: 0 to get all history now, I think v2 should work for us.

@rebkwok rebkwok merged commit 60f470f into main Feb 7, 2022
@rebkwok rebkwok deleted the update-checkout-action branch February 7, 2022 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Security] Workflow build_and_publish.yaml is using vulnerable action actions/checkout
2 participants