Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version bumping not working #232

Closed
sebbacon opened this issue Jul 6, 2020 · 4 comments
Closed

Version bumping not working #232

sebbacon opened this issue Jul 6, 2020 · 4 comments

Comments

@sebbacon
Copy link
Contributor

sebbacon commented Jul 6, 2020

Despite #179 appearing to work when testing, releases are not being generated as expected.

Here is a run that does not consider this a release. This appears to be because the merge commit does not include the relevant conventional commit type - i.e. it only seems to be considering the merge commit.

image

However, the documentation makes it clear that:

The action will parse the new commits since the last tag using the semantic-release conventions

However, the last tag, v0.1.29, is at commit 49aadc2, since when there have been two commits starting fix:.

The command that the build linked to above runs is:

git log v0.1.29..HEAD --pretty=format:'%s%n%b|commit-hash:%h==============================================' --abbrev-commit

And its output on master for me is:

$ git log v0.1.29..HEAD --pretty=format:'%s%n%b|commit-hash:%h==============================================' --abbrev-commit
Merge pull request #231 from opensafely/test-release-making
Tweak docs and in doing so test release-making|commit-hash:99bb748==============================================
fix: remove broken reference to roadmap in docs
This is not really a `fix`, but I want to test triggering a new release.
|commit-hash:c9bb852==============================================
Merge pull request #230 from opensafely/semantic-autoversioning
fix: use semantic versioning automation|commit-hash:718d063==============================================
Merge branch 'master' into semantic-autoversioning
|commit-hash:74ff162==============================================
docs: bring description of release process up to date
|commit-hash:08b8304==============================================
fix: use semantic versioning automation
This is not really a fix, but we do want to trigger a new release.

Closes #179
|commit-hash:6581bf0==============================================

Given the run log ends

Tweak docs and in doing so test release-making
The commit should not trigger a release
Analysis of 1 commits complete: no release

It seems odd that it should consider an analysis of 1 commit to be complete.

@sebbacon
Copy link
Contributor Author

sebbacon commented Jul 6, 2020

@sebbacon
Copy link
Contributor Author

sebbacon commented Jul 6, 2020

I presume the bug is in this underlying library. I suspect this bug because our merge commits contain slashes.

@sebbacon
Copy link
Contributor Author

sebbacon commented Jul 7, 2020

The problem is that the current version of the checkout action checks the code out without any history (depth=1)

@inglesp
Copy link
Contributor

inglesp commented Jul 8, 2020

The problem is that the current version of the checkout action checks the code out without any history (depth=1)

Well done for getting to the bottom of that!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants