Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove ns-list workflows #208

Merged
merged 7 commits into from
Jul 24, 2023
Merged

remove ns-list workflows #208

merged 7 commits into from
Jul 24, 2023

Conversation

KaiWaldrant
Copy link
Member

@KaiWaldrant KaiWaldrant commented Jul 20, 2023

Describe your changes

resolve the integration test fail. Remove the ns-list action for the workflows directory. It does not exist.

Issue ticket number and link

Closes #xxxx (Replace xxxx with the GitHub issue number)

Checklist before requesting a review

  • I have performed a self-review of my code

  • Check the correct box. Does this PR contain:

    • Breaking changes
    • New functionality
    • Major changes
    • Minor changes
    • Bug fixes
  • Proposed changes are described in the CHANGELOG.md

  • CI Tests succeed and look good!

Copy link

@DriesSchaumont DriesSchaumont left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @KaiWaldrant, could you create an empty commit with the partial commit message 'ci force'? This way we should be able to check if the proposed changes work before moving to main.

@KaiWaldrant
Copy link
Member Author

the test fails are mitigated by PR #206

Copy link

@DriesSchaumont DriesSchaumont left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, seems like the workflow works!

@KaiWaldrant KaiWaldrant merged commit c7c4ab7 into main Jul 24, 2023
@KaiWaldrant KaiWaldrant deleted the fix/integration-test branch July 24, 2023 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants