View and controllers

[antopalidi]

fix #3

Refactored view:

[codecov-commenter]

Codecov Report

❗ No coverage uploaded for pull request base (develop@7719858). Click here to learn what that means.
Patch has no changes to coverable lines.

❗ Current head 88653b7 differs from pull request most recent head d92780b. Consider uploading reports for the commit d92780b to get more accurate results

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files

@@            Coverage Diff             @@
##             develop       #7   +/-   ##
==========================================
  Coverage           ?   89.64%           
==========================================
  Files              ?       90           
  Lines              ?     2289           
  Branches           ?        0           
==========================================
  Hits               ?     2052           
  Misses             ?      237           
  Partials           ?        0           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

[microstudi]

I think we are going to need to go step by step in the PR.

First', I'd apply my suggestion from the comment to draw the table in the index.html.erb file directly.
Then we can make helpers for each "tricky" thing we need to search.

For instance, we will need to define (probably in the configuration var) allow_admin_accountability which roles are we going to search for. For starters, we should use Decidim::ParticipatoryProcessUserRole, Decidim::AssemblyUserRole, and the others existing as defaults.

Then we can use PaperTrail capabilities to rebuild objects, we have two useful methods:

log.item => gets the existing object (this should be used in case of a "create" event).
log.reify => gets the "deleted" previous object (this should be used in case of a "deleted" event).

Then we can extract the name of the participatory space, for instance:

log.item.participatory_space

[microstudi]

Thanks @antopalidi this looks much better.

Couple of things:

To tidy up, I think it would be better to have a "presenter" class for the admin_action instead of different helpers in AdminActionsHelper.

This way in the controller could just pass the object presenter, ie:

def admin_action
  @admin_action ||= AdminActionPresenter.new(...paper_trail_object...)
end

Also, I see that we are showing the participatory space type, which is good, but we need to show the name of the space and a link to it.

[microstudi]

Thanks @antopalidi , overall is ok but we need to be a little bit more strict on some aspects.

We need to add tests for:

• PaperTrailVersion model
• PaperTrailRolerPresenter