Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup admin accountablity #6

Merged
merged 9 commits into from
Jan 16, 2023
Merged

Setup admin accountablity #6

merged 9 commits into from
Jan 16, 2023

Conversation

antopalidi
Copy link
Member

@antopalidi antopalidi commented Jan 13, 2023

#2
screen

Copy link

@microstudi microstudi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@antopalidi see some minor changes to this!

lib/decidim/decidim_awesome/admin_engine.rb Outdated Show resolved Hide resolved
lib/decidim/decidim_awesome/awesome.rb Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Jan 16, 2023

Codecov Report

❗ No coverage uploaded for pull request base (main@b0959f7). Click here to learn what that means.
Patch has no changes to coverable lines.

❗ Current head 3a2e91b differs from pull request most recent head 435d09f. Consider uploading reports for the commit 435d09f to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main       #6   +/-   ##
=======================================
  Coverage        ?   95.17%           
=======================================
  Files           ?       88           
  Lines           ?     2176           
  Branches        ?        0           
=======================================
  Hits            ?     2071           
  Misses          ?      105           
  Partials        ?        0           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@microstudi microstudi merged commit 743fc4f into main Jan 16, 2023
microstudi added a commit that referenced this pull request Jan 23, 2023
* New feature: customizable etiquette rules (#1)

* Add configuration options

* erb lint

* set validations

* fix summary test

* fixes specs

* fix config merger

* bump version. add docs

* Add gitpod config

* Bump decidim version

* Copy 0.26 view overrides to 0.27

* Update head and header template with 0.27

* Add rectify and downgrade virtus

* Add decidim_0.27 in gemfiles directory

* Add rectify to gemspec

* Try Rectify with :: because of prod problems

In production I got the error message:
uninitialized constant Decidim::DecidimAwesome::Rectify (NameError)

* Update Gemfile.lock with rectify

* Revert rectify namespace change

* Try again to add namespace info to Rectify

* Remove CookiesHelper

because it does not exist

* Setup admin accountablity (#6)

* add new section, add new controller, add view index

* add permissions to index action

* add rspec tests

* add var to config and rspec

* fix initializer

* fix lint

* fix permissions

* refactor permissions handling

* fix test

Co-authored-by: Ivan Vergés <[email protected]>

* remove rectify. fix some tests

* workflows

* remove appraisals

* fix 0.26 tests

* erblint

* fix test

* fix openstructs

* remove fail fast

* restore OpenStruct

* revert added symlink

* fix 26 tests

* fix javascript 27

* fix iframe test

* fix head tester

* fix css

* clean user tampering after middleware test

* Revert "Setup admin accountablity (#6)"

This reverts commit 743fc4f.

* fix copy

* simplify tests

* fix tests

* fix matrix

* add badges

Co-authored-by: Ivan Vergés <[email protected]>
Co-authored-by: Anna Topalidi <[email protected]>
microstudi added a commit that referenced this pull request Feb 23, 2023
* New feature: customizable etiquette rules (#1)

* Add configuration options

* erb lint

* set validations

* fix summary test

* fixes specs

* fix config merger

* bump version. add docs

* Setup admin accountablity (#6)

* add new section, add new controller, add view index

* add permissions to index action

* add rspec tests

* add var to config and rspec

* fix initializer

* fix lint

* fix permissions

* refactor permissions handling

* fix test

Co-authored-by: Ivan Vergés <[email protected]>

* View and controllers (#7)

* improve the controller and add a table to the view

* logs list

* add PaperTrail instead ActionLog

* add removal date to table

* change datetime format

* move remove instance var from helper

* add styles to table, add role

* add pagination

* fix pagination

* add rspec

* change controller

* change controller

* fix lint

* add rspec

* add participatory_space_type to table

* fix lint

* refactoring

* change method's name

* improve the controller and add a table to the view

* logs list

* add PaperTrail instead ActionLog

* add removal date to table

* change datetime format

* move remove instance var from helper

* add styles to table, add role

* add pagination

* fix pagination

* add rspec

* change controller

* change controller

* fix lint

* add rspec

* add participatory_space_type to table

* fix lint

* refactoring

* change method's name

* add config for types_user_roles

* change view and helper, move building html to view from helper

* fix lint

* fix lint

* add presenter, remove helper

* fix pagination

* add link to participatory space, add presenter spec

* extract the i18n version of the role

* add rspec PaperTrailVersion

* rspec PaperTrailRolePresenter

* Fix presenter

* fix tests

* fix presenter

* handle deleted users

* fix checksums

---------

Co-authored-by: Ivan Vergés <[email protected]>

* Search and filtering (#8)

* add Filterable

* fix searching and filtering

* add filter by date

* add rspec

* change ransacker method name

* change locale

* fix test

* fix filter by date examples

---------

Co-authored-by: Ivan Vergés <[email protected]>

* Export excel/csv (#9)

* add export of admin_actions

* restore Gemfile.lock

* update gemfile

* add reference decidim admin for locales

* commit used Decidim styles

* restore envs

* remove default

* add tests

---------

Co-authored-by: Ivan Vergés <[email protected]>

* configurable roles from initializer (#10)

* translate values

* make roles configurable

* fix tests

* Show superadmins in admin accountability (#12)

* refactor initializer & presenter clasess

* complete space role test

* differentiate admins from space admins

* add user presenter specs

* fix filters

* add tests for super admins

* fix tests

* fix permissions

* Add readme instructions

* update version

* fix readme

---------

Co-authored-by: Anna Topalidi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants