Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(refactor) O3-2964:Appointments: Refactor useVisits to useTodaysVisits #1037

Merged
merged 11 commits into from
Mar 15, 2024

Conversation

mogoodrich
Copy link
Member

See my description here:
https://openmrs.atlassian.net/browse/O3-2964

(And note that this may all change in the (near?) future):
https://openmrs.atlassian.net/browse/O3-2963

Requirements

  • This PR has a title that briefly describes the work done including the ticket number. If there is a ticket, make sure your PR title includes a conventional commit label. See existing PR titles for inspiration.
  • My work conforms to the OpenMRS 3.0 Styleguide and design documentation.
  • My work includes tests or is validated by existing tests.

Summary

Screenshots

Related Issue

Other

@mogoodrich mogoodrich requested review from donaldkibet, chibongho, ibacher, mseaton and ojwanganto and removed request for donaldkibet and chibongho March 14, 2024 16:04
Copy link
Contributor

github-actions bot commented Mar 14, 2024

Size Change: -376 kB (-11%) 👏

Total Size: 3.06 MB

Filename Size Change
packages/esm-active-visits-app/dist/130.js 148 kB +24.9 kB (+20%) 🚨
packages/esm-appointments-app/dist/130.js 148 kB +24.9 kB (+20%) 🚨
packages/esm-appointments-app/dist/368.js 0 B -44.3 kB (removed) 🏆
packages/esm-patient-list-management-app/dist/130.js 148 kB +24.9 kB (+20%) 🚨
packages/esm-patient-list-management-app/dist/435.js 0 B -22.7 kB (removed) 🏆
packages/esm-patient-registration-app/dist/130.js 148 kB +24.9 kB (+20%) 🚨
packages/esm-patient-registration-app/dist/209.js 0 B -36.4 kB (removed) 🏆
packages/esm-patient-registration-app/dist/730.js 0 B -115 kB (removed) 🏆
packages/esm-patient-registration-app/dist/main.js 130 kB -23.4 kB (-15%) 👏
packages/esm-patient-search-app/dist/130.js 148 kB +24.9 kB (+20%) 🚨
packages/esm-patient-search-app/dist/48.js 0 B -26.4 kB (removed) 🏆
packages/esm-patient-search-app/dist/710.js 0 B -22.8 kB (removed) 🏆
packages/esm-service-queues-app/dist/130.js 148 kB +24.9 kB (+20%) 🚨
packages/esm-service-queues-app/dist/523.js 0 B -56.9 kB (removed) 🏆
packages/esm-service-queues-app/dist/694.js 2.64 kB -155 kB (-98%) 🏆
ℹ️ View Unchanged
Filename Size Change
packages/esm-active-visits-app/dist/255.js 2.21 kB 0 B
packages/esm-active-visits-app/dist/271.js 762 B 0 B
packages/esm-active-visits-app/dist/277.js 13.4 kB +25 B (0%)
packages/esm-active-visits-app/dist/316.js 42.9 kB 0 B
packages/esm-active-visits-app/dist/319.js 683 B 0 B
packages/esm-active-visits-app/dist/382.js 1.15 kB 0 B
packages/esm-active-visits-app/dist/448.js 47.1 kB 0 B
packages/esm-active-visits-app/dist/460.js 784 B 0 B
packages/esm-active-visits-app/dist/574.js 588 B 0 B
packages/esm-active-visits-app/dist/588.js 6.66 kB 0 B
packages/esm-active-visits-app/dist/635.js 1.15 kB 0 B
packages/esm-active-visits-app/dist/644.js 762 B 0 B
packages/esm-active-visits-app/dist/729.js 3.1 kB 0 B
packages/esm-active-visits-app/dist/757.js 695 B 0 B
packages/esm-active-visits-app/dist/784.js 2.63 kB 0 B
packages/esm-active-visits-app/dist/788.js 586 B 0 B
packages/esm-active-visits-app/dist/807.js 918 B 0 B
packages/esm-active-visits-app/dist/833.js 732 B 0 B
packages/esm-active-visits-app/dist/879.js 2.94 kB 0 B
packages/esm-active-visits-app/dist/main.js 65 kB +27 B (0%)
packages/esm-active-visits-app/dist/openmrs-esm-active-visits-app.js 3.33 kB -1 B (0%)
packages/esm-appointments-app/dist/152.js 257 B 0 B
packages/esm-appointments-app/dist/255.js 2.21 kB 0 B
packages/esm-appointments-app/dist/271.js 2.21 kB 0 B
packages/esm-appointments-app/dist/303.js 258 B 0 B
packages/esm-appointments-app/dist/319.js 2.12 kB 0 B
packages/esm-appointments-app/dist/365.js 44.5 kB 0 B
packages/esm-appointments-app/dist/426.js 271 kB 0 B
packages/esm-appointments-app/dist/460.js 2.31 kB 0 B
packages/esm-appointments-app/dist/500.js 2.5 kB 0 B
packages/esm-appointments-app/dist/574.js 1.81 kB 0 B
packages/esm-appointments-app/dist/588.js 6.65 kB 0 B
packages/esm-appointments-app/dist/591.js 16.9 kB 0 B
packages/esm-appointments-app/dist/644.js 2.21 kB 0 B
packages/esm-appointments-app/dist/729.js 3.1 kB 0 B
packages/esm-appointments-app/dist/757.js 1.87 kB 0 B
packages/esm-appointments-app/dist/784.js 2.63 kB 0 B
packages/esm-appointments-app/dist/788.js 1.87 kB 0 B
packages/esm-appointments-app/dist/807.js 2.55 kB 0 B
packages/esm-appointments-app/dist/833.js 2.18 kB 0 B
packages/esm-appointments-app/dist/main.js 317 kB +193 B (0%)
packages/esm-appointments-app/dist/openmrs-esm-appointments-app.js 3.33 kB +1 B (0%)
packages/esm-patient-list-management-app/dist/255.js 2.21 kB 0 B
packages/esm-patient-list-management-app/dist/271.js 1.56 kB 0 B
packages/esm-patient-list-management-app/dist/295.js 99.3 kB 0 B
packages/esm-patient-list-management-app/dist/319.js 1.52 kB 0 B
packages/esm-patient-list-management-app/dist/382.js 1.15 kB 0 B
packages/esm-patient-list-management-app/dist/460.js 1.7 kB 0 B
packages/esm-patient-list-management-app/dist/574.js 1.34 kB 0 B
packages/esm-patient-list-management-app/dist/588.js 6.66 kB 0 B
packages/esm-patient-list-management-app/dist/591.js 16.9 kB 0 B
packages/esm-patient-list-management-app/dist/635.js 1.15 kB 0 B
packages/esm-patient-list-management-app/dist/644.js 1.56 kB 0 B
packages/esm-patient-list-management-app/dist/716.js 4.66 kB 0 B
packages/esm-patient-list-management-app/dist/729.js 3.1 kB 0 B
packages/esm-patient-list-management-app/dist/757.js 1.5 kB 0 B
packages/esm-patient-list-management-app/dist/784.js 2.64 kB 0 B
packages/esm-patient-list-management-app/dist/788.js 1.34 kB 0 B
packages/esm-patient-list-management-app/dist/807.js 1.84 kB 0 B
packages/esm-patient-list-management-app/dist/833.js 1.58 kB 0 B
packages/esm-patient-list-management-app/dist/995.js 21.9 kB 0 B
packages/esm-patient-list-management-app/dist/main.js 125 kB -802 B (-1%)
packages/esm-patient-list-management-app/dist/openmrs-esm-patient-list-management-app.js 3.29 kB -3 B (0%)
packages/esm-patient-registration-app/dist/152.js 262 B 0 B
packages/esm-patient-registration-app/dist/255.js 2.21 kB 0 B
packages/esm-patient-registration-app/dist/271.js 2.01 kB 0 B
packages/esm-patient-registration-app/dist/303.js 260 B 0 B
packages/esm-patient-registration-app/dist/319.js 1.99 kB 0 B
packages/esm-patient-registration-app/dist/460.js 2.12 kB 0 B
packages/esm-patient-registration-app/dist/481.js 6.75 kB 0 B
packages/esm-patient-registration-app/dist/537.js 2.34 kB 0 B
packages/esm-patient-registration-app/dist/574.js 1.7 kB 0 B
packages/esm-patient-registration-app/dist/591.js 16.9 kB 0 B
packages/esm-patient-registration-app/dist/62.js 0 B -6.86 kB (removed) 🏆
packages/esm-patient-registration-app/dist/644.js 2.01 kB 0 B
packages/esm-patient-registration-app/dist/676.js 6.59 kB 0 B
packages/esm-patient-registration-app/dist/686.js 92 kB 0 B
packages/esm-patient-registration-app/dist/729.js 3.1 kB 0 B
packages/esm-patient-registration-app/dist/735.js 464 B 0 B
packages/esm-patient-registration-app/dist/757.js 2.07 kB 0 B
packages/esm-patient-registration-app/dist/783.js 36.2 kB 0 B
packages/esm-patient-registration-app/dist/784.js 2.64 kB 0 B
packages/esm-patient-registration-app/dist/788.js 1.7 kB -5 B (0%)
packages/esm-patient-registration-app/dist/807.js 2.43 kB 0 B
packages/esm-patient-registration-app/dist/833.js 1.97 kB 0 B
packages/esm-patient-registration-app/dist/879.js 2.94 kB 0 B
packages/esm-patient-registration-app/dist/884.js 0 B -6.1 kB (removed) 🏆
packages/esm-patient-registration-app/dist/openmrs-esm-patient-registration-app.js 3.34 kB 0 B
packages/esm-patient-search-app/dist/152.js 0 B -261 B (removed) 🏆
packages/esm-patient-search-app/dist/255.js 2.21 kB 0 B
packages/esm-patient-search-app/dist/271.js 1.12 kB 0 B
packages/esm-patient-search-app/dist/303.js 0 B -260 B (removed) 🏆
packages/esm-patient-search-app/dist/319.js 1.06 kB 0 B
packages/esm-patient-search-app/dist/382.js 1.15 kB 0 B
packages/esm-patient-search-app/dist/460.js 1.16 kB 0 B
packages/esm-patient-search-app/dist/574.js 732 B -178 B (-20%) 🎉
packages/esm-patient-search-app/dist/584.js 21.7 kB 0 B
packages/esm-patient-search-app/dist/588.js 6.66 kB 0 B
packages/esm-patient-search-app/dist/591.js 16.9 kB 0 B
packages/esm-patient-search-app/dist/635.js 1.15 kB 0 B
packages/esm-patient-search-app/dist/644.js 1.12 kB 0 B
packages/esm-patient-search-app/dist/729.js 3.1 kB 0 B
packages/esm-patient-search-app/dist/757.js 1.06 kB 0 B
packages/esm-patient-search-app/dist/778.js 23.1 kB 0 B
packages/esm-patient-search-app/dist/784.js 2.63 kB 0 B
packages/esm-patient-search-app/dist/788.js 905 B 0 B
packages/esm-patient-search-app/dist/807.js 1.3 kB 0 B
packages/esm-patient-search-app/dist/833.js 1.08 kB 0 B
packages/esm-patient-search-app/dist/main.js 48 kB -4.33 kB (-8%)
packages/esm-patient-search-app/dist/openmrs-esm-patient-search-app.js 3.3 kB -39 B (-1%)
packages/esm-service-queues-app/dist/115.js 55.9 kB 0 B
packages/esm-service-queues-app/dist/152.js 262 B 0 B
packages/esm-service-queues-app/dist/203.js 0 B -2.64 kB (removed) 🏆
packages/esm-service-queues-app/dist/255.js 2.22 kB 0 B
packages/esm-service-queues-app/dist/271.js 3.85 kB 0 B
packages/esm-service-queues-app/dist/303.js 261 B 0 B
packages/esm-service-queues-app/dist/319.js 3.29 kB 0 B
packages/esm-service-queues-app/dist/328.js 3.29 kB +164 B (+5%) 🔍
packages/esm-service-queues-app/dist/389.js 1.89 kB -2 B (0%)
packages/esm-service-queues-app/dist/425.js 2.08 kB -1 B (0%)
packages/esm-service-queues-app/dist/460.js 4.09 kB 0 B
packages/esm-service-queues-app/dist/473.js 158 kB 0 B
packages/esm-service-queues-app/dist/574.js 3.34 kB -33 B (-1%)
packages/esm-service-queues-app/dist/588.js 6.66 kB 0 B
packages/esm-service-queues-app/dist/591.js 16.9 kB 0 B
packages/esm-service-queues-app/dist/616.js 2.71 kB 0 B
packages/esm-service-queues-app/dist/644.js 3.85 kB 0 B
packages/esm-service-queues-app/dist/696.js 3.69 kB 0 B
packages/esm-service-queues-app/dist/729.js 3.1 kB 0 B
packages/esm-service-queues-app/dist/738.js 3.69 kB +2 B (0%)
packages/esm-service-queues-app/dist/757.js 3.29 kB 0 B
packages/esm-service-queues-app/dist/784.js 2.63 kB 0 B
packages/esm-service-queues-app/dist/788.js 3.29 kB 0 B
packages/esm-service-queues-app/dist/807.js 4.55 kB 0 B
packages/esm-service-queues-app/dist/833.js 3.8 kB 0 B
packages/esm-service-queues-app/dist/981.js 2.95 kB -2 B (0%)
packages/esm-service-queues-app/dist/main.js 217 kB -895 B (0%)
packages/esm-service-queues-app/dist/openmrs-esm-service-queues-app.js 3.3 kB -3 B (0%)

compressed-size-action

@donaldkibet
Copy link
Member

@mogoodrich, Upon review, it appears that the useVisit hook and appointment-actions component may no longer be necessary due to a shift in our interpretation of when an appointment is considered CheckedIn or CheckedOut at Palladium. Initially, we relied on verifying scheduled appointments for the specified date had associated visits, but we've now repurposed appointment status to fulfill this requirement. cc @ojwanganto

Copy link
Member

@mseaton mseaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me, assuming we only ever want to get todays appointments and not some other days appointment shere.

@mogoodrich
Copy link
Member Author

Oh, great @donaldkibet ... yes, see the other ticket I wrote: https://openmrs.atlassian.net/browse/O3-2963

I do feel like this functionality will go away entirely in the not-to-distance future.

Justus446 and others added 9 commits March 15, 2024 09:50
…icks for queue transition. (#1026)

* added loading functionality to move to next service button

* inline style to button and display

* styles fixes

* Update packages/esm-service-queues-app/src/active-visits/change-status-dialog.scss

Co-authored-by: Donald Kibet <[email protected]>

* Update packages/esm-service-queues-app/src/active-visits/change-status-dialog.component.tsx

Co-authored-by: Donald Kibet <[email protected]>

* Update packages/esm-service-queues-app/src/active-visits/change-status-dialog.component.tsx

Co-authored-by: Donald Kibet <[email protected]>

* code formatting

* scss add semi colon

* remove one state for priority :defined twice

---------

Co-authored-by: Justus446 <[email protected]>
Co-authored-by: Donald Kibet <[email protected]>
…efault location in appointment form (#1034)

* pick & display default location  on the location dropdown

* appointment action test fixes on button name

* fix to add only unique locations to locations array

---------

Co-authored-by: Justus446 <[email protected]>
Co-authored-by: Donald Kibet <[email protected]>
#1038)

* (feature) O3-2965:Appointments: Have a way to disable Check In and Check Out buttons

* (feature) O3-2966: Appointments: Support custom form when checking in and checking out (#1040)
#1038)

* (feature) O3-2965:Appointments: Have a way to disable Check In and Check Out buttons

* (feature) O3-2966: Appointments: Support custom form when checking in and checking out (#1040)
# Conflicts:
#	packages/esm-appointments-app/src/appointments/common-components/appointments-actions.test.tsx
@mogoodrich mogoodrich merged commit 8add996 into main Mar 15, 2024
6 checks passed
@mogoodrich mogoodrich deleted the O3-2964 branch March 15, 2024 17:42
mogoodrich added a commit that referenced this pull request Mar 15, 2024
#1037)

(feature) O3-2965:Appointments: Have a way to disable Check In and Ch… (#1038)
(feature) O3-2966: Appointments: Support custom form when checking in and checking out (#1040)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants