-
Notifications
You must be signed in to change notification settings - Fork 234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(refactor) O3-2964:Appointments: Refactor useVisits to useTodaysVisits #1037
Conversation
Size Change: -376 kB (-11%) 👏 Total Size: 3.06 MB
ℹ️ View Unchanged
|
@mogoodrich, Upon review, it appears that the useVisit hook and appointment-actions component may no longer be necessary due to a shift in our interpretation of when an appointment is considered |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine to me, assuming we only ever want to get todays appointments and not some other days appointment shere.
Oh, great @donaldkibet ... yes, see the other ticket I wrote: https://openmrs.atlassian.net/browse/O3-2963 I do feel like this functionality will go away entirely in the not-to-distance future. |
…icks for queue transition. (#1026) * added loading functionality to move to next service button * inline style to button and display * styles fixes * Update packages/esm-service-queues-app/src/active-visits/change-status-dialog.scss Co-authored-by: Donald Kibet <[email protected]> * Update packages/esm-service-queues-app/src/active-visits/change-status-dialog.component.tsx Co-authored-by: Donald Kibet <[email protected]> * Update packages/esm-service-queues-app/src/active-visits/change-status-dialog.component.tsx Co-authored-by: Donald Kibet <[email protected]> * code formatting * scss add semi colon * remove one state for priority :defined twice --------- Co-authored-by: Justus446 <[email protected]> Co-authored-by: Donald Kibet <[email protected]>
…efault location in appointment form (#1034) * pick & display default location on the location dropdown * appointment action test fixes on button name * fix to add only unique locations to locations array --------- Co-authored-by: Justus446 <[email protected]> Co-authored-by: Donald Kibet <[email protected]>
…uired` field validation (#1030)
… and checking out comment out tests
# Conflicts: # packages/esm-appointments-app/src/appointments/common-components/appointments-actions.test.tsx
See my description here:
https://openmrs.atlassian.net/browse/O3-2964
(And note that this may all change in the (near?) future):
https://openmrs.atlassian.net/browse/O3-2963
Requirements
Summary
Screenshots
Related Issue
Other