(refactor) O3-2831: Move patient banner into styleguide #1018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
subhamkumarr
approved these changes
Mar 9, 2024
4 tasks
brandones
force-pushed
the
styleguide-component-banner
branch
from
ab884f5 to
5684dfb
Compare
brandones
changed the title
|
Size Change: -332 kB (-10%) 👏 Total Size: 3.06 MB
ℹ️ View Unchanged
|
ibacher
approved these changes
Mar 14, 2024
|
Oops, the e2e tests depended on some testids I deleted. I haven't gotten e2e tests working on my machine so I just reverted those little changes. I think it would be preferable to use testids less and user-visible features more. |
|
Yeah, @brandones. WAI-ARIA roles are the way to go. |
mogoodrich
added a commit
that referenced
this pull request
Mar 15, 2024
#1037) * (refactor) O3-2964:Appointments: Refactor useVisits to useTodaysVisits * (refactor) O3-2831: Move patient banner into styleguide (#1018) * (enhc) disable submit button and show submitting status while user clicks for queue transition. (#1026) * added loading functionality to move to next service button * inline style to button and display * styles fixes * Update packages/esm-service-queues-app/src/active-visits/change-status-dialog.scss Co-authored-by: Donald Kibet <[email protected]> * Update packages/esm-service-queues-app/src/active-visits/change-status-dialog.component.tsx Co-authored-by: Donald Kibet <[email protected]> * Update packages/esm-service-queues-app/src/active-visits/change-status-dialog.component.tsx Co-authored-by: Donald Kibet <[email protected]> * code formatting * scss add semi colon * remove one state for priority :defined twice --------- Co-authored-by: Justus446 <[email protected]> Co-authored-by: Donald Kibet <[email protected]> * (fix) pick current user session location or appointment location as default location in appointment form (#1034) * pick & display default location on the location dropdown * appointment action test fixes on button name * fix to add only unique locations to locations array --------- Co-authored-by: Justus446 <[email protected]> Co-authored-by: Donald Kibet <[email protected]> * (enhc) Add ability to config person and address field to support `required` field validation (#1030) * (chore) Release v6.1.0 (#1041) * (feature) O3-2965:Appointments: Have a way to disable Check In and Ch… (#1038) * (feature) O3-2965:Appointments: Have a way to disable Check In and Check Out buttons * (feature) O3-2966: Appointments: Support custom form when checking in and checking out (#1040) * (refactor) O3-2964:Appointments: Refactor useVisits to useTodaysVisits * (feature) O3-2965:Appointments: Have a way to disable Check In and Ch… (#1038) * (feature) O3-2965:Appointments: Have a way to disable Check In and Check Out buttons * (feature) O3-2966: Appointments: Support custom form when checking in and checking out (#1040) * (feature) O3-2966: Appointments: Support custom form when checking in and checking out comment out tests --------- Co-authored-by: Brandon Istenes <[email protected]> Co-authored-by: Justus Omondi <[email protected]> Co-authored-by: Justus446 <[email protected]> Co-authored-by: Donald Kibet <[email protected]> Co-authored-by: Jayasanka Weerasinghe <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on openmrs/openmrs-esm-core#919
Requirements
Summary
Deleted a lot of code that is now in esm-styleguide.
Deprecate the patient-photo extension.
Screenshots
See the Core PR.
Related Issue
https://issues.openmrs.org/browse/O3-2831