Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(fix) O3-4312: Add translation to start visit workspace title #2169

Merged
merged 6 commits into from
Jan 9, 2025
Merged

(fix) O3-4312: Add translation to start visit workspace title #2169

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
69b4dc1
fix: fix start a visit workspace title not translated
usamaidrsk Jan 8, 2025
f14d05c
Merge branch 'main' into fix-O3-4312
usamaidrsk Jan 8, 2025
4ff9ca9
Merge branch 'main' into fix-O3-4312
denniskigen Jan 9, 2025
ed40084
Update index.ts
vasharma05 Jan 9, 2025
11d1309
fix: title key from Start vist to Start a visit
usamaidrsk Jan 9, 2025
912f552
fix: register start visit as a workspace not extension
usamaidrsk Jan 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/esm-patient-chart-app/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,7 +159,7 @@ export const genericDashboard = getSyncLifecycle(genericDashboardComponent, {
moduleName,
});

// t('startAVisit', 'Start a visit')
// t('startVisit', 'Start visit')
Copy link
Member Author

@usamaidrsk usamaidrsk Jan 9, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @vasharma05 , however this will change the design, from Start a visit to Start visit. See here

Copy link
Member

@denniskigen denniskigen Jan 9, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably change that key to something different altogether. I propose startVisitWorkspaceTitle to match what we're doing in the orders app. Additionally, and maybe this is beyond the scope of this PR, we should also probably register this workspace using the workspaces key in the routes.json file.

Registering workspaces using extensions isn't the ideal approach at this point. Using the workspace system has the added benefit of saner handling of things like workspace titles and other metadata.

export const startVisitForm = getSyncLifecycle(startVisitFormComponent, {
featureName: 'start-visit-form',
moduleName,
Expand Down
Loading