(fix) O3-4312: Add translation to start visit workspace title #2169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: -155 kB (-0.96%) Total Size: 16.1 MB
ℹ️ View Unchanged
|
vasharma05
changed the title
vasharma05
requested changes
Jan 8, 2025
usamaidrsk
force-pushed
the
fix-O3-4312
branch
from
4d4e1b3 to
69b4dc1
Compare
vasharma05
reviewed
Jan 9, 2025
| @@ -159,6 +159,7 @@ export const genericDashboard = getSyncLifecycle(genericDashboardComponent, { | |||
| moduleName, | |||
| }); | |||
|
|
|||
| // t('startAVisit', 'Start a visit') | |||
There was a problem hiding this comment.
The key mentioned in the routes.json file is startVisit not startAVisit. Please take of these things.
Let's not try to create a new key, and keep the translations as is.
Thanks!
There was a problem hiding this comment.
Thanks @vasharma05 , however the startAVisit key is also used on the visit header component too here , which is the same key needed as the workspace title "Start a visit".
vasharma05
approved these changes
Jan 9, 2025
usamaidrsk
commented
Jan 9, 2025
| @@ -159,7 +159,7 @@ export const genericDashboard = getSyncLifecycle(genericDashboardComponent, { | |||
| moduleName, | |||
| }); | |||
|
|
|||
| // t('startAVisit', 'Start a visit') | |||
| // t('startVisit', 'Start visit') | |||
There was a problem hiding this comment.
Thanks @vasharma05 , however this will change the design, from Start a visit to Start visit. See here
There was a problem hiding this comment.
We should probably change that key to something different altogether. I propose startVisitWorkspaceTitle to match what we're doing in the orders app. Additionally, and maybe this is beyond the scope of this PR, we should also probably register this workspace using the workspaces key in the routes.json file.
Registering workspaces using extensions isn't the ideal approach at this point. Using the workspace system has the added benefit of saner handling of things like workspace titles and other metadata.
denniskigen
approved these changes
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Summary
This PR fixed the start visit workspace title to use the
startVisittranslation key.Screenshots
Related Issue
https://openmrs.atlassian.net/browse/O3-4312
Other