Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(fix) Fix accordion wrapper UI in the React Form Engine #1908

Closed
wants to merge 4 commits into from
Closed

(fix) Fix accordion wrapper UI in the React Form Engine #1908

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f67321d
fix broken form section issue
kajambiya Jul 11, 2024
51010f0
Better naming
denniskigen Jul 11, 2024
a4248c4
Merge branch 'main' into fix/broken-form-UI
denniskigen Jul 12, 2024
4a61cb6
Merge branch 'main' into fix/broken-form-UI
denniskigen Jul 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/esm-form-engine-app/src/form-renderer/form-renderer.component.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ const FormRenderer: React.FC<FormRendererProps> = ({
}

return (
<>
<div className={styles.formEngineContainer}>
{schema && (
<FormEngine
encounterUUID={encounterUuid}
Expand All @@ -87,7 +87,7 @@ const FormRenderer: React.FC<FormRendererProps> = ({
visit={visit}
/>
)}
</>
</div>
);
};

Expand Down
7 changes: 7 additions & 0 deletions packages/esm-form-engine-app/src/form-renderer/form-renderer.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,3 +16,10 @@
.errorContainer {
height: 100vh;
}

.formEngineContainer {
// TODO: try removing this after carbon upgrade PR is merged.
:global(.cds--accordion__wrapper) {
max-block-size: unset !important;
}
}
Loading