Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(fix) Fix accordion wrapper UI in the React Form Engine #1908

Closed
wants to merge 4 commits into from

Conversation

kajambiya
Copy link
Contributor

@kajambiya kajambiya commented Jul 11, 2024

Requirements

  • This PR has a title that briefly describes the work done including the ticket number. If there is a ticket, make sure your PR title includes a conventional commit label. See existing PR titles for inspiration.
  • My work conforms to the OpenMRS 3.0 Styleguide and design documentation.
  • My work includes tests or is validated by existing tests.

Summary

Issue
The UI breaks when a form section is collapsed and expanded again. The root cause is a style introduced by the current Carbon version in the form-engine-app, which sets max-block-size: 32px; when the form section is expanded.

Previous Fix
This issue was initially addressed in PR #341, where we attempted to override the problematic style at the form page level.

Current Fix
The issue has resurfaced, so we've applied the override at the form-engine container level.

Future Resolution
We anticipate that once the Carbon version is upgraded (see PR here), this override will no longer be necessary.

Screenshots

Issue:

Screen.Recording.2024-07-11.at.15.36.51.mov

Fix:

Screen.Recording.2024-07-11.at.15.43.49.mov

Related Issue

Other

@kajambiya kajambiya requested a review from denniskigen July 11, 2024 13:30
@denniskigen denniskigen changed the title (fix) fix broken form section UI (fix) Fix accordion wrapper UI in the React Form Engine Jul 12, 2024
@samuelmale
Copy link
Member

I would expect this fix (in the RFE lib) to suffice; Meaning bumping RFE should fix this issue.

@samuelmale
Copy link
Member

Closing this because issue has been fixed at 4b7bba8

@samuelmale samuelmale closed this Jul 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants