(fix) Fix accordion wrapper UI in the React Form Engine #1908
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Summary
Issue
The UI breaks when a form section is collapsed and expanded again. The root cause is a style introduced by the current Carbon version in the form-engine-app, which sets max-block-size: 32px; when the form section is expanded.
Previous Fix
This issue was initially addressed in PR #341, where we attempted to override the problematic style at the form page level.
Current Fix
The issue has resurfaced, so we've applied the override at the form-engine container level.
Future Resolution
We anticipate that once the Carbon version is upgraded (see PR here), this override will no longer be necessary.
Screenshots
Issue:
Screen.Recording.2024-07-11.at.15.36.51.mov
Fix:
Screen.Recording.2024-07-11.at.15.43.49.mov
Related Issue
Other