Mark sklearn tests #1202
Merged
Mark sklearn tests #1202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mfeurer
reviewed
Feb 20, 2023
PGijsbers
force-pushed
the
mark_sklearn_tests
branch
from
dfe29ea
to
a1f09f8
Compare
PGijsbers
force-pushed
the
mark_sklearn_tests
branch
2 times, most recently
from
d49fdc6
to
a17282e
Compare
mfeurer
reviewed
Feb 22, 2023
There was a problem hiding this comment.
This looks great, but there are some jobs that are manually added to the jobs matrix that have no sk_only flag set, do we intend to only run scikit-learn tests for them, too?
Also, it would be great if we can discuss what we test for which version briefly offline.
PGijsbers
force-pushed
the
mark_sklearn_tests
branch
from
b9b8c95
to
7417cfe
Compare
The generic tests that don't use scikit-learn should only be tested once (per platform).
PGijsbers
force-pushed
the
mark_sklearn_tests
branch
from
7417cfe
to
1db1ff7
Compare
mfeurer
approved these changes
Feb 23, 2023
mfeurer
pushed a commit
that referenced
this pull request
Feb 24, 2023
…n run.data_content (#1209) * add test and fix for switch of ground truth and predictions * undo import optimization * fix bug with model passing to function * fix order in other tests * update progress.rst * new unit test for run consistency and bug fixed * clarify new assert * minor loop refactor * refactor default to None * directly test prediction data equal * Update tests/test_runs/test_run.py Co-authored-by: Pieter Gijsbers <[email protected]> * Mark sklearn tests (#1202) * Add sklearn marker * Mark tests that use scikit-learn * Only run scikit-learn tests multiple times The generic tests that don't use scikit-learn should only be tested once (per platform). * Rename for correct variable * Add sklearn mark for filesystem test * Remove quotes around sklearn * Instead include sklearn in the matrix definition * Update jobnames * Add explicit false to jobname * Remove space * Add function inside of expression? * Do string testing instead * Add missing ${{ * Add explicit true to old sklearn tests * Add instruction to add pytest marker for sklearn tests * add test and fix for switch of ground truth and predictions * undo import optimization * fix mask error resulting from rebase * make dummy classifier strategy consistent to avoid problems as a result of the random state problems for sklearn < 0.24 --------- Co-authored-by: Pieter Gijsbers <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1186
Marks 103 tests that use scikit-learn. I hope it is exhaustive, though it is possible I missed a few.
Updated the Github Workflow to only run scikit-learn dependent tests by default, as most matrix jobs are specifically to test different scikit-learn versions (and non sklearn tests should not be affected by scikit-learn version). The code coverage and windows job still run the full suite.
Built on top of #1199, #1200 (hence the draft state).