Update tests for sklearn 1.2, server issue #1200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
mfeurer
reviewed
Feb 20, 2023
| ): | ||
| # The exact error message depends on scikit-learn version. | ||
| # Because the sklearn-extension module is to be separated, | ||
| # I will simply relax specifics of the raised Error. |
There was a problem hiding this comment.
Would it be possible to test on a more relaxed regex so we can make sure that we test for the right thing?
mfeurer
approved these changes
Feb 20, 2023
PGijsbers
added a commit
to Mirkazemi/openml-python
that referenced
this pull request
Feb 23, 2023
* Relax error checking * Skip unit test due to server issue openml/OpenML#1180 * Account for rename parameter `base_estimator` to `estimator` in sk 1.2 * Update n_init parameter for sklearn 1.2 * Test for more specific exceptions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few tests got outdated with
scikit-learn >= 1.2. One tests seems to fail due to the test server, for which I opened an issue here. After these fixes I get all green again (together with #1199).