Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce lower_left in lattice geometry #2982

Merged
merged 3 commits into from
Jun 10, 2024
Merged

Enforce lower_left in lattice geometry #2982

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
405646c
lower_left member of lattice is enforced with user-friendly error
kmeag Apr 26, 2024
2f6d356
lower_left member of lattice is enforced with user-friendly error
kmeag Apr 26, 2024
ed59e58
Fix check for lattice lower_left when exporting XML
paulromano Jun 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions openmc/lattice.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -875,6 +875,10 @@ def create_xml_subelement(self, xml_element, memo=None):
dimension = ET.SubElement(lattice_subelement, "dimension")
dimension.text = ' '.join(map(str, self.shape))

# Make sure lower_left has been specified
if self.lower_left is None:
raise ValueError(f"Lattice {self.id} does not have lower_left specified.")

# Export Lattice lower left
lower_left = ET.SubElement(lattice_subelement, "lower_left")
lower_left.text = ' '.join(map(str, self._lower_left))
Expand Down