Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce lower_left in lattice geometry #2982

Merged
merged 3 commits into from
Jun 10, 2024

Conversation

kmeag
Copy link
Contributor

@kmeag kmeag commented Apr 26, 2024

Description

When exporting a lattice geometry to XML without the lower_left specified, an error is thrown that is hard to debug. I localized this in the code and threw a helpful error so that a user is less frustrated when this happens.

ValueError: Lattice 1 <lower_left> has not been specified.

Fixes #2902

Checklist

  • I have performed a self-review of my own code
  • I have run clang-format (version 15) on any C++ source files (if applicable)
  • I have followed the style guidelines for Python source files (if applicable)
  • I have made corresponding changes to the documentation (if applicable)
  • I have added tests that prove my fix is effective or that my feature works (if applicable)

Copy link
Contributor

@paulromano paulromano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @kmeag!

@paulromano paulromano enabled auto-merge (squash) June 10, 2024 17:11
@paulromano paulromano merged commit 12a278b into openmc-dev:develop Jun 10, 2024
17 checks passed
church89 pushed a commit to openmsr/openmc that referenced this pull request Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Object state is not enforced for Lattice
2 participants