Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose universe plotting for the geometry class #2661

Merged
merged 1 commit into from
Aug 22, 2023

Conversation

shimwell
Copy link
Member

@shimwell shimwell commented Aug 21, 2023

As mention in #2648 it would save users accessing the root_universe when plotting a geometry if the plot method was exposed to the openmc.Geometry class.

Checklist

  • I have performed a self-review of my own code
  • I have run clang-format on any C++ source files (if applicable)
  • I have followed the style guidelines for Python source files (if applicable)
  • I have made corresponding changes to the documentation (if applicable)
  • I have added tests that prove my fix is effective or that my feature works (if applicable)

Copy link
Contributor

@pshriwise pshriwise left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, @shimwell! Pretty straightforward, but I'll give it a 24 hr cooldown for others to take a look as well.

@pshriwise
Copy link
Contributor

I went ahead and ticked the testing box for you @shimwell. Given that this relies on the already-tested Universe.plot method I don't think it's necessary to include additional tests here.

@pshriwise pshriwise merged commit ffbf1b9 into openmc-dev:develop Aug 22, 2023
stchaker pushed a commit to stchaker/openmc that referenced this pull request Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants